From 35fba2de409f241304e911101c6627903a5de33f Mon Sep 17 00:00:00 2001
From: Nikos Gorogiannis <nikosgorogiannis@fb.com>
Date: Thu, 14 Jun 2018 01:28:04 -0700
Subject: [PATCH] [starvation] skip generated code

Summary: Code auto generated by annotation processors or by the compiler is creating non-actionable reports, so skip it for now.

Reviewed By: jeremydubreil

Differential Revision: D8395781

fbshipit-source-id: 9832814
---
 infer/src/concurrency/starvation.ml | 22 +++++++++++++++-------
 1 file changed, 15 insertions(+), 7 deletions(-)

diff --git a/infer/src/concurrency/starvation.ml b/infer/src/concurrency/starvation.ml
index 769721f94..0b018f19c 100644
--- a/infer/src/concurrency/starvation.ml
+++ b/infer/src/concurrency/starvation.ml
@@ -277,6 +277,16 @@ let should_report_deadlock_on_current_proc current_elem endpoint_elem =
             < 0
 
 
+let should_report pdesc =
+  match Procdesc.get_proc_name pdesc with
+  | Typ.Procname.Java java_pname ->
+      Procdesc.get_access pdesc <> PredSymb.Private
+      && not (Typ.Procname.Java.is_autogen_method java_pname)
+      && not (Typ.Procname.Java.is_class_initializer java_pname)
+  | _ ->
+      L.(die InternalError "Not supposed to run on non-Java code.")
+
+
 let fold_reportable_summaries (tenv, current_pdesc) get_proc_desc clazz ~init ~f =
   let methods =
     Tenv.lookup tenv clazz
@@ -285,12 +295,10 @@ let fold_reportable_summaries (tenv, current_pdesc) get_proc_desc clazz ~init ~f
   let f acc mthd =
     get_proc_desc mthd
     |> Option.value_map ~default:acc ~f:(fun other_pdesc ->
-           match Procdesc.get_access other_pdesc with
-           | PredSymb.Private ->
-               acc
-           | _ ->
-               Payload.read current_pdesc mthd |> Option.map ~f:(fun payload -> (mthd, payload))
-               |> Option.fold ~init:acc ~f )
+           if should_report other_pdesc then
+             Payload.read current_pdesc mthd |> Option.map ~f:(fun payload -> (mthd, payload))
+             |> Option.fold ~init:acc ~f
+           else acc )
   in
   List.fold methods ~init ~f
 
@@ -431,7 +439,7 @@ let report_starvation env get_proc_desc {StarvationDomain.events; ui} report_map
 let reporting {Callbacks.procedures; get_proc_desc; exe_env} =
   let report_procedure ((_, proc_desc) as env) =
     die_if_not_java proc_desc ;
-    if Procdesc.get_access proc_desc <> PredSymb.Private then
+    if should_report proc_desc then
       Payload.read proc_desc (Procdesc.get_proc_name proc_desc)
       |> Option.iter ~f:(fun summary ->
              report_deadlocks env get_proc_desc summary ReportMap.empty