From 3b3139a29efd625e236e166b1b76568bb8e3a872 Mon Sep 17 00:00:00 2001 From: Jules Villard Date: Fri, 17 May 2019 06:05:31 -0700 Subject: [PATCH] [biabd] kill Config.undo_join Summary: This was hardcoded to `true` and its purpose is unclear to me. I kill what confuses me. Reviewed By: jeremydubreil Differential Revision: D15294783 fbshipit-source-id: 3c1c469ee --- infer/src/base/Config.ml | 3 --- infer/src/base/Config.mli | 2 -- infer/src/biabduction/interproc.ml | 4 +--- 3 files changed, 1 insertion(+), 8 deletions(-) diff --git a/infer/src/base/Config.ml b/infer/src/base/Config.ml index 5b8bda41c..b0e252eed 100644 --- a/infer/src/base/Config.ml +++ b/infer/src/base/Config.ml @@ -273,9 +273,6 @@ let starvation_issues_dir_name = "starvation_issues" (** Enable detailed tracing information during array abstraction *) let trace_absarray = false -(** If true, optimize based on locality using reachability *) -let undo_join = true - let unsafe_unret = "<\"Unsafe_unretained\">" let weak = "<\"Weak\">" diff --git a/infer/src/base/Config.mli b/infer/src/base/Config.mli index 4aa1d1f9e..17c305b32 100644 --- a/infer/src/base/Config.mli +++ b/infer/src/base/Config.mli @@ -189,8 +189,6 @@ val trace_absarray : bool val trace_events_file : string -val undo_join : bool - val unsafe_unret : string val use_cost_threshold : bool diff --git a/infer/src/biabduction/interproc.ml b/infer/src/biabduction/interproc.ml index 3702192b7..7467c5b75 100644 --- a/infer/src/biabduction/interproc.ml +++ b/infer/src/biabduction/interproc.ml @@ -890,9 +890,7 @@ let perform_analysis_phase exe_env tenv (summary : Summary.t) (proc_cfg : ProcCf (match speco with None -> () | Some spec -> valid_specs := !valid_specs @ [spec]) ; speco in - if Config.undo_join then - ignore (BiabductionSummary.Jprop.filter filter candidate_preconditions) - else ignore (List.map ~f:filter candidate_preconditions) + ignore (BiabductionSummary.Jprop.filter filter candidate_preconditions) in let get_results () = let specs = !valid_specs in