From 3ebca8fd46f84ffee6587c6f59b25ef6f00bcd82 Mon Sep 17 00:00:00 2001 From: Jules Villard Date: Wed, 29 Apr 2020 02:58:37 -0700 Subject: [PATCH] [AI] premature exception reraising is premature Summary: We re-raise all exceptions a few lines below already so this is not needed. In fact it prevents us from writing the html cleanly before hitting the exception, which was bad. Reviewed By: ngorogiannis Differential Revision: D21257474 fbshipit-source-id: 0b7e2b8d3 --- infer/src/absint/AbstractInterpreter.ml | 2 -- 1 file changed, 2 deletions(-) diff --git a/infer/src/absint/AbstractInterpreter.ml b/infer/src/absint/AbstractInterpreter.ml index d7de2da69..1ff623aa0 100644 --- a/infer/src/absint/AbstractInterpreter.ml +++ b/infer/src/absint/AbstractInterpreter.ml @@ -294,8 +294,6 @@ module AbstractInterpreterCommon (TransferFunctions : NodeTransferFunctions) = s logged_error := false ; Ok post with exn -> - IExn.reraise_if exn ~f:(fun () -> - match exn with RestartScheduler.ProcnameAlreadyLocked _ -> true | _ -> false ) ; (* delay reraising to get a chance to write the debug HTML *) let backtrace = Caml.Printexc.get_raw_backtrace () in Error (exn, backtrace, instr)