From 49e832ed7fdf6f1fcc31829a3c41da90516d9dfd Mon Sep 17 00:00:00 2001
From: Jeremy Dubreil <jrm@fb.com>
Date: Fri, 7 Dec 2018 13:37:02 -0800
Subject: [PATCH] [infer] remove the Printf Args checker from the list of
 analyses run by default

Reviewed By: mbouaziz

Differential Revision: D13375374

fbshipit-source-id: 63fcb0062
---
 infer/man/man1/infer-analyze.txt | 10 +++++-----
 infer/man/man1/infer-full.txt    | 10 +++++-----
 infer/man/man1/infer.txt         | 10 +++++-----
 infer/src/base/Config.ml         |  2 +-
 4 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/infer/man/man1/infer-analyze.txt b/infer/man/man1/infer-analyze.txt
index da783a88c..53104923c 100644
--- a/infer/man/man1/infer-analyze.txt
+++ b/infer/man/man1/infer-analyze.txt
@@ -104,8 +104,8 @@ OPTIONS
        --no-default-checkers
            Deactivates: Default checkers: --annotation-reachability,
            --biabduction, --fragment-retains-view, --immutable-cast,
-           --linters, --liveness, --ownership, --printf-args, --racerd,
-           --siof, --uninit (Conversely: --default-checkers)
+           --linters, --liveness, --ownership, --racerd, --siof, --uninit
+           (Conversely: --default-checkers)
 
        --eradicate
            Activates: the eradicate @Nullable checker for Java annotations
@@ -212,11 +212,11 @@ OPTIONS
            Activates: Also log messages to stdout and stderr (Conversely:
            --no-print-logs)
 
-       --no-printf-args
-           Deactivates: the detection of mismatch between the Java printf
+       --printf-args
+           Activates: the detection of mismatch between the Java printf
            format strings and the argument types For, example, this checker
            will warn about the type error in `printf("Hello %d", "world")`
-           (Conversely: --printf-args)
+           (Conversely: --no-printf-args)
 
        --printf-args-only
            Activates: Enable --printf-args and disable all other checkers
diff --git a/infer/man/man1/infer-full.txt b/infer/man/man1/infer-full.txt
index e3e8e4b12..e04626081 100644
--- a/infer/man/man1/infer-full.txt
+++ b/infer/man/man1/infer-full.txt
@@ -249,8 +249,8 @@ OPTIONS
        --no-default-checkers
            Deactivates: Default checkers: --annotation-reachability,
            --biabduction, --fragment-retains-view, --immutable-cast,
-           --linters, --liveness, --ownership, --printf-args, --racerd,
-           --siof, --uninit (Conversely: --default-checkers)           See also infer-analyze(1).
+           --linters, --liveness, --ownership, --racerd, --siof, --uninit
+           (Conversely: --default-checkers)           See also infer-analyze(1).
 
        --no-default-linters
            Deactivates: Use the default linters for the analysis.
@@ -611,11 +611,11 @@ OPTIONS
            --no-print-logs)           See also infer-analyze(1), infer-capture(1), infer-report(1), and
            infer-run(1).
 
-       --no-printf-args
-           Deactivates: the detection of mismatch between the Java printf
+       --printf-args
+           Activates: the detection of mismatch between the Java printf
            format strings and the argument types For, example, this checker
            will warn about the type error in `printf("Hello %d", "world")`
-           (Conversely: --printf-args)           See also infer-analyze(1).
+           (Conversely: --no-printf-args)           See also infer-analyze(1).
 
        --printf-args-only
            Activates: Enable --printf-args and disable all other checkers
diff --git a/infer/man/man1/infer.txt b/infer/man/man1/infer.txt
index ab2a01794..857134e6f 100644
--- a/infer/man/man1/infer.txt
+++ b/infer/man/man1/infer.txt
@@ -249,8 +249,8 @@ OPTIONS
        --no-default-checkers
            Deactivates: Default checkers: --annotation-reachability,
            --biabduction, --fragment-retains-view, --immutable-cast,
-           --linters, --liveness, --ownership, --printf-args, --racerd,
-           --siof, --uninit (Conversely: --default-checkers)           See also infer-analyze(1).
+           --linters, --liveness, --ownership, --racerd, --siof, --uninit
+           (Conversely: --default-checkers)           See also infer-analyze(1).
 
        --no-default-linters
            Deactivates: Use the default linters for the analysis.
@@ -611,11 +611,11 @@ OPTIONS
            --no-print-logs)           See also infer-analyze(1), infer-capture(1), infer-report(1), and
            infer-run(1).
 
-       --no-printf-args
-           Deactivates: the detection of mismatch between the Java printf
+       --printf-args
+           Activates: the detection of mismatch between the Java printf
            format strings and the argument types For, example, this checker
            will warn about the type error in `printf("Hello %d", "world")`
-           (Conversely: --printf-args)           See also infer-analyze(1).
+           (Conversely: --no-printf-args)           See also infer-analyze(1).
 
        --printf-args-only
            Activates: Enable --printf-args and disable all other checkers
diff --git a/infer/src/base/Config.ml b/infer/src/base/Config.ml
index 2a49470cd..0f450c70d 100644
--- a/infer/src/base/Config.ml
+++ b/infer/src/base/Config.ml
@@ -654,7 +654,7 @@ and ( annotation_reachability
       "[EXPERIMENTAL] Nullable type checker (incomplete: use --eradicate for now)"
   and ownership = mk_checker ~long:"ownership" ~default:true "the detection of C++ lifetime bugs"
   and printf_args =
-    mk_checker ~long:"printf-args" ~default:true
+    mk_checker ~long:"printf-args" ~default:false
       "the detection of mismatch between the Java printf format strings and the argument types \
        For, example, this checker will warn about the type error in `printf(\"Hello %d\", \
        \"world\")`"