From 5112fd2f32944fb854e3f4599c0dcbfb0bfe998d Mon Sep 17 00:00:00 2001
From: Jules Villard <jul@fb.com>
Date: Mon, 1 Feb 2021 11:57:37 -0800
Subject: [PATCH] [pulse] more topl debug

Summary:
Wrap the TOPL post-processing in the exit node debug wrapper too so that
we can see what it's doing if needed.

Reviewed By: skcho

Differential Revision: D26174365

fbshipit-source-id: dd63905ff
---
 infer/src/pulse/Pulse.ml        | 14 +++++++++++---
 infer/src/pulse/PulseSummary.ml |  5 +----
 2 files changed, 12 insertions(+), 7 deletions(-)

diff --git a/infer/src/pulse/Pulse.ml b/infer/src/pulse/Pulse.ml
index 1b42d31e7..7d32152b3 100644
--- a/infer/src/pulse/Pulse.ml
+++ b/infer/src/pulse/Pulse.ml
@@ -433,13 +433,21 @@ module DisjunctiveAnalyzer =
       let widen_policy = `UnderApproximateAfterNumIterations Config.pulse_widen_threshold
     end)
 
+let with_debug_exit_node proc_desc ~f =
+  AnalysisCallbacks.html_debug_new_node_session
+    (Procdesc.get_exit_node proc_desc)
+    ~pp_name:(fun fmt -> F.pp_print_string fmt "pulse summary creation")
+    ~f
+
+
 let checker ({InterproceduralAnalysis.proc_desc; err_log} as analysis_data) =
   AbstractValue.State.reset () ;
   let initial = [ExecutionDomain.mk_initial proc_desc] in
   match DisjunctiveAnalyzer.compute_post analysis_data ~initial proc_desc with
   | Some posts ->
-      let summary = PulseSummary.of_posts proc_desc posts in
-      report_topl_errors proc_desc err_log summary ;
-      Some summary
+      with_debug_exit_node proc_desc ~f:(fun () ->
+          let summary = PulseSummary.of_posts proc_desc posts in
+          report_topl_errors proc_desc err_log summary ;
+          Some summary )
   | None ->
       None
diff --git a/infer/src/pulse/PulseSummary.ml b/infer/src/pulse/PulseSummary.ml
index e957f921d..ac9b02c0b 100644
--- a/infer/src/pulse/PulseSummary.ml
+++ b/infer/src/pulse/PulseSummary.ml
@@ -19,7 +19,4 @@ let pp fmt summary =
   F.close_box ()
 
 
-let of_posts pdesc posts =
-  AnalysisCallbacks.html_debug_new_node_session (Procdesc.get_exit_node pdesc)
-    ~pp_name:(fun fmt -> F.pp_print_string fmt "pulse summary creation")
-    ~f:(fun () -> ExecutionDomain.summary_of_posts pdesc posts)
+let of_posts pdesc posts = ExecutionDomain.summary_of_posts pdesc posts