From 54946ce08e16cf0dfaa71a94d7f5883b92aa95aa Mon Sep 17 00:00:00 2001 From: Jeremy Dubreil Date: Tue, 14 Aug 2018 19:46:12 -0700 Subject: [PATCH] [infer] use the procedure name to match Java methods instead of the procedure id Summary: The procedure id is likely to be trucated with random CRC values so we should probably not use it to match Java names Reviewed By: mbouaziz Differential Revision: D9183518 fbshipit-source-id: b450c7869 --- infer/lib/python/inferlib/issues.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/infer/lib/python/inferlib/issues.py b/infer/lib/python/inferlib/issues.py index 7a488e0c6..f2092fff7 100644 --- a/infer/lib/python/inferlib/issues.py +++ b/infer/lib/python/inferlib/issues.py @@ -42,7 +42,6 @@ JSON_INDEX_ISL_ENUM = 'enum' JSON_INDEX_KIND = 'kind' JSON_INDEX_LINE = 'line' JSON_INDEX_PROCEDURE = 'procedure' -JSON_INDEX_PROCEDURE_ID = 'procedure_id' JSON_INDEX_QUALIFIER = 'qualifier' JSON_INDEX_QUALIFIER_TAGS = 'qualifier_tags' JSON_INDEX_TYPE = 'bug_type' @@ -229,7 +228,7 @@ def _pmd_xml_of_issues(issues): successful_java = False if issue[JSON_INDEX_FILENAME].endswith('.java'): fully_qualified_method_name = re.search( - '(.*)\(.*', issue[JSON_INDEX_PROCEDURE_ID]) + '(.*)\(.*', issue[JSON_INDEX_PROCEDURE]) if fully_qualified_method_name is not None: # probably Java, let's try try: