pghs975uc
/
infer_clone
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[racerd] kill non-deterministic test

Browse Source 
Summary:
The order by which the scheduler visits odd and even methods here
will determine if there is any report at all.  This is a bad test
so remove.

Reviewed By: fgasperij

Differential Revision: D19535537

fbshipit-source-id: 6b64b0de9
master
Nikos Gorogiannis 5 years ago committed by Facebook Github Bot
parent 66c6a73cc6
commit 5a1641d319
2 changed files with 7 additions and 17 deletions
Show Stats Download Patch File Download Diff File

9
infer/tests/codetoanalyze/java/racerd/ThreadSafeExample.java
Unescape View File

@ -38,15 +38,6 @@ public class ThreadSafeExample {
recursiveBad();
}
private void evenOk() {
f = 44;
oddBad();
}
public void oddBad() {
evenOk(); // should report here
}
// shouldn't report here because it's a private method
private void assignInPrivateMethodOk() {
f = 24;

15
infer/tests/codetoanalyze/java/racerd/issues.exp
Unescape View File

@ -106,16 +106,15 @@ codetoanalyze/java/racerd/ReadWriteRaces.java, codetoanalyze.java.checkers.ReadW
codetoanalyze/java/racerd/ReadWriteRaces.java, codetoanalyze.java.checkers.ReadWriteRaces.unprotectedRead2():java.lang.Object, 84, THREAD_SAFETY_VIOLATION, no_bucket, WARNING, [<Read trace>,access to `this.field2`,<Write trace>,access to `this.field2`]
codetoanalyze/java/racerd/ReadWriteRaces.java, codetoanalyze.java.checkers.ReadWriteRaces.unprotectedRead3():java.lang.Object, 96, THREAD_SAFETY_VIOLATION, no_bucket, WARNING, [<Read trace>,access to `this.field3`,<Write trace>,call to void ReadWriteRaces.syncWrite3(),access to `this.field3`]
codetoanalyze/java/racerd/SubFld.java, SubFld.getG():int, 28, THREAD_SAFETY_VIOLATION, no_bucket, WARNING, [<Read trace>,call to int SuperFld.getG(),access to `this.g`,<Write trace>,access to `this.g`]
codetoanalyze/java/racerd/ThreadSafeExample.java, codetoanalyze.java.checkers.ExtendsThreadSafeExample.newmethodBad():void, 141, THREAD_SAFETY_VIOLATION, no_bucket, WARNING, [access to `this.field`]
codetoanalyze/java/racerd/ThreadSafeExample.java, codetoanalyze.java.checkers.ExtendsThreadSafeExample.tsOK():void, 146, THREAD_SAFETY_VIOLATION, no_bucket, WARNING, [access to `this.field`]
codetoanalyze/java/racerd/ThreadSafeExample.java, codetoanalyze.java.checkers.ThreadSafeExample.FP_lazyInitOk():java.lang.Object, 130, THREAD_SAFETY_VIOLATION, no_bucket, WARNING, [<Read trace>,access to `this.sStaticField`,<Write trace>,access to `this.sStaticField`]
codetoanalyze/java/racerd/ThreadSafeExample.java, codetoanalyze.java.checkers.ThreadSafeExample.callPublicMethodBad():void, 57, THREAD_SAFETY_VIOLATION, no_bucket, WARNING, [call to void ThreadSafeExample.assignInPrivateMethodOk(),access to `this.f`]
codetoanalyze/java/racerd/ThreadSafeExample.java, codetoanalyze.java.checkers.ThreadSafeExample.callVisibleForTestingBad():void, 109, THREAD_SAFETY_VIOLATION, no_bucket, WARNING, [call to void ThreadSafeExample.visibleForTestingNotPublicOk(),access to `this.f`]
codetoanalyze/java/racerd/ThreadSafeExample.java, codetoanalyze.java.checkers.ThreadSafeExample.deeperTraceBad():void, 66, THREAD_SAFETY_VIOLATION, no_bucket, WARNING, [call to void ThreadSafeExample.callAssignInPrivateMethod(),call to void ThreadSafeExample.assignInPrivateMethodOk(),access to `this.f`]
codetoanalyze/java/racerd/ThreadSafeExample.java, codetoanalyze.java.checkers.ThreadSafeExample.oddBad():void, 47, THREAD_SAFETY_VIOLATION, no_bucket, WARNING, [call to void ThreadSafeExample.evenOk(),access to `this.f`]
codetoanalyze/java/racerd/ThreadSafeExample.java, codetoanalyze.java.checkers.ExtendsThreadSafeExample.newmethodBad():void, 132, THREAD_SAFETY_VIOLATION, no_bucket, WARNING, [access to `this.field`]
codetoanalyze/java/racerd/ThreadSafeExample.java, codetoanalyze.java.checkers.ExtendsThreadSafeExample.tsOK():void, 137, THREAD_SAFETY_VIOLATION, no_bucket, WARNING, [access to `this.field`]
codetoanalyze/java/racerd/ThreadSafeExample.java, codetoanalyze.java.checkers.ThreadSafeExample.FP_lazyInitOk():java.lang.Object, 121, THREAD_SAFETY_VIOLATION, no_bucket, WARNING, [<Read trace>,access to `this.sStaticField`,<Write trace>,access to `this.sStaticField`]
codetoanalyze/java/racerd/ThreadSafeExample.java, codetoanalyze.java.checkers.ThreadSafeExample.callPublicMethodBad():void, 48, THREAD_SAFETY_VIOLATION, no_bucket, WARNING, [call to void ThreadSafeExample.assignInPrivateMethodOk(),access to `this.f`]
codetoanalyze/java/racerd/ThreadSafeExample.java, codetoanalyze.java.checkers.ThreadSafeExample.callVisibleForTestingBad():void, 100, THREAD_SAFETY_VIOLATION, no_bucket, WARNING, [call to void ThreadSafeExample.visibleForTestingNotPublicOk(),access to `this.f`]
codetoanalyze/java/racerd/ThreadSafeExample.java, codetoanalyze.java.checkers.ThreadSafeExample.deeperTraceBad():void, 57, THREAD_SAFETY_VIOLATION, no_bucket, WARNING, [call to void ThreadSafeExample.callAssignInPrivateMethod(),call to void ThreadSafeExample.assignInPrivateMethodOk(),access to `this.f`]
codetoanalyze/java/racerd/ThreadSafeExample.java, codetoanalyze.java.checkers.ThreadSafeExample.recursiveBad():void, 37, THREAD_SAFETY_VIOLATION, no_bucket, WARNING, [access to `this.f`]
codetoanalyze/java/racerd/ThreadSafeExample.java, codetoanalyze.java.checkers.ThreadSafeExample.tsBad():void, 33, THREAD_SAFETY_VIOLATION, no_bucket, WARNING, [access to `this.f`]
codetoanalyze/java/racerd/ThreadSafeExample.java, codetoanalyze.java.checkers.YesThreadSafeExtendsNotThreadSafeExample.subsubmethodBad():void, 168, THREAD_SAFETY_VIOLATION, no_bucket, WARNING, [access to `this.subsubfield`]
codetoanalyze/java/racerd/ThreadSafeExample.java, codetoanalyze.java.checkers.YesThreadSafeExtendsNotThreadSafeExample.subsubmethodBad():void, 159, THREAD_SAFETY_VIOLATION, no_bucket, WARNING, [access to `this.subsubfield`]
codetoanalyze/java/racerd/ThreadSafeMethods.java, codetoanalyze.java.checkers.ThreadSafeMethods.readSameFieldAsThreadSafeMethod1Bad():java.lang.Object, 54, THREAD_SAFETY_VIOLATION, no_bucket, WARNING, [<Read trace>,access to `this.field1`,<Write trace>,access to `this.field1`]
codetoanalyze/java/racerd/ThreadSafeMethods.java, codetoanalyze.java.checkers.ThreadSafeMethods.readSameFieldAsThreadSafeMethod2Bad():java.lang.Object, 78, THREAD_SAFETY_VIOLATION, no_bucket, WARNING, [<Read trace>,access to `this.field4`,<Write trace>,access to `this.field4`]
codetoanalyze/java/racerd/ThreadSafeMethods.java, codetoanalyze.java.checkers.ThreadSafeMethods.readSameFieldAsThreadSafeMethodWhileSynchronized1Bad():java.lang.Object, 63, THREAD_SAFETY_VIOLATION, no_bucket, WARNING, [<Read trace>,access to `this.field1`,<Write trace>,access to `this.field1`]

Write Preview
Loading…
Cancel
Save