From 61bfd1e579c4964c961f6d4a4831b52e020eba7f Mon Sep 17 00:00:00 2001
From: Sam Blackshear <shb@fb.com>
Date: Thu, 5 Jan 2017 09:42:08 -0800
Subject: [PATCH] [cleanup] kill useless filter_buckets option

Summary: The logic for filtering reports based on their buckets lives in InferPrint, so this code isn't doing anything.

Reviewed By: jvillard

Differential Revision: D4379966

fbshipit-source-id: 5a69304
---
 infer/src/IR/Exceptions.ml | 11 +----------
 infer/src/base/Config.ml   |  4 ----
 infer/src/base/Config.mli  |  1 -
 3 files changed, 1 insertion(+), 15 deletions(-)

diff --git a/infer/src/IR/Exceptions.ml b/infer/src/IR/Exceptions.ml
index 03ef36c95..25424c142 100644
--- a/infer/src/IR/Exceptions.ml
+++ b/infer/src/IR/Exceptions.ml
@@ -97,11 +97,6 @@ exception Wrong_argument_number of L.ml_loc
 
 (** Turn an exception into a descriptive string, error description, location in ml source, and category *)
 let recognize_exception exn =
-  let filter_out_bucket desc =
-    Config.filter_buckets &&
-    match Localise.error_desc_get_bucket desc with
-    | None -> false
-    | Some bucket -> bucket <> Localise.BucketLevel.b1 in
   let err_name, desc, (ml_loc_opt : L.ml_loc option), visibility, severity, force_kind, eclass =
     match exn with (* all the names of Exn_user errors must be defined in Localise *)
     | Abduction_case_not_implemented ml_loc ->
@@ -308,11 +303,7 @@ let recognize_exception exn =
         let exn_name = Exn.to_string exn in
         (Localise.from_string exn_name,
          Localise.no_desc, None, Exn_developer, Low, None, Nocat) in
-  let visibility' =
-    if visibility = Exn_user && filter_out_bucket desc
-    then Exn_developer
-    else visibility in
-  (err_name, desc, ml_loc_opt, visibility', severity, force_kind, eclass)
+  (err_name, desc, ml_loc_opt, visibility, severity, force_kind, eclass)
 
 (** print a description of the exception to the html output *)
 let print_exception_html s exn =
diff --git a/infer/src/base/Config.ml b/infer/src/base/Config.ml
index 3d1262577..19d8a628c 100644
--- a/infer/src/base/Config.ml
+++ b/infer/src/base/Config.ml
@@ -104,10 +104,6 @@ let dotty_output = "icfg.dot"
 (** exit code to use for the --fail-on-issue option *)
 let fail_on_issue_exit_code = 2
 
-(** If true, filter out errors in low likelyhood buckets, and only show then in developer
-    mode *)
-let filter_buckets = false
-
 let frontend_stats_dir_name = "frontend_stats"
 
 let global_tenv_filename = "global.tenv"
diff --git a/infer/src/base/Config.mli b/infer/src/base/Config.mli
index 6be90d1da..a56ad3f9b 100644
--- a/infer/src/base/Config.mli
+++ b/infer/src/base/Config.mli
@@ -67,7 +67,6 @@ val default_in_zip_results_dir : string
 val dotty_output : string
 val etc_dir : string
 val fail_on_issue_exit_code : int
-val filter_buckets : bool
 val frontend_stats_dir_name : string
 val global_tenv_filename : string
 val idempotent_getters : bool