From 765d45c2fd4153f57a9c4c7fae11d144d129c630 Mon Sep 17 00:00:00 2001
From: Daiva Naudziuniene <daivan@fb.com>
Date: Mon, 10 May 2021 01:46:28 -0700
Subject: [PATCH] [pulse][objc] Enable nil issue types by default

Summary:
Facebook
Will censor issues in fbobjc

Reviewed By: jvillard

Differential Revision: D28287273

fbshipit-source-id: 7696b6540
---
 infer/man/man1/infer-full.txt   | 4 ++--
 infer/man/man1/infer-report.txt | 4 ++--
 infer/man/man1/infer.txt        | 4 ++--
 infer/src/base/IssueType.ml     | 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/infer/man/man1/infer-full.txt b/infer/man/man1/infer-full.txt
index c12e7e053..aae52535e 100644
--- a/infer/man/man1/infer-full.txt
+++ b/infer/man/man1/infer-full.txt
@@ -541,8 +541,8 @@ OPTIONS
              MULTIPLE_WEAKSELF (enabled by default),
              MUTABLE_LOCAL_VARIABLE_IN_COMPONENT_FILE (enabled by default),
              Missing_fld (enabled by default),
-             NIL_INSERTION_INTO_COLLECTION (disabled by default),
-             NIL_MESSAGING_TO_NON_POD (disabled by default),
+             NIL_INSERTION_INTO_COLLECTION (enabled by default),
+             NIL_MESSAGING_TO_NON_POD (enabled by default),
              NULLPTR_DEREFERENCE (enabled by default),
              NULL_DEREFERENCE (enabled by default),
              OPTIONAL_EMPTY_ACCESS (enabled by default),
diff --git a/infer/man/man1/infer-report.txt b/infer/man/man1/infer-report.txt
index 846832c9d..8c4afc4f3 100644
--- a/infer/man/man1/infer-report.txt
+++ b/infer/man/man1/infer-report.txt
@@ -218,8 +218,8 @@ OPTIONS
              MULTIPLE_WEAKSELF (enabled by default),
              MUTABLE_LOCAL_VARIABLE_IN_COMPONENT_FILE (enabled by default),
              Missing_fld (enabled by default),
-             NIL_INSERTION_INTO_COLLECTION (disabled by default),
-             NIL_MESSAGING_TO_NON_POD (disabled by default),
+             NIL_INSERTION_INTO_COLLECTION (enabled by default),
+             NIL_MESSAGING_TO_NON_POD (enabled by default),
              NULLPTR_DEREFERENCE (enabled by default),
              NULL_DEREFERENCE (enabled by default),
              OPTIONAL_EMPTY_ACCESS (enabled by default),
diff --git a/infer/man/man1/infer.txt b/infer/man/man1/infer.txt
index 2a8ba9d21..1fd5e343c 100644
--- a/infer/man/man1/infer.txt
+++ b/infer/man/man1/infer.txt
@@ -541,8 +541,8 @@ OPTIONS
              MULTIPLE_WEAKSELF (enabled by default),
              MUTABLE_LOCAL_VARIABLE_IN_COMPONENT_FILE (enabled by default),
              Missing_fld (enabled by default),
-             NIL_INSERTION_INTO_COLLECTION (disabled by default),
-             NIL_MESSAGING_TO_NON_POD (disabled by default),
+             NIL_INSERTION_INTO_COLLECTION (enabled by default),
+             NIL_MESSAGING_TO_NON_POD (enabled by default),
              NULLPTR_DEREFERENCE (enabled by default),
              NULL_DEREFERENCE (enabled by default),
              OPTIONAL_EMPTY_ACCESS (enabled by default),
diff --git a/infer/src/base/IssueType.ml b/infer/src/base/IssueType.ml
index 5fa1ff762..afdd85750 100644
--- a/infer/src/base/IssueType.ml
+++ b/infer/src/base/IssueType.ml
@@ -790,12 +790,12 @@ let mutable_local_variable_in_component_file =
 
 
 let nil_insertion_into_collection =
-  register ~enabled:false ~id:"NIL_INSERTION_INTO_COLLECTION" Error Pulse
+  register ~id:"NIL_INSERTION_INTO_COLLECTION" Error Pulse
     ~user_documentation:"Inserting nil into a collection is an error in Objective-C."
 
 
 let nil_messaging_to_non_pod =
-  register ~enabled:false ~id:"NIL_MESSAGING_TO_NON_POD" Error Pulse
+  register ~id:"NIL_MESSAGING_TO_NON_POD" Error Pulse
     ~user_documentation:
       "Calling a method that returns a C++ non-POD object on the nil object is undefined behavior \
        in Objective-C++."