From 7714f309d6328c4418b6d3ff19a79de5c935523d Mon Sep 17 00:00:00 2001 From: Jeremy Dubreil Date: Wed, 20 Feb 2019 08:25:08 -0800 Subject: [PATCH] [nullsafe] change the human readable warning name Reviewed By: ezgicicek, mbouaziz Differential Revision: D14144644 fbshipit-source-id: 6bdb0cdb1 --- infer/src/base/IssueType.ml | 10 +++++----- infer/src/base/IssueType.mli | 6 +++--- infer/src/nullsafe/NullabilityCheck.ml | 2 +- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/infer/src/base/IssueType.ml b/infer/src/base/IssueType.ml index fab76cd72..884d395b2 100644 --- a/infer/src/base/IssueType.ml +++ b/infer/src/base/IssueType.ml @@ -258,10 +258,6 @@ let exposed_insecure_intent_handling = from_string "EXPOSED_INSECURE_INTENT_HAND let failure_exe = from_string "Failure_exe" -let nullsafe_field_not_nullable = - from_string "NULLSAFE_FIELD_NOT_NULLABLE" ~hum:"Field Not Nullable" - - let field_not_null_checked = from_string "IVAR_NOT_NULL_CHECKED" (* from AL default linters *) @@ -329,7 +325,11 @@ let null_dereference = from_string "NULL_DEREFERENCE" let null_test_after_dereference = from_string ~enabled:false "NULL_TEST_AFTER_DEREFERENCE" -let nullable_dereference = from_string "NULLSAFE_NULLABLE_DEREFERENCE" +let nullsafe_field_not_nullable = + from_string "NULLSAFE_FIELD_NOT_NULLABLE" ~hum:"Field Not Nullable" + +let nullsafe_nullable_dereference = + from_string "NULLSAFE_NULLABLE_DEREFERENCE" ~hum:"Nullable Dereference" let parameter_not_null_checked = from_string "PARAMETER_NOT_NULL_CHECKED" diff --git a/infer/src/base/IssueType.mli b/infer/src/base/IssueType.mli index bd556a870..191026d19 100644 --- a/infer/src/base/IssueType.mli +++ b/infer/src/base/IssueType.mli @@ -171,8 +171,6 @@ val exposed_insecure_intent_handling : t val failure_exe : t -val nullsafe_field_not_nullable : t - val field_not_null_checked : t val graphql_field_access : t @@ -233,7 +231,9 @@ val null_dereference : t val null_test_after_dereference : t -val nullable_dereference : t +val nullsafe_field_not_nullable : t + +val nullsafe_nullable_dereference : t val parameter_not_null_checked : t diff --git a/infer/src/nullsafe/NullabilityCheck.ml b/infer/src/nullsafe/NullabilityCheck.ml index 7eb944ea8..cf824cc79 100644 --- a/infer/src/nullsafe/NullabilityCheck.ml +++ b/infer/src/nullsafe/NullabilityCheck.ml @@ -170,7 +170,7 @@ module TransferFunctions (CFG : ProcCfg.S) = struct in dereference_site :: with_assignment_site in - Reporting.log_error summary ~loc ~ltr:trace IssueType.nullable_dereference message + Reporting.log_error summary ~loc ~ltr:trace IssueType.nullsafe_nullable_dereference message let add_nullable_ap ap call_sites (aps, pnames) = (NullableAP.add ap call_sites aps, pnames)