From 807922ca7f999f9fb451ee126422b5aa0dad7aaa Mon Sep 17 00:00:00 2001
From: jrm <jrm@fb.com>
Date: Tue, 22 Dec 2015 22:43:07 -0800
Subject: [PATCH] simplify the PatternMatch module

Summary:
public
Some functions were never used, and some other were always used with the same parameters

Reviewed By: sblackshear

Differential Revision: D2786118

fb-gh-sync-id: 666fba2
---
 infer/src/checkers/patternMatch.ml  | 38 ++++-------------------------
 infer/src/checkers/patternMatch.mli |  6 -----
 2 files changed, 5 insertions(+), 39 deletions(-)

diff --git a/infer/src/checkers/patternMatch.ml b/infer/src/checkers/patternMatch.ml
index 8de8f3e4d..919d5fb33 100644
--- a/infer/src/checkers/patternMatch.ml
+++ b/infer/src/checkers/patternMatch.ml
@@ -62,11 +62,10 @@ let type_has_class_name t name =
 let type_has_direct_supertype (t : Sil.typ) (s : Mangled.t) =
   IList.exists (fun c -> c = s) (type_get_direct_supertypes t)
 
-let type_find_supertype
+let type_has_supertype
     (tenv: Sil.tenv)
     (typ: Sil.typ)
-    (csu_opt: Csu.t option)
-    (filter: Mangled.t -> bool): bool =
+    (name: Mangled.t): bool =
   let rec has_supertype typ visited =
     if Sil.TypSet.mem typ visited then
       false
@@ -76,40 +75,17 @@ let type_find_supertype
         | Sil.Tptr (Sil.Tstruct (_, _, _, _, supertypes, _, _), _)
         | Sil.Tstruct (_, _, _, _, supertypes, _, _) ->
             let match_supertype (csu, m) =
-              let match_name () = filter m in
-              let match_csu () = match csu_opt with
-                | Some c -> c = csu
-                | None -> true in
+              let match_name () = Mangled.equal m name in
               let has_indirect_supertype () =
                 match Sil.tenv_lookup tenv (Typename.TN_csu (Csu.Class, m)) with
                 | Some supertype -> has_supertype supertype (Sil.TypSet.add typ visited)
                 | None -> false in
-              (match_csu () && match_name ()
-              (* only and always visit name with expected csu *))
-              || has_indirect_supertype () in
+              (match_name () || has_indirect_supertype ()) in
             IList.exists match_supertype supertypes
         | _ -> false
       end in
   has_supertype typ Sil.TypSet.empty
 
-let type_has_supertype
-    (tenv: Sil.tenv)
-    (typ: Sil.typ)
-    (csu_opt: Csu.t option)
-    (name: Mangled.t): bool =
-  let filter m = Mangled.equal m name in
-  type_find_supertype tenv typ csu_opt filter
-
-let type_get_supertypes
-    (tenv: Sil.tenv)
-    (typ: Sil.typ)
-    (csu_opt: Csu.t option) : Mangled.t list =
-  let res = ref [] in
-  let filter m =
-    res := m :: !res;
-    false in
-  let _ = type_find_supertype tenv typ csu_opt filter in
-  IList.rev !res
 
 let type_is_nested_in_type t n = match t with
   | Sil.Tptr (Sil.Tstruct (_, _, _, Some m, _, _, _), _) ->
@@ -120,10 +96,6 @@ let type_is_nested_in_direct_supertype t n =
   let is_nested_in m2 m1 = string_is_prefix (Mangled.to_string m2 ^ "$") (Mangled.to_string m1) in
   IList.exists (is_nested_in n) (type_get_direct_supertypes t)
 
-let type_is_nested_in_supertype tenv t csu_option n =
-  let is_nested_in m2 m1 = string_is_prefix (Mangled.to_string m2 ^ "$") (Mangled.to_string m1) in
-  IList.exists (is_nested_in n) (type_get_supertypes tenv t csu_option)
-
 let rec get_type_name = function
   | Sil.Tstruct (_, _, _, Some mangled, _, _, _) -> Mangled.to_string mangled
   | Sil.Tptr (t, _) -> get_type_name t
@@ -270,7 +242,7 @@ let initializer_methods = [
 let type_has_initializer
     (tenv: Sil.tenv)
     (t: Sil.typ): bool =
-  let check_candidate cname = type_has_supertype tenv t (Some Csu.Class) cname in
+  let check_candidate cname = type_has_supertype tenv t cname in
   IList.exists check_candidate initializer_classes
 
 (** Check if the method is one of the known initializer methods. *)
diff --git a/infer/src/checkers/patternMatch.mli b/infer/src/checkers/patternMatch.mli
index 645b6b4ba..add85ed75 100644
--- a/infer/src/checkers/patternMatch.mli
+++ b/infer/src/checkers/patternMatch.mli
@@ -66,22 +66,16 @@ val type_get_class_name : Sil.typ -> Mangled.t option
 
 val type_get_direct_supertypes : Sil.typ -> Mangled.t list
 
-val type_get_supertypes : Sil.tenv -> Sil.typ -> Csu.t option -> Mangled.t list
-
 (** Is the type a class with the given name *)
 val type_has_class_name : Sil.typ -> Mangled.t -> bool
 
 val type_has_direct_supertype : Sil.typ -> Mangled.t -> bool
 
-val type_has_supertype : Sil.tenv -> Sil.typ -> Csu.t option -> Mangled.t -> bool
-
 (** Is the type a class type *)
 val type_is_class : Sil.typ -> bool
 
 val type_is_nested_in_direct_supertype : Sil.typ -> Mangled.t -> bool
 
-val type_is_nested_in_supertype : Sil.tenv -> Sil.typ -> Csu.t option -> Mangled.t -> bool
-
 val type_is_nested_in_type : Sil.typ -> Mangled.t -> bool
 
 (** Is the type java.lang.Object *)