From 80d294ff8db34df357b34b4b5584d899e2ffa473 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ezgi=20=C3=87i=C3=A7ek?= Date: Thu, 14 Nov 2019 08:56:57 -0800 Subject: [PATCH] [cost] Critical parts of the cost message should be to bold Summary: Let's make UI/Cold start parts of the message bold to get more attention. Reviewed By: jvillard Differential Revision: D18504857 fbshipit-source-id: b0f199f55 --- infer/src/backend/Differential.ml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/infer/src/backend/Differential.ml b/infer/src/backend/Differential.ml index eb314e387..a7efa9e09 100644 --- a/infer/src/backend/Differential.ml +++ b/infer/src/backend/Differential.ml @@ -250,9 +250,11 @@ let issue_of_cost kind CostIssues.{complexity_increase_issue; zero_issue; infini let cold_start_or_ui_msg = let common_msg = "It is very important to avoid potential regressions in this phase." in if is_on_ui_thread then - Format.asprintf "This function is called on the UI Thread! %s" common_msg + Format.asprintf "%a %s" MarkupFormatter.pp_bold + "This function is called on the UI Thread!" common_msg else if ExternalPerfData.in_profiler_data_map procname then - Format.asprintf "This function is called during cold start! %s" common_msg + Format.asprintf "%a %s" MarkupFormatter.pp_bold + "This function is called during cold start!" common_msg else "" in let msg =