[refactor] moving StringPPSet from ThreadSafety to Utils

Reviewed By: jberdine

Differential Revision: D3987229

fbshipit-source-id: 9854002

infer/src/base/PrettyPrintable.ml

@@ -7,8 +7,6 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
-open! Utils
-
 module F = Format
 
 (** Wrappers for making pretty-printable modules *)

infer/src/base/PrettyPrintable.mli

@@ -7,8 +7,6 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *)
 
-open! Utils
-
 module F = Format
 
 (** Wrappers for making pretty-printable modules *)

infer/src/base/Utils.ml

@@ -107,6 +107,12 @@ let string_set_of_list list =
 let string_list_intersection a b =
   StringSet.inter (string_set_of_list a) (string_set_of_list b)
 
+module StringPPSet = PrettyPrintable.MakePPSet(struct
+    type t = string
+    let compare = string_compare
+    let pp_element fmt s = F.fprintf fmt "%s" s
+  end)
+
 (** Maps from integers *)
 module IntMap = Map.Make (struct
     type t = int

infer/src/base/Utils.mli

@@ -89,6 +89,9 @@ module IntSet : Set.S with type elt = int
 (** Set of strings *)
 module StringSet : Set.S with type elt = string
 
+(** Pretty Printable Set of strings *)
+module StringPPSet : PrettyPrintable.PPSet with type elt = string
+
 (** Pretty print a set of strings *)
 val pp_stringset : Format.formatter -> StringSet.t -> unit
 

infer/src/checkers/ThreadSafety.ml

@@ -17,19 +17,13 @@ open! Utils
 module F = Format
 module L = Logging
 
-module PPString = PrettyPrintable.MakePPSet(struct
-    type t = string
-    let compare = string_compare
-    let pp_element fmt s = F.fprintf fmt "%s" s
-  end)
-
 module PPrawpath = PrettyPrintable.MakePPSet(struct
     type t = AccessPath.raw
     let compare = AccessPath.raw_compare
     let pp_element = AccessPath.pp_raw
   end)
 
-module LocksDomain =  AbstractDomain.FiniteSet(PPString)
+module LocksDomain =  AbstractDomain.FiniteSet(StringPPSet)
 
 module PathDomain =  AbstractDomain.FiniteSet(PPrawpath)