From 88699f2f86c0ba26b4a3243bda8596947e4d2007 Mon Sep 17 00:00:00 2001 From: Josh Berdine Date: Wed, 21 Apr 2021 15:34:48 -0700 Subject: [PATCH] [sledge] Fix command to enable using shared llvm library Summary: llvm-config can return the lib dir without manual manipulation using an assumed relative path from llvm-config to the lib dir. Also fix missing semicolon to appease shell variable semantics. Reviewed By: jvillard Differential Revision: D27828757 fbshipit-source-id: 5080c8671 --- sledge/Makefile | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/sledge/Makefile b/sledge/Makefile index 368270375..330fe29e2 100644 --- a/sledge/Makefile +++ b/sledge/Makefile @@ -30,9 +30,10 @@ LLVM_OCAML_SENTINEL=vendor/llvm-dune/src/llvm/common/dune # Note that this does not correctly detect llvm shared libraries on # macos since llvm-config is broken. A filthy workaround seems to be # to create the libLLVM-11.dylib file llvm-config looks for as a -# symbolic link to libLLVM.dylib: -# LLVMROOT=$(dirname $(dirname $(opam config var conf-llvm:config))) \ -# ln -s $LLVMROOT/lib/libLLVM.dylib $LLVMROOT/lib/libLLVM-11.dylib +# symbolic link to libLLVM.dylib. That is, to manually in the shell +# execute: +# (LLVMLIB=$($(opam config var conf-llvm:config) --libdir); +# ln -s $LLVMLIB/libLLVM.dylib $LLVMLIB/libLLVM-11.dylib) $(LLVM_OCAML_SENTINEL): $(LLVM_OCAML_SRC) cd vendor/llvm-dune; ./setup.sh $$(opam config var conf-llvm:config) &>/dev/null