From 89de9504bbf07f248ca166c05f7fdd92312f192f Mon Sep 17 00:00:00 2001 From: Jia Chen Date: Thu, 6 Jul 2017 09:34:52 -0700 Subject: [PATCH] Fixed a (supposed) typo in objc test Reviewed By: jeremydubreil Differential Revision: D5373584 fbshipit-source-id: f4a7f6c --- infer/tests/codetoanalyze/objc/errors/issues.exp | 1 + .../errors/memory_leaks_benchmark/CADisplayLinkRetainCycle.m | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/infer/tests/codetoanalyze/objc/errors/issues.exp b/infer/tests/codetoanalyze/objc/errors/issues.exp index 8be89bf3b..3f22a78eb 100644 --- a/infer/tests/codetoanalyze/objc/errors/issues.exp +++ b/infer/tests/codetoanalyze/objc/errors/issues.exp @@ -3,6 +3,7 @@ codetoanalyze/objc/errors/global_const/global_const.m, SimpleRoot_doSomethingBad codetoanalyze/objc/errors/global_const/global_const.m, SimpleRoot_doSomethingOkWithDict:andString:, 3, NULL_DEREFERENCE, [start of procedure doSomethingOkWithDict:andString:,Message stringByAppendingString: with receiver nil returns nil.] codetoanalyze/objc/errors/initialization/compound_literal.c, init_with_compound_literal, 2, DIVIDE_BY_ZERO, [start of procedure init_with_compound_literal()] codetoanalyze/objc/errors/memory_leaks_benchmark/CADisplayLinkRetainCycle.m, testCycle, 3, RETAIN_CYCLE, [start of procedure testCycle(),start of procedure init,return from a call to CADisplay_init] +codetoanalyze/objc/errors/memory_leaks_benchmark/CADisplayLinkRetainCycle.m, testNoCycle_FP, 4, MEMORY_LEAK, [start of procedure testNoCycle_FP(),start of procedure init,return from a call to CADisplay_init,start of procedure invalidate,return from a call to CADisplay_invalidate,start of procedure dealloc,Skipped call: function or method not found,return from a call to CADisplay_dealloc] codetoanalyze/objc/errors/memory_leaks_benchmark/RetainCycleStaticVar.m, RetainCSVycleStaticVar, 2, RETAIN_CYCLE, [start of procedure RetainCSVycleStaticVar(),start of procedure init,return from a call to RetainCSV_init,start of procedure foo,start of procedure block,start of procedure init,return from a call to RetainCSV_init,return from a call to __objc_anonymous_block_RetainCSV_foo______3,start of procedure block,start of procedure init,return from a call to RetainCSV_init,return from a call to __objc_anonymous_block_RetainCSV_foo______2,return from a call to RetainCSV_foo] codetoanalyze/objc/errors/npe/blockenum.m, BlockEnumA_allResultsList:, 1, MEMORY_LEAK, [start of procedure allResultsList:,Skipped call: function or method not found] codetoanalyze/objc/errors/npe/blockenum.m, BlockEnumA_allResultsList:, 2, RETURN_VALUE_IGNORED, [start of procedure allResultsList:,Skipped call: function or method not found,Condition is true] diff --git a/infer/tests/codetoanalyze/objc/errors/memory_leaks_benchmark/CADisplayLinkRetainCycle.m b/infer/tests/codetoanalyze/objc/errors/memory_leaks_benchmark/CADisplayLinkRetainCycle.m index 381696f51..90e3daf8c 100644 --- a/infer/tests/codetoanalyze/objc/errors/memory_leaks_benchmark/CADisplayLinkRetainCycle.m +++ b/infer/tests/codetoanalyze/objc/errors/memory_leaks_benchmark/CADisplayLinkRetainCycle.m @@ -34,7 +34,7 @@ }; - (void)dealloc { - [self dealloc]; + [super dealloc]; } @end @@ -45,7 +45,7 @@ void testCycle() { CADisplay* b = a; } -void testNoCycle() { +void testNoCycle_FP() { CADisplay* a = [[CADisplay alloc] init]; [a invalidate]; // break the cycle