From 8f50c9dd3b1d70df834c90fcbf50329407f33af5 Mon Sep 17 00:00:00 2001 From: Jules Villard Date: Thu, 8 Jun 2017 07:15:26 -0700 Subject: [PATCH] [buck] do not pass unused --buck to python Summary: It is not used, so one fewer thing to track inside Python. Note that Python does pass `--buck` to OCaml infer to make it aware that it is running from within Buck, and the OCaml code uses that flag to trim infer-out to only what's strictly necessary (and especially to remove non-deterministic output that would mess with Buck's cache). Reviewed By: jberdine Differential Revision: D5200043 fbshipit-source-id: 1c84442 --- infer/lib/python/inferlib/analyze.py | 3 --- infer/src/backend/infer.ml | 2 -- 2 files changed, 5 deletions(-) diff --git a/infer/lib/python/inferlib/analyze.py b/infer/lib/python/inferlib/analyze.py index 1856bc5c2..1a0486e7e 100644 --- a/infer/lib/python/inferlib/analyze.py +++ b/infer/lib/python/inferlib/analyze.py @@ -71,8 +71,5 @@ infer_group.add_argument('-l', '--load-average', metavar='', type=float, 'be started if there are others jobs running and the ' 'load average is at least .') -infer_group.add_argument('--buck', action='store_true', dest='buck', - help='To use when run with buck') - infer_group.add_argument('--java-jar-compiler', metavar='') diff --git a/infer/src/backend/infer.ml b/infer/src/backend/infer.ml index 4bf5209b2..7a9ba0c81 100644 --- a/infer/src/backend/infer.ml +++ b/infer/src/backend/infer.ml @@ -270,8 +270,6 @@ let capture = function | _ -> []) @ (if not Config.create_harness then [] else ["--android-harness"]) @ - (if not Config.buck then [] else - ["--buck"]) @ (match Config.java_jar_compiler with None -> [] | Some p -> ["--java-jar-compiler"; p]) @ (match List.rev Config.buck_build_args with