From 903106b298863ebd583bf75da3ba918f10c4ab91 Mon Sep 17 00:00:00 2001
From: Sungkeun Cho <scho@fb.com>
Date: Tue, 18 May 2021 05:42:24 -0700
Subject: [PATCH] [ConfigImpact] Fix inefficient config impact data checking

Summary:
This diff fixes inefficient config impact data checking.

Problem: When writing `config-impact-report.json`, it checks if a procedure (`f`) is included in the config impact data set as follows. `cut_parameter` is a function that removes parameters from ObjC method names.

```
ConfigProcnameSet.exists (fun g -> cut_parameter f = cut_parameter g) config_data
```

However, this was very inefficient because it must have iterated all members in the set always. This diff changes it to call `Set.mem` by preparing revised config impact data set (`config_data'`) in which parameters were cut in advance:

```
ConfigProcnameSet.mem (cut_parameter f) config_data'
```

Reviewed By: ezgicicek

Differential Revision: D28506113

fbshipit-source-id: 434d1f083
---
 .../src/checkers/ExternalConfigImpactData.ml  | 23 ++++++++-----------
 1 file changed, 10 insertions(+), 13 deletions(-)

diff --git a/infer/src/checkers/ExternalConfigImpactData.ml b/infer/src/checkers/ExternalConfigImpactData.ml
index e45f5a44c..3cbabbcaf 100644
--- a/infer/src/checkers/ExternalConfigImpactData.ml
+++ b/infer/src/checkers/ExternalConfigImpactData.ml
@@ -15,6 +15,8 @@ module ConfigProcnameSet = Caml.Set.Make (struct
   [@@deriving compare]
 end)
 
+let cut_objc_parameters name = List.hd_exn (String.split name ~on:':')
+
 let read_file_config_data fname =
   let config_list =
     try Atdgen_runtime.Util.Json.from_file Config_impact_data_j.read_config_data fname
@@ -22,13 +24,9 @@ let read_file_config_data fname =
       L.user_warning "Failed to read file '%s': %s@." fname (Exn.to_string e) ;
       []
   in
-  List.fold config_list ~init:ConfigProcnameSet.empty ~f:(fun acc itm ->
-      ConfigProcnameSet.add itm acc )
-
-
-let is_similar_method_name =
-  let cut_objc_parameters name = List.hd_exn (String.split name ~on:':') in
-  fun name1 name2 -> String.equal (cut_objc_parameters name1) (cut_objc_parameters name2)
+  List.fold config_list ~init:ConfigProcnameSet.empty
+    ~f:(fun acc {Config_impact_data_t.method_name; class_name} ->
+      ConfigProcnameSet.add {method_name= cut_objc_parameters method_name; class_name} acc )
 
 
 let is_in_config_data_file =
@@ -37,9 +35,8 @@ let is_in_config_data_file =
       ~f:read_file_config_data
   in
   fun proc_name ->
-    ConfigProcnameSet.exists
-      (fun {method_name; class_name} ->
-        is_similar_method_name method_name (Procname.get_method proc_name)
-        && String.equal class_name (Procname.get_class_name proc_name |> Option.value ~default:"")
-        )
-      config_data
+    let config_item =
+      { Config_impact_data_t.method_name= Procname.get_method proc_name |> cut_objc_parameters
+      ; class_name= Procname.get_class_name proc_name |> Option.value ~default:"" }
+    in
+    ConfigProcnameSet.mem config_item config_data