From 911a2e1906c7a22919591e3a7418fe0704df00f9 Mon Sep 17 00:00:00 2001
From: Mehdi Bouaziz <mbouaziz@fb.com>
Date: Thu, 6 Sep 2018 05:22:42 -0700
Subject: [PATCH] Reporting cleanup 16: UnknownNode -> no node key

Summary: No dummy node key, as a consequence the option `--skip-duplicated-types` will have no effect on issues with no node key, i.e. issues reported by non-biabduction non-eradicate checkers.

Reviewed By: martinoluca

Differential Revision: D9633564

fbshipit-source-id: 9ff8abf21
---
 infer/src/IR/Errlog.ml    | 2 +-
 infer/src/IR/Procdesc.ml  | 2 --
 infer/src/IR/Procdesc.mli | 2 --
 3 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/infer/src/IR/Errlog.ml b/infer/src/IR/Errlog.ml
index e7aa328ac..db26f95ef 100644
--- a/infer/src/IR/Errlog.ml
+++ b/infer/src/IR/Errlog.ml
@@ -266,7 +266,7 @@ let log_issue procname ~clang_method_kind severity err_log ~loc ~node ~session ~
       let node_id, node_key =
         match node with
         | UnknownNode ->
-            (0, Some Procdesc.NodeKey.dummy)
+            (0, None)
         | FrontendNode {node_key} ->
             (0, Some node_key)
         | BackendNode {node} ->
diff --git a/infer/src/IR/Procdesc.ml b/infer/src/IR/Procdesc.ml
index f542cd95a..fec8314af 100644
--- a/infer/src/IR/Procdesc.ml
+++ b/infer/src/IR/Procdesc.ml
@@ -24,8 +24,6 @@ module NodeKey = struct
 
 
   let of_frontend_node_key = Utils.better_hash
-
-  let dummy = Utils.better_hash "DUMMY"
 end
 
 (* =============== START of module Node =============== *)
diff --git a/infer/src/IR/Procdesc.mli b/infer/src/IR/Procdesc.mli
index 4beb51a8e..b234a961b 100644
--- a/infer/src/IR/Procdesc.mli
+++ b/infer/src/IR/Procdesc.mli
@@ -11,8 +11,6 @@ open! IStd
 module NodeKey : sig
   type t
 
-  val dummy : t
-
   val to_string : t -> string
 
   val of_frontend_node_key : string -> t