From 92e3d56f2e70b8b329a72dbb475229528024bb5c Mon Sep 17 00:00:00 2001 From: Jules Villard Date: Tue, 16 Jan 2018 05:46:59 -0800 Subject: [PATCH] [cleanup] add missing `open! IStd` Summary: Almost all the files are supposed to do this. When they don't, the build adds it automatically anyway, but it's better to always include it to avoid confusion (and help other automated tools). Reviewed By: mbouaziz Differential Revision: D6723285 fbshipit-source-id: 0fe8a16 --- infer/src/backend/RetainCycles.ml | 1 + infer/src/backend/RetainCycles.mli | 2 ++ infer/src/backend/RetainCyclesType.ml | 2 ++ infer/src/backend/RetainCyclesType.mli | 2 ++ infer/src/backend/SymExecBlocks.ml | 3 +++ infer/src/base/ProcessPoolState.ml | 3 +++ infer/src/checkers/Litho.ml | 1 + infer/src/checkers/LithoDomain.ml | 1 + infer/src/checkers/NullabilityCheck.ml | 1 + infer/src/checkers/NullabilityCheck.mli | 2 ++ infer/src/clang/CTLExceptions.ml | 2 ++ infer/src/clang_stubs/CTLParserHelper.ml | 2 ++ infer/src/opensource/JsonBuilder.ml | 2 ++ 13 files changed, 24 insertions(+) diff --git a/infer/src/backend/RetainCycles.ml b/infer/src/backend/RetainCycles.ml index f8d9f1b2d..d958d2c8b 100644 --- a/infer/src/backend/RetainCycles.ml +++ b/infer/src/backend/RetainCycles.ml @@ -6,6 +6,7 @@ * LICENSE file in the root directory of this source tree. An additional grant * of patent rights can be found in the PATENTS file in the same directory. *) +open! IStd module L = Logging module F = Format module MF = MarkupFormatter diff --git a/infer/src/backend/RetainCycles.mli b/infer/src/backend/RetainCycles.mli index 172069858..ac06cdac5 100644 --- a/infer/src/backend/RetainCycles.mli +++ b/infer/src/backend/RetainCycles.mli @@ -7,4 +7,6 @@ * of patent rights can be found in the PATENTS file in the same directory. *) +open! IStd + val report_cycle : Tenv.t -> Sil.hpred -> Prop.normal Prop.t option option -> exn option diff --git a/infer/src/backend/RetainCyclesType.ml b/infer/src/backend/RetainCyclesType.ml index b43ef0b18..28d871cce 100644 --- a/infer/src/backend/RetainCyclesType.ml +++ b/infer/src/backend/RetainCyclesType.ml @@ -6,6 +6,8 @@ * LICENSE file in the root directory of this source tree. An additional grant * of patent rights can be found in the PATENTS file in the same directory. *) +open! IStd + type retain_cycle_node = {rc_node_exp: Exp.t; rc_node_typ: Typ.t} type retain_cycle_field_objc = {rc_field_name: Typ.Fieldname.t; rc_field_inst: Sil.inst} diff --git a/infer/src/backend/RetainCyclesType.mli b/infer/src/backend/RetainCyclesType.mli index 09a6a7320..7781a0ed0 100644 --- a/infer/src/backend/RetainCyclesType.mli +++ b/infer/src/backend/RetainCyclesType.mli @@ -7,6 +7,8 @@ * of patent rights can be found in the PATENTS file in the same directory. *) +open! IStd + type retain_cycle_node = {rc_node_exp: Exp.t; rc_node_typ: Typ.t} type retain_cycle_field_objc = {rc_field_name: Typ.Fieldname.t; rc_field_inst: Sil.inst} diff --git a/infer/src/backend/SymExecBlocks.ml b/infer/src/backend/SymExecBlocks.ml index a194541e8..52b025d01 100644 --- a/infer/src/backend/SymExecBlocks.ml +++ b/infer/src/backend/SymExecBlocks.ml @@ -6,6 +6,9 @@ * LICENSE file in the root directory of this source tree. An additional grant * of patent rights can be found in the PATENTS file in the same directory. *) + +open! IStd + (* Given two lists of tuples (exp1, var1, typ1) and (exp2, var2, typ2) append the lists avoiding duplicates, where if the variables exist we check their equality, otherwise we check the equality of the expressions. This is to avoid diff --git a/infer/src/base/ProcessPoolState.ml b/infer/src/base/ProcessPoolState.ml index e64cc4755..c3214e36b 100644 --- a/infer/src/base/ProcessPoolState.ml +++ b/infer/src/base/ProcessPoolState.ml @@ -6,5 +6,8 @@ * LICENSE file in the root directory of this source tree. An additional grant * of patent rights can be found in the PATENTS file in the same directory. *) + +open! IStd + (** Keep track of whether the current execution is in a child process *) let in_child = ref false diff --git a/infer/src/checkers/Litho.ml b/infer/src/checkers/Litho.ml index 248f407db..612ab649f 100644 --- a/infer/src/checkers/Litho.ml +++ b/infer/src/checkers/Litho.ml @@ -7,6 +7,7 @@ * of patent rights can be found in the PATENTS file in the same directory. *) +open! IStd module F = Format module L = Logging module Domain = LithoDomain diff --git a/infer/src/checkers/LithoDomain.ml b/infer/src/checkers/LithoDomain.ml index 12a7e770a..9b03e92b4 100644 --- a/infer/src/checkers/LithoDomain.ml +++ b/infer/src/checkers/LithoDomain.ml @@ -7,6 +7,7 @@ * of patent rights can be found in the PATENTS file in the same directory. *) +open! IStd module F = Format module L = Logging diff --git a/infer/src/checkers/NullabilityCheck.ml b/infer/src/checkers/NullabilityCheck.ml index 501615328..c0f0ea2aa 100644 --- a/infer/src/checkers/NullabilityCheck.ml +++ b/infer/src/checkers/NullabilityCheck.ml @@ -7,6 +7,7 @@ * of patent rights can be found in the PATENTS file in the same directory. *) +open! IStd module F = Format module L = Logging module MF = MarkupFormatter diff --git a/infer/src/checkers/NullabilityCheck.mli b/infer/src/checkers/NullabilityCheck.mli index d6c90bc25..5b1dbca2a 100644 --- a/infer/src/checkers/NullabilityCheck.mli +++ b/infer/src/checkers/NullabilityCheck.mli @@ -7,4 +7,6 @@ * of patent rights can be found in the PATENTS file in the same directory. *) +open! IStd + val checker : Callbacks.proc_callback_t diff --git a/infer/src/clang/CTLExceptions.ml b/infer/src/clang/CTLExceptions.ml index 80e642f4d..0e03ad8eb 100644 --- a/infer/src/clang/CTLExceptions.ml +++ b/infer/src/clang/CTLExceptions.ml @@ -7,6 +7,8 @@ * of patent rights can be found in the PATENTS file in the same directory. *) +open! IStd + exception ALParserInvariantViolationException of string type exc_info = {description: string; filename: string; line: int} diff --git a/infer/src/clang_stubs/CTLParserHelper.ml b/infer/src/clang_stubs/CTLParserHelper.ml index 0c031c60e..975702341 100644 --- a/infer/src/clang_stubs/CTLParserHelper.ml +++ b/infer/src/clang_stubs/CTLParserHelper.ml @@ -7,6 +7,8 @@ * of patent rights can be found in the PATENTS file in the same directory. *) +open! IStd + let validate_al_files () = prerr_endline "ERROR: infer was built without clang support." ; Die.exit 1 diff --git a/infer/src/opensource/JsonBuilder.ml b/infer/src/opensource/JsonBuilder.ml index ef8142a82..990055bc7 100644 --- a/infer/src/opensource/JsonBuilder.ml +++ b/infer/src/opensource/JsonBuilder.ml @@ -7,6 +7,8 @@ * of patent rights can be found in the PATENTS file in the same directory. *) +open! IStd + type t = (string * Yojson.Basic.json) list let empty = []