[infer][checkers] Using the same filtering mechanisim for the biabduction analysis for the main Infer analysis and when using the checkers framework

Summary:
Now,
  infer -a infer -- ...
and
  infer -a checkers --biabduction -- ...
will return the same list of errors

Reviewed By: sblackshear

Differential Revision: D5023223

fbshipit-source-id: f52ce5d

infer/src/backend/InferPrint.re

@@ -269,10 +269,10 @@ let should_report (issue_kind: Exceptions.err_kind) issue_type error_desc eclass
   } else {
     let analyzer_is_whitelisted =
       switch Config.analyzer {
-      | Checkers
       | Eradicate
       | Tracing => true
       | Capture
+      | Checkers
       | Compile
       | Crashcontext
       | Infer

infer/src/checkers/registerCheckers.ml

@@ -17,7 +17,7 @@ module F = Format
 let enabled_by_default =
   (* True when no checker is explicitely enabled from the command line *)
   let open Config in
-  not (bufferoverrun || checkers_repeated_calls || crashcontext
+  not (biabduction || bufferoverrun || checkers_repeated_calls || crashcontext
        || eradicate || quandary || siof || threadsafety)
 
 (** Flags to activate checkers. *)

infer/tests/codetoanalyze/c/biabduction/example.c

@@ -6,7 +6,13 @@
  * LICENSE file in the root directory of this source tree. An additional grant
  * of patent rights can be found in the PATENTS file in the same directory.
  */
+
 void foo() {
   int* p = 0;
   *p = 42;
 }
+
+int bar() {
+  /* The division by zero should be found but filtered out by default */
+  return 1 / 0;
+}