From a40cd07c7d16f5a232bae3641770f199e6f46761 Mon Sep 17 00:00:00 2001 From: Josh Berdine Date: Thu, 12 Nov 2020 16:36:58 -0800 Subject: [PATCH] [sledge] Classify issues translating type sizes as `todo` instead of `fail` Summary: If these failures are observed in real code of interest, they will need to be resolved, so they are `todo` rather than an internal `fail`ure. Reviewed By: jvillard Differential Revision: D24746222 fbshipit-source-id: 6b924be58 --- sledge/cli/frontend.ml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sledge/cli/frontend.ml b/sledge/cli/frontend.ml index 3b8228c69..2beeb3dea 100644 --- a/sledge/cli/frontend.ml +++ b/sledge/cli/frontend.ml @@ -224,8 +224,8 @@ let size_of, bit_size_of = if Llvm.type_is_sized llt then match Int64.unsigned_to_int (size_of llt x.lldatalayout) with | Some n -> n - | None -> fail "type size too large: %a" pp_lltype llt () - else fail "types with undetermined size: %a" pp_lltype llt () + | None -> todo "type size too large: %a" pp_lltype llt () + else todo "types with undetermined size: %a" pp_lltype llt () in ( size_to_int Llvm_target.DataLayout.abi_size , size_to_int Llvm_target.DataLayout.size_in_bits )