From a5f9bcbbde317dae69bc2966e2e3c534195560a0 Mon Sep 17 00:00:00 2001 From: Nikos Gorogiannis Date: Wed, 6 Jun 2018 09:22:56 -0700 Subject: [PATCH] [reporting] fix position of optional arg Summary: Optional args shouldn't be at the end of the arg list. Reviewed By: dulmarod Differential Revision: D8298979 fbshipit-source-id: 17680f6 --- infer/src/backend/reporting.ml | 2 +- infer/src/backend/reporting.mli | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/infer/src/backend/reporting.ml b/infer/src/backend/reporting.ml index d69f0dd35..54eca440a 100644 --- a/infer/src/backend/reporting.ml +++ b/infer/src/backend/reporting.ml @@ -100,7 +100,7 @@ let log_issue_external procname ?clang_method_kind err_kind ?loc ?node_id ?sessi ?linters_def_file ?doc_url ?access exn -let is_suppressed tenv proc_desc kind ?(field_name= None) = +let is_suppressed ?(field_name= None) tenv proc_desc kind = let lookup = Tenv.lookup tenv in let proc_attributes = Summary.pdesc_resolve_attributes proc_desc in (* Errors can be suppressed with annotations. An error of kind CHECKER_ERROR_NAME can be diff --git a/infer/src/backend/reporting.mli b/infer/src/backend/reporting.mli index 563b27eab..7702f2c2a 100644 --- a/infer/src/backend/reporting.mli +++ b/infer/src/backend/reporting.mli @@ -47,5 +47,5 @@ val log_issue_external : (** Log an issue to the error log in [IssueLog] associated with the given procname. *) val is_suppressed : - Tenv.t -> Procdesc.t -> IssueType.t -> ?field_name:Typ.Fieldname.t option -> bool + ?field_name:Typ.Fieldname.t option -> Tenv.t -> Procdesc.t -> IssueType.t -> bool (** should an issue report be suppressed due to a [@SuppressLint("issue")] annotation? *)