diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index fe7163962..6e91af1af 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -18,3 +18,7 @@ us a line at cla@fb.com. Thanks! `infer/tests/codetoanalyze/` and `infer/tests/{endtoend,frontend}/`. To run the all tests, execute `./scripts/test.sh`. + +## Hacking + +* Be aware that the build system implicitly opens the Utils module. diff --git a/infer/src/Makefile.in b/infer/src/Makefile.in index 371f4ea0e..f5e439ce7 100644 --- a/infer/src/Makefile.in +++ b/infer/src/Makefile.in @@ -97,6 +97,7 @@ OCAMLBUILD_OPTIONS = \ -cflags -w,@38 \ -cflags -w,@39 \ -tag-line "<*clang/clang_ast_*>: warn(-35-39)" \ + -tag-line "not <**/{config,iList,utils}.*>: open(Utils)" \ -lflags $(OCAML_INCLUDES) \ -cflags $(OCAML_INCLUDES) \ $(addprefix -lib ,$(OCAML_LIBS)) \ diff --git a/infer/src/backend/DB.ml b/infer/src/backend/DB.ml index 2d9e25d9a..21f11f3ff 100644 --- a/infer/src/backend/DB.ml +++ b/infer/src/backend/DB.ml @@ -10,7 +10,6 @@ (** Database of analysis results *) -open Utils module F = Format module L = Logging diff --git a/infer/src/backend/abs.ml b/infer/src/backend/abs.ml index 658b918e3..eb333150c 100644 --- a/infer/src/backend/abs.ml +++ b/infer/src/backend/abs.ml @@ -12,7 +12,6 @@ module L = Logging module F = Format -open Utils (** {2 Abstraction} *) diff --git a/infer/src/backend/absarray.ml b/infer/src/backend/absarray.ml index 090c808df..2e36de2c0 100644 --- a/infer/src/backend/absarray.ml +++ b/infer/src/backend/absarray.ml @@ -12,7 +12,6 @@ module L = Logging module F = Format -open Utils type sigma = Sil.hpred list diff --git a/infer/src/backend/attributesTable.ml b/infer/src/backend/attributesTable.ml index caea23f09..408b409a0 100644 --- a/infer/src/backend/attributesTable.ml +++ b/infer/src/backend/attributesTable.ml @@ -7,7 +7,6 @@ * of patent rights can be found in the PATENTS file in the same directory. *) -open Utils module F = Format module L = Logging diff --git a/infer/src/backend/autounit.ml b/infer/src/backend/autounit.ml index fcc8ac7e9..e8c81afec 100644 --- a/infer/src/backend/autounit.ml +++ b/infer/src/backend/autounit.ml @@ -10,7 +10,6 @@ (** Generate unit tests automatically from specs *) -open Utils module L = Logging module F = Format diff --git a/infer/src/backend/buckets.ml b/infer/src/backend/buckets.ml index d572b6a0d..69d6e16f5 100644 --- a/infer/src/backend/buckets.ml +++ b/infer/src/backend/buckets.ml @@ -12,7 +12,6 @@ module L = Logging module F = Format -open Utils let verbose = Config.trace_error diff --git a/infer/src/backend/buckets.mli b/infer/src/backend/buckets.mli index cda0559c5..bb43a05b4 100644 --- a/infer/src/backend/buckets.mli +++ b/infer/src/backend/buckets.mli @@ -10,8 +10,6 @@ (** Classify bugs into buckets *) -open Utils - (** Classify the bucket of an error desc using Location.access and nullable information *) val classify_access : Localise.error_desc -> Localise.access option -> Sil.dexp option -> bool -> Localise.error_desc diff --git a/infer/src/backend/callbacks.ml b/infer/src/backend/callbacks.ml index 719060de9..50f56e3a4 100644 --- a/infer/src/backend/callbacks.ml +++ b/infer/src/backend/callbacks.ml @@ -7,7 +7,6 @@ * of patent rights can be found in the PATENTS file in the same directory. *) -open Utils module L = Logging (** Module to register and invoke callbacks *) diff --git a/infer/src/backend/cfg.ml b/infer/src/backend/cfg.ml index 16f803a22..06096443b 100644 --- a/infer/src/backend/cfg.ml +++ b/infer/src/backend/cfg.ml @@ -11,8 +11,6 @@ module L = Logging module F = Format -open Utils (* No abbreviation for Utils, as every module can depend on it *) - (* ============== START of ADT node and proc_desc ============== *) (* =============== START of module Node =============== *) diff --git a/infer/src/backend/cfg.mli b/infer/src/backend/cfg.mli index 31e63a624..24d7437d5 100644 --- a/infer/src/backend/cfg.mli +++ b/infer/src/backend/cfg.mli @@ -10,8 +10,6 @@ (** Control Flow Graph for Interprocedural Analysis *) -open Utils - (** {2 ADT node and proc_desc} *) type node diff --git a/infer/src/backend/cg.ml b/infer/src/backend/cg.ml index 6991f1d4a..a33dd374f 100644 --- a/infer/src/backend/cg.ml +++ b/infer/src/backend/cg.ml @@ -12,7 +12,6 @@ module L = Logging module F = Format -open Utils let pp_nodeset fmt set = let f node = F.fprintf fmt "%a@ " Procname.pp node in diff --git a/infer/src/backend/cg.mli b/infer/src/backend/cg.mli index b99e1baa3..32a673fee 100644 --- a/infer/src/backend/cg.mli +++ b/infer/src/backend/cg.mli @@ -10,8 +10,6 @@ (** Module for call graphs *) -open Utils - type in_out_calls = { in_calls: int; (** total number of in calls transitively *) out_calls: int (** total number of out calls transitively *) diff --git a/infer/src/backend/cluster.ml b/infer/src/backend/cluster.ml index 74e645e73..51eae737f 100644 --- a/infer/src/backend/cluster.ml +++ b/infer/src/backend/cluster.ml @@ -9,7 +9,6 @@ module L = Logging module F = Format -open Utils (** Module to process clusters of procedures. *) diff --git a/infer/src/backend/clusterMakefile.ml b/infer/src/backend/clusterMakefile.ml index 0f6e12bcf..3fd52aeb1 100644 --- a/infer/src/backend/clusterMakefile.ml +++ b/infer/src/backend/clusterMakefile.ml @@ -9,7 +9,6 @@ module L = Logging module F = Format -open Utils (** Module to create a makefile with dependencies between clusters *) diff --git a/infer/src/backend/csu.ml b/infer/src/backend/csu.ml index 03520e0e5..2bb83efe0 100644 --- a/infer/src/backend/csu.ml +++ b/infer/src/backend/csu.ml @@ -7,8 +7,6 @@ * of patent rights can be found in the PATENTS file in the same directory. *) -open Utils - (** Internal representation of data structure for Java, Objective-C and C++ classes, C-style structs struct and union, And Objective C protocol *) diff --git a/infer/src/backend/dom.ml b/infer/src/backend/dom.ml index fdef79472..c7d64fe6f 100644 --- a/infer/src/backend/dom.ml +++ b/infer/src/backend/dom.ml @@ -12,7 +12,6 @@ module L = Logging module F = Format -open Utils let (++) = Sil.Int.add let (--) = Sil.Int.sub diff --git a/infer/src/backend/dom.mli b/infer/src/backend/dom.mli index fba9263f4..06ab2322e 100644 --- a/infer/src/backend/dom.mli +++ b/infer/src/backend/dom.mli @@ -10,8 +10,6 @@ (** Join and Meet Operators *) -open Utils - (** {2 Join Operators} *) (** Join two pathsets *) diff --git a/infer/src/backend/dotty.ml b/infer/src/backend/dotty.ml index 4745a54f3..8fb63813a 100644 --- a/infer/src/backend/dotty.ml +++ b/infer/src/backend/dotty.ml @@ -10,7 +10,6 @@ module L = Logging module F = Format -open Utils (** {1 Dotty} *) diff --git a/infer/src/backend/errdesc.ml b/infer/src/backend/errdesc.ml index 1592aebab..8551e9abb 100644 --- a/infer/src/backend/errdesc.ml +++ b/infer/src/backend/errdesc.ml @@ -12,7 +12,6 @@ module L = Logging module F = Format -open Utils (** Check whether the hpred is a |-> representing a resource in the Racquire state *) let hpred_is_open_resource prop = function diff --git a/infer/src/backend/errdesc.mli b/infer/src/backend/errdesc.mli index d88d595d7..8f7d5ab0d 100644 --- a/infer/src/backend/errdesc.mli +++ b/infer/src/backend/errdesc.mli @@ -10,8 +10,6 @@ (** Create descriptions of analysis errors *) -open Utils - (** find the dexp, if any, where the given value is stored also return the type of the value if found *) val vpath_find : 'a Prop.t -> Sil.exp -> Sil.vpath * Sil.typ option diff --git a/infer/src/backend/errlog.ml b/infer/src/backend/errlog.ml index 078ed9ae2..45412d042 100644 --- a/infer/src/backend/errlog.ml +++ b/infer/src/backend/errlog.ml @@ -7,7 +7,6 @@ * of patent rights can be found in the PATENTS file in the same directory. *) -open Utils module L = Logging module F = Format diff --git a/infer/src/backend/errlog.mli b/infer/src/backend/errlog.mli index 0ffd9a651..d980baa7c 100644 --- a/infer/src/backend/errlog.mli +++ b/infer/src/backend/errlog.mli @@ -9,8 +9,6 @@ (** Module for error logs. *) -open Utils - (** Element of a loc trace *) type loc_trace_elem = { lt_level : int; (** nesting level of procedure calls *) diff --git a/infer/src/backend/exceptions.ml b/infer/src/backend/exceptions.ml index fca032bed..20300c5ce 100644 --- a/infer/src/backend/exceptions.ml +++ b/infer/src/backend/exceptions.ml @@ -10,7 +10,6 @@ module L = Logging module F = Format -open Utils type exception_visibility = (** visibility of the exception *) | Exn_user (** always add to error log *) diff --git a/infer/src/backend/exceptions.mli b/infer/src/backend/exceptions.mli index 1c0c48ebb..8a774336f 100644 --- a/infer/src/backend/exceptions.mli +++ b/infer/src/backend/exceptions.mli @@ -8,8 +8,6 @@ * of patent rights can be found in the PATENTS file in the same directory. *) -open Utils - (** Functions for logging and printing exceptions *) type exception_visibility = (** visibility of the exception *) diff --git a/infer/src/backend/exe_env.ml b/infer/src/backend/exe_env.ml index 09a045a2d..7d0b18fb2 100644 --- a/infer/src/backend/exe_env.ml +++ b/infer/src/backend/exe_env.ml @@ -10,7 +10,6 @@ (** Support for Execution environments *) -open Utils module L = Logging (** per-file data: type environment and cfg *) diff --git a/infer/src/backend/exe_env.mli b/infer/src/backend/exe_env.mli index cc3b17650..4d76b5330 100644 --- a/infer/src/backend/exe_env.mli +++ b/infer/src/backend/exe_env.mli @@ -8,8 +8,6 @@ * of patent rights can be found in the PATENTS file in the same directory. *) -open Utils - (** Support for Execution environments *) (** initial state, used to add cg's *) diff --git a/infer/src/backend/fork.ml b/infer/src/backend/fork.ml index 5cb437aa3..5cf77dfb6 100644 --- a/infer/src/backend/fork.ml +++ b/infer/src/backend/fork.ml @@ -10,7 +10,6 @@ module L = Logging module F = Format -open Utils module WeightedPnameSet = Set.Make(struct diff --git a/infer/src/backend/ident.ml b/infer/src/backend/ident.ml index 419beac07..fe7c6bd00 100644 --- a/infer/src/backend/ident.ml +++ b/infer/src/backend/ident.ml @@ -12,7 +12,6 @@ module L = Logging module F = Format -open Utils type name = string diff --git a/infer/src/backend/ident.mli b/infer/src/backend/ident.mli index 63e10e202..aa514d2a9 100644 --- a/infer/src/backend/ident.mli +++ b/infer/src/backend/ident.mli @@ -10,8 +10,6 @@ (** Identifiers: program variables and logical variables *) -open Utils - (** Program and logical variables. *) type t diff --git a/infer/src/backend/inferanalyze.ml b/infer/src/backend/inferanalyze.ml index 56c1de13c..3f69b5a32 100644 --- a/infer/src/backend/inferanalyze.ml +++ b/infer/src/backend/inferanalyze.ml @@ -12,7 +12,6 @@ module L = Logging module F = Format -open Utils open Yojson.Basic.Util (* This module, unused by default, generates random c files with procedure calls *) diff --git a/infer/src/backend/inferconfig.ml b/infer/src/backend/inferconfig.ml index ff1f428ae..4bcc8691b 100644 --- a/infer/src/backend/inferconfig.ml +++ b/infer/src/backend/inferconfig.ml @@ -7,8 +7,6 @@ * of patent rights can be found in the PATENTS file in the same directory. *) -open Utils - (** Name of the infer configuration file *) let inferconfig_file = ".inferconfig" diff --git a/infer/src/backend/inferprint.ml b/infer/src/backend/inferprint.ml index aee55f7fa..01b5891a8 100644 --- a/infer/src/backend/inferprint.ml +++ b/infer/src/backend/inferprint.ml @@ -10,7 +10,6 @@ module L = Logging module F = Format -open Utils open Jsonbug_j (** Outfile to save the latex report *) diff --git a/infer/src/backend/interproc.ml b/infer/src/backend/interproc.ml index 14c4d16f5..093f7520b 100644 --- a/infer/src/backend/interproc.ml +++ b/infer/src/backend/interproc.ml @@ -12,7 +12,6 @@ module L = Logging module F = Format -open Utils (** A node with a number of visits *) type visitednode = diff --git a/infer/src/backend/io_infer.ml b/infer/src/backend/io_infer.ml index 79b12058a..02fd12af9 100644 --- a/infer/src/backend/io_infer.ml +++ b/infer/src/backend/io_infer.ml @@ -11,7 +11,6 @@ (** Module to handle IO. Includes html and xml modules. *) module F = Format -open Utils (* =============== START of module Html =============== *) module Html : sig diff --git a/infer/src/backend/latex.ml b/infer/src/backend/latex.ml index 04153c9ab..d882ba71f 100644 --- a/infer/src/backend/latex.ml +++ b/infer/src/backend/latex.ml @@ -9,7 +9,6 @@ *) module F = Format -open Utils (** Produce output in latex *) diff --git a/infer/src/backend/localise.ml b/infer/src/backend/localise.ml index 95c6f923e..534208681 100644 --- a/infer/src/backend/localise.ml +++ b/infer/src/backend/localise.ml @@ -11,7 +11,6 @@ (** Support for localisation *) module F = Format -open Utils (** type of string used for localisation *) type t = string diff --git a/infer/src/backend/location.ml b/infer/src/backend/location.ml index 62bc99d16..693edaac6 100644 --- a/infer/src/backend/location.ml +++ b/infer/src/backend/location.ml @@ -7,7 +7,6 @@ * of patent rights can be found in the PATENTS file in the same directory. *) -open Utils module F = Format module L = Logging diff --git a/infer/src/backend/logging.ml b/infer/src/backend/logging.ml index af1a2eea8..0e2d859dc 100644 --- a/infer/src/backend/logging.ml +++ b/infer/src/backend/logging.ml @@ -11,8 +11,6 @@ (** log messages at different levels of verbosity *) module F = Format -open Utils - (* =============== START of module MyErr =============== *) (** type of printable elements *) diff --git a/infer/src/backend/logging.mli b/infer/src/backend/logging.mli index 4748b026c..225f2ba1a 100644 --- a/infer/src/backend/logging.mli +++ b/infer/src/backend/logging.mli @@ -8,8 +8,6 @@ * of patent rights can be found in the PATENTS file in the same directory. *) -open Utils - (** log messages at different levels of verbosity *) (** type of printable elements *) diff --git a/infer/src/backend/mangled.ml b/infer/src/backend/mangled.ml index cd9249a55..dcefdfdcc 100644 --- a/infer/src/backend/mangled.ml +++ b/infer/src/backend/mangled.ml @@ -11,7 +11,6 @@ (** Module for Mangled Names *) module F = Format -open Utils type t = { plain: string; diff --git a/infer/src/backend/mangled.mli b/infer/src/backend/mangled.mli index 853eb4a04..a07bb3f0b 100644 --- a/infer/src/backend/mangled.mli +++ b/infer/src/backend/mangled.mli @@ -10,8 +10,6 @@ (** Module for Mangled Names *) -open Utils - (** Type of mangled names *) type t diff --git a/infer/src/backend/match.ml b/infer/src/backend/match.ml index b760cceb3..fe9c3bf16 100644 --- a/infer/src/backend/match.ml +++ b/infer/src/backend/match.ml @@ -12,7 +12,6 @@ module L = Logging module F = Format -open Utils let mem_idlist i l = IList.exists (Ident.equal i) l diff --git a/infer/src/backend/match.mli b/infer/src/backend/match.mli index c508cbffa..3917a02bf 100644 --- a/infer/src/backend/match.mli +++ b/infer/src/backend/match.mli @@ -14,8 +14,6 @@ See {{: http://dx.doi.org/10.1007/978-3-540-73368-3_22 } CAV 2007 } for the therory involved. *) -open Utils - (* TODO: missing documentation *) val hpara_match_with_impl : bool -> Sil.hpara -> Sil.hpara -> bool val hpara_dll_match_with_impl : bool -> Sil.hpara_dll -> Sil.hpara_dll -> bool diff --git a/infer/src/backend/mleak_buckets.ml b/infer/src/backend/mleak_buckets.ml index 0178a4249..633fe4b12 100644 --- a/infer/src/backend/mleak_buckets.ml +++ b/infer/src/backend/mleak_buckets.ml @@ -10,8 +10,6 @@ (** This module handles buckets of memory leaks in Objective-C/C++ *) -open Utils - let objc_arc_flag = "objc_arc" let bucket_delimiter = "," diff --git a/infer/src/backend/objc_models.ml b/infer/src/backend/objc_models.ml index 500dc8221..68dda6191 100644 --- a/infer/src/backend/objc_models.ml +++ b/infer/src/backend/objc_models.ml @@ -9,8 +9,6 @@ (** This module handles C or Objective-C types for which there are special rules for memory management *) -open Utils - (** This module models special c struct types from the Apple's Core Foundation libraries for which there are particular rules for memory management. *) diff --git a/infer/src/backend/objc_models.mli b/infer/src/backend/objc_models.mli index 08cac3461..ff65669a9 100644 --- a/infer/src/backend/objc_models.mli +++ b/infer/src/backend/objc_models.mli @@ -10,8 +10,6 @@ (** This module models special c struct types from the Apple's Core Foundation libraries for which there are particular rules for memory management. *) -open Utils - (** This module models special c struct types from the Apple's Core Foundation libraries for which there are particular rules for memory management. *) diff --git a/infer/src/backend/ondemand.ml b/infer/src/backend/ondemand.ml index 3beef1282..b1d453f1f 100644 --- a/infer/src/backend/ondemand.ml +++ b/infer/src/backend/ondemand.ml @@ -11,7 +11,6 @@ module L = Logging module F = Format -open Utils let trace () = Config.from_env_variable "INFER_TRACE_ONDEMAND" let one_cluster_per_procedure () = false diff --git a/infer/src/backend/ondemand.mli b/infer/src/backend/ondemand.mli index bda22215d..0502ee85f 100644 --- a/infer/src/backend/ondemand.mli +++ b/infer/src/backend/ondemand.mli @@ -9,8 +9,6 @@ (** Module for on-demand analysis. *) -open Utils - (** Optional set of source dirs to analyze in on-demand mode. *) val read_dirs_to_analyze : unit -> StringSet.t option diff --git a/infer/src/backend/paths.ml b/infer/src/backend/paths.ml index f95218684..ba24f445f 100644 --- a/infer/src/backend/paths.ml +++ b/infer/src/backend/paths.ml @@ -12,7 +12,6 @@ module L = Logging module F = Format -open Utils (* =============== START of the Path module ===============*) diff --git a/infer/src/backend/paths.mli b/infer/src/backend/paths.mli index 975335474..d9001cc11 100644 --- a/infer/src/backend/paths.mli +++ b/infer/src/backend/paths.mli @@ -10,8 +10,6 @@ (** Execution Paths *) -open Utils - module Path : sig (** type for paths *) type t diff --git a/infer/src/backend/preanal.ml b/infer/src/backend/preanal.ml index ff945f75e..e24ccdeb6 100644 --- a/infer/src/backend/preanal.ml +++ b/infer/src/backend/preanal.ml @@ -9,7 +9,6 @@ *) module L = Logging -open Utils (** find all the predecessors of nodes, using exception links *) module AllPreds = struct diff --git a/infer/src/backend/printer.ml b/infer/src/backend/printer.ml index 73b37b98b..a9d520d53 100644 --- a/infer/src/backend/printer.ml +++ b/infer/src/backend/printer.ml @@ -12,7 +12,6 @@ module L = Logging module F = Format -open Utils (* No abbreviation for Util, as every module can depend on it *) (** return true if the node was visited during footprint and during re-execution*) let is_visited_phase node = diff --git a/infer/src/backend/procAttributes.ml b/infer/src/backend/procAttributes.ml index 196fe8211..f4bd92221 100644 --- a/infer/src/backend/procAttributes.ml +++ b/infer/src/backend/procAttributes.ml @@ -11,7 +11,6 @@ module L = Logging module F = Format -open Utils (** Type for ObjC accessors *) type objc_accessor_type = diff --git a/infer/src/backend/procAttributes.mli b/infer/src/backend/procAttributes.mli index 438a699eb..83d5a622f 100644 --- a/infer/src/backend/procAttributes.mli +++ b/infer/src/backend/procAttributes.mli @@ -9,8 +9,6 @@ (** Attributes of a procedure. *) -open Utils - type objc_accessor_type = | Objc_getter of Ident.fieldname | Objc_setter of Ident.fieldname diff --git a/infer/src/backend/procname.ml b/infer/src/backend/procname.ml index 3d4ef4156..f996b9dde 100644 --- a/infer/src/backend/procname.ml +++ b/infer/src/backend/procname.ml @@ -12,7 +12,6 @@ module L = Logging module F = Format -open Utils open Str type java_type = string option * string (* e.g. ("", "int") for primitive types or ("java.io", "PrintWriter") for objects *) diff --git a/infer/src/backend/procname.mli b/infer/src/backend/procname.mli index 04a4e3213..b37b40895 100644 --- a/infer/src/backend/procname.mli +++ b/infer/src/backend/procname.mli @@ -10,8 +10,6 @@ (** Module for Procedure Names *) -open Utils - (** Type of procedure names *) type t diff --git a/infer/src/backend/prop.ml b/infer/src/backend/prop.ml index 89066fab9..992540ed0 100644 --- a/infer/src/backend/prop.ml +++ b/infer/src/backend/prop.ml @@ -12,7 +12,6 @@ module L = Logging module F = Format -open Utils (** type to describe different strategies for initializing fields of a structure. [No_init] does not initialize any fields of the struct. [Fld_init] initializes the fields of the struct with fresh diff --git a/infer/src/backend/prop.mli b/infer/src/backend/prop.mli index e7f9e8339..db5c15434 100644 --- a/infer/src/backend/prop.mli +++ b/infer/src/backend/prop.mli @@ -10,7 +10,6 @@ (** Functions for Propositions (i.e., Symbolic Heaps) *) -open Utils open Sil type normal (** kind for normal props, i.e. normalized *) diff --git a/infer/src/backend/propgraph.ml b/infer/src/backend/propgraph.ml index 754770340..933ccb9ad 100644 --- a/infer/src/backend/propgraph.ml +++ b/infer/src/backend/propgraph.ml @@ -12,7 +12,6 @@ module F = Format module L = Logging -open Utils type t = Prop.normal Prop.t diff --git a/infer/src/backend/propgraph.mli b/infer/src/backend/propgraph.mli index 0e66016b8..f4c4abc72 100644 --- a/infer/src/backend/propgraph.mli +++ b/infer/src/backend/propgraph.mli @@ -10,8 +10,6 @@ (** Propositions seen as graphs *) -open Utils - type t (** prop considered as a graph *) type node (** node of the graph *) diff --git a/infer/src/backend/propset.ml b/infer/src/backend/propset.ml index 9b48a796c..26c0601aa 100644 --- a/infer/src/backend/propset.ml +++ b/infer/src/backend/propset.ml @@ -12,7 +12,6 @@ module L = Logging module F = Format -open Utils (** {2 Sets of Propositions} *) diff --git a/infer/src/backend/propset.mli b/infer/src/backend/propset.mli index 176fc33c8..c1e89cb7d 100644 --- a/infer/src/backend/propset.mli +++ b/infer/src/backend/propset.mli @@ -10,8 +10,6 @@ (** Functions for Sets of Propositions with and without sharing *) -open Utils - (** {2 Sets of Propositions} *) (** Sets of propositions. diff --git a/infer/src/backend/prover.ml b/infer/src/backend/prover.ml index 7a8955704..a52e57f56 100644 --- a/infer/src/backend/prover.ml +++ b/infer/src/backend/prover.ml @@ -12,7 +12,6 @@ module L = Logging module F = Format -open Utils let decrease_indent_when_exception thunk = try (thunk ()) diff --git a/infer/src/backend/rearrange.ml b/infer/src/backend/rearrange.ml index ab1e13b15..33fcac50f 100644 --- a/infer/src/backend/rearrange.ml +++ b/infer/src/backend/rearrange.ml @@ -12,7 +12,6 @@ module L = Logging module F = Format -open Utils let (++) = Sil.Int.add diff --git a/infer/src/backend/reporting.ml b/infer/src/backend/reporting.ml index e9d7dd99a..fee1aeb03 100644 --- a/infer/src/backend/reporting.ml +++ b/infer/src/backend/reporting.ml @@ -7,7 +7,6 @@ * of patent rights can be found in the PATENTS file in the same directory. *) -open Utils module L = Logging type log_t = diff --git a/infer/src/backend/serialization.ml b/infer/src/backend/serialization.ml index a529c307a..153b51184 100644 --- a/infer/src/backend/serialization.ml +++ b/infer/src/backend/serialization.ml @@ -10,7 +10,6 @@ module L = Logging module F = Format -open Utils (** Generic serializer *) type 'a serializer = (string -> 'a option) * (DB.filename -> 'a option) * (DB.filename -> 'a -> unit) diff --git a/infer/src/backend/serialization.mli b/infer/src/backend/serialization.mli index 9dd28884a..7a8ef67ba 100644 --- a/infer/src/backend/serialization.mli +++ b/infer/src/backend/serialization.mli @@ -10,8 +10,6 @@ (** Serialization of data stuctures *) -open Utils - (** Generic serializer *) type 'a serializer diff --git a/infer/src/backend/sil.ml b/infer/src/backend/sil.ml index b5ac55401..1fcba7f43 100644 --- a/infer/src/backend/sil.ml +++ b/infer/src/backend/sil.ml @@ -12,7 +12,6 @@ module L = Logging module F = Format -open Utils (** {2 Programs and Types} *) diff --git a/infer/src/backend/sil.mli b/infer/src/backend/sil.mli index 2d7212df8..fbdaddaad 100644 --- a/infer/src/backend/sil.mli +++ b/infer/src/backend/sil.mli @@ -10,8 +10,6 @@ (** The Smallfoot Intermediate Language *) -open Utils - (** {2 Programs and Types} *) (** Type to represent one @Annotation. *) diff --git a/infer/src/backend/specs.ml b/infer/src/backend/specs.ml index 9e591fa8f..93c4dea56 100644 --- a/infer/src/backend/specs.ml +++ b/infer/src/backend/specs.ml @@ -12,7 +12,6 @@ module L = Logging module F = Format -open Utils (* =============== START of support for spec tables =============== *) diff --git a/infer/src/backend/specs.mli b/infer/src/backend/specs.mli index 510313f56..95d748a10 100644 --- a/infer/src/backend/specs.mli +++ b/infer/src/backend/specs.mli @@ -10,8 +10,6 @@ (** Specifications and spec table *) -open Utils - (** {2 Spec Tables} *) (** Module for joined props: the result of joining together propositions repeatedly *) diff --git a/infer/src/backend/state.ml b/infer/src/backend/state.ml index 4cbff90f2..e52bde7a6 100644 --- a/infer/src/backend/state.ml +++ b/infer/src/backend/state.ml @@ -12,7 +12,6 @@ module L = Logging module F = Format -open Utils type const_map = Cfg.Node.t -> Sil.exp -> Sil.const option diff --git a/infer/src/backend/state.mli b/infer/src/backend/state.mli index 1b0617743..75023b0cd 100644 --- a/infer/src/backend/state.mli +++ b/infer/src/backend/state.mli @@ -10,8 +10,6 @@ (** State of symbolic execution *) -open Utils - (** Internal state *) type t diff --git a/infer/src/backend/symExec.ml b/infer/src/backend/symExec.ml index 3cf073c35..c0ba4d813 100644 --- a/infer/src/backend/symExec.ml +++ b/infer/src/backend/symExec.ml @@ -12,7 +12,6 @@ module L = Logging module F = Format -open Utils let rec idlist_assoc id = function | [] -> raise Not_found diff --git a/infer/src/backend/tabulation.ml b/infer/src/backend/tabulation.ml index 99f6f7461..49ed7a74b 100644 --- a/infer/src/backend/tabulation.ml +++ b/infer/src/backend/tabulation.ml @@ -12,7 +12,6 @@ module L = Logging module F = Format -open Utils type splitting = { sub: Sil.subst; diff --git a/infer/src/backend/typename.ml b/infer/src/backend/typename.ml index ad9afec0e..4aabe80af 100644 --- a/infer/src/backend/typename.ml +++ b/infer/src/backend/typename.ml @@ -7,7 +7,6 @@ * of patent rights can be found in the PATENTS file in the same directory. *) -open Utils module F = Format (** Named types. *) diff --git a/infer/src/checkers/annotations.ml b/infer/src/checkers/annotations.ml index af1718a99..95743497d 100644 --- a/infer/src/checkers/annotations.ml +++ b/infer/src/checkers/annotations.ml @@ -9,7 +9,6 @@ module F = Format module L = Logging -open Utils (** Annotations. *) diff --git a/infer/src/checkers/callbackChecker.ml b/infer/src/checkers/callbackChecker.ml index a957cb15e..38b5e7207 100644 --- a/infer/src/checkers/callbackChecker.ml +++ b/infer/src/checkers/callbackChecker.ml @@ -14,7 +14,6 @@ module F = Format module P = Printf module IdSet = Ident.IdentSet module FldSet = Ident.FieldSet -open Utils (** set of instance fields belonging to the current file that are assigned to null literals *) let fields_nullified = ref FldSet.empty diff --git a/infer/src/checkers/checkDeadCode.ml b/infer/src/checkers/checkDeadCode.ml index 7bfea5e30..cd592a619 100644 --- a/infer/src/checkers/checkDeadCode.ml +++ b/infer/src/checkers/checkDeadCode.ml @@ -9,7 +9,6 @@ module L = Logging module F = Format -open Utils open Dataflow (** Simple check for dead code. *) diff --git a/infer/src/checkers/checkers.ml b/infer/src/checkers/checkers.ml index e34a332e7..577f8dc74 100644 --- a/infer/src/checkers/checkers.ml +++ b/infer/src/checkers/checkers.ml @@ -11,7 +11,6 @@ module L = Logging module F = Format -open Utils let verbose = ref true diff --git a/infer/src/checkers/codeQuery.ml b/infer/src/checkers/codeQuery.ml index 060423516..5cb572bb0 100644 --- a/infer/src/checkers/codeQuery.ml +++ b/infer/src/checkers/codeQuery.ml @@ -11,7 +11,6 @@ module L = Logging module F = Format -open Utils let verbose = false let query = ref None diff --git a/infer/src/checkers/codeQueryAst.ml b/infer/src/checkers/codeQueryAst.ml index 9f949b3bf..1f1ecaf16 100644 --- a/infer/src/checkers/codeQueryAst.ml +++ b/infer/src/checkers/codeQueryAst.ml @@ -11,7 +11,6 @@ module L = Logging module F = Format -open Utils type expr = | Null diff --git a/infer/src/checkers/constantPropagation.ml b/infer/src/checkers/constantPropagation.ml index 60e9bfde8..09e1b7d5c 100644 --- a/infer/src/checkers/constantPropagation.ml +++ b/infer/src/checkers/constantPropagation.ml @@ -7,8 +7,6 @@ * of patent rights can be found in the PATENTS file in the same directory. *) -open Utils - module L = Logging diff --git a/infer/src/checkers/dataflow.ml b/infer/src/checkers/dataflow.ml index 6571d5216..c79869992 100644 --- a/infer/src/checkers/dataflow.ml +++ b/infer/src/checkers/dataflow.ml @@ -7,8 +7,6 @@ * of patent rights can be found in the PATENTS file in the same directory. *) -open Utils - module L = Logging type throws = diff --git a/infer/src/checkers/fragmentRetainsViewChecker.ml b/infer/src/checkers/fragmentRetainsViewChecker.ml index 9a55509b4..9e517b319 100644 --- a/infer/src/checkers/fragmentRetainsViewChecker.ml +++ b/infer/src/checkers/fragmentRetainsViewChecker.ml @@ -10,7 +10,6 @@ (** Make sure callbacks are always unregistered. drive the point home by reporting possible NPE's *) module P = Printf -open Utils let report_error fragment_typ fld fld_typ pname pdesc = let retained_view = "CHECKERS_FRAGMENT_RETAINS_VIEW" in diff --git a/infer/src/checkers/immutableChecker.ml b/infer/src/checkers/immutableChecker.ml index 51109a309..0165f0b59 100644 --- a/infer/src/checkers/immutableChecker.ml +++ b/infer/src/checkers/immutableChecker.ml @@ -9,7 +9,6 @@ module L = Logging module F = Format -open Utils (** Check an implicit cast when returning an immutable collection from a method whose type is mutable. *) let check_immutable_cast curr_pname curr_pdesc typ_expected typ_found_opt loc : unit = diff --git a/infer/src/checkers/patternMatch.ml b/infer/src/checkers/patternMatch.ml index eb1ae2f5e..75c00f1bc 100644 --- a/infer/src/checkers/patternMatch.ml +++ b/infer/src/checkers/patternMatch.ml @@ -11,7 +11,6 @@ module L = Logging module F = Format -open Utils let object_name = Mangled.from_string "java.lang.Object" diff --git a/infer/src/checkers/printfArgs.ml b/infer/src/checkers/printfArgs.ml index fc56cff0b..22656a473 100644 --- a/infer/src/checkers/printfArgs.ml +++ b/infer/src/checkers/printfArgs.ml @@ -9,7 +9,6 @@ module L = Logging module F = Format -open Utils type printf_signature = { unique_id: string; diff --git a/infer/src/checkers/registerCheckers.ml b/infer/src/checkers/registerCheckers.ml index 2ca424bb8..caafea4c8 100644 --- a/infer/src/checkers/registerCheckers.ml +++ b/infer/src/checkers/registerCheckers.ml @@ -11,7 +11,6 @@ module L = Logging module F = Format -open Utils (** Flags to activate checkers. *) let active_procedure_checkers () = diff --git a/infer/src/checkers/repeatedCallsChecker.ml b/infer/src/checkers/repeatedCallsChecker.ml index 8130e1067..ba57335e3 100644 --- a/infer/src/checkers/repeatedCallsChecker.ml +++ b/infer/src/checkers/repeatedCallsChecker.ml @@ -9,7 +9,6 @@ module L = Logging module F = Format -open Utils let checkers_repeated_calls_name = "CHECKERS_REPEATED_CALLS" diff --git a/infer/src/checkers/sqlChecker.ml b/infer/src/checkers/sqlChecker.ml index a364dba49..458866871 100644 --- a/infer/src/checkers/sqlChecker.ml +++ b/infer/src/checkers/sqlChecker.ml @@ -7,8 +7,6 @@ * of patent rights can be found in the PATENTS file in the same directory. *) -open Utils - module L = Logging diff --git a/infer/src/clang/cContext.ml b/infer/src/clang/cContext.ml index 0bc2ac8a8..94deaf9ae 100644 --- a/infer/src/clang/cContext.ml +++ b/infer/src/clang/cContext.ml @@ -10,9 +10,7 @@ (** Contains current class and current method to be translated as well as local variables, *) (** and the cg, cfg, and tenv corresponding to the current file. *) -open Utils open CFrontend_utils - module L = Logging type curr_class = diff --git a/infer/src/clang/cEnum_decl.ml b/infer/src/clang/cEnum_decl.ml index 2d2b2da89..776175d5d 100644 --- a/infer/src/clang/cEnum_decl.ml +++ b/infer/src/clang/cEnum_decl.ml @@ -10,7 +10,6 @@ (** Translate an enumeration declaration by adding it to the tenv and *) (** translating the code and adding it to a fake procdesc *) -open Utils open CFrontend_utils (*Check if the constant is in the map, in which case that means that all the *) diff --git a/infer/src/clang/cField_decl.ml b/infer/src/clang/cField_decl.ml index 1f8402cd0..e972b8466 100644 --- a/infer/src/clang/cField_decl.ml +++ b/infer/src/clang/cField_decl.ml @@ -9,7 +9,6 @@ (** Utility module to retrieve fields of structs of classes *) -open Utils open CFrontend_utils module L = Logging diff --git a/infer/src/clang/cFrontend.ml b/infer/src/clang/cFrontend.ml index d83a2b8a4..03ee2ce45 100644 --- a/infer/src/clang/cFrontend.ml +++ b/infer/src/clang/cFrontend.ml @@ -15,7 +15,6 @@ module L = Logging -open Utils open CFrontend_utils open CGen_trans diff --git a/infer/src/clang/cFrontend_errors.ml b/infer/src/clang/cFrontend_errors.ml index fe305801e..f9107b8d9 100644 --- a/infer/src/clang/cFrontend_errors.ml +++ b/infer/src/clang/cFrontend_errors.ml @@ -14,7 +14,6 @@ * - loc: the location where is occurs *) -open Utils open CFrontend_utils open General_utils diff --git a/infer/src/clang/cFrontend_utils.ml b/infer/src/clang/cFrontend_utils.ml index ff8a03168..36fa33b23 100644 --- a/infer/src/clang/cFrontend_utils.ml +++ b/infer/src/clang/cFrontend_utils.ml @@ -10,8 +10,6 @@ (** Module for utility functions for the whole frontend. Includes functions for printing, *) (** for transformations of ast nodes and general utility functions such as functions on lists *) -open Utils - module L = Logging module F = Format diff --git a/infer/src/clang/cLocation.ml b/infer/src/clang/cLocation.ml index 1ba991ae2..de69937b1 100644 --- a/infer/src/clang/cLocation.ml +++ b/infer/src/clang/cLocation.ml @@ -10,7 +10,6 @@ (** Module for function to retrieve the location (file, line, etc) of instructions *) open CFrontend_utils -open Utils (* Inside the json there may be code or type definitions from other files *) (* than the one passed as an argument. That current file in the translation is saved*) diff --git a/infer/src/clang/cMethod_decl.ml b/infer/src/clang/cMethod_decl.ml index f2a5fac1c..28daf4879 100644 --- a/infer/src/clang/cMethod_decl.ml +++ b/infer/src/clang/cMethod_decl.ml @@ -9,7 +9,6 @@ (** Process methods or functions declarations by adding them to the cfg. *) -open Utils open CFrontend_utils module L = Logging diff --git a/infer/src/clang/cMethod_trans.ml b/infer/src/clang/cMethod_trans.ml index 028183190..a1667facc 100644 --- a/infer/src/clang/cMethod_trans.ml +++ b/infer/src/clang/cMethod_trans.ml @@ -10,7 +10,6 @@ (** Methods for creating a procdesc from a method or function declaration *) (** and for resolving a method call and finding the right callee *) -open Utils open CFrontend_utils module L = Logging diff --git a/infer/src/clang/cTrans.ml b/infer/src/clang/cTrans.ml index 7d00b736c..85966ff02 100644 --- a/infer/src/clang/cTrans.ml +++ b/infer/src/clang/cTrans.ml @@ -9,7 +9,6 @@ (** Translates instructions: (statements and expressions) from the ast into sil *) -open Utils open CTrans_utils open CFrontend_utils diff --git a/infer/src/clang/cTrans_models.ml b/infer/src/clang/cTrans_models.ml index 167eb6d27..5c2684ef0 100644 --- a/infer/src/clang/cTrans_models.ml +++ b/infer/src/clang/cTrans_models.ml @@ -7,7 +7,6 @@ * of patent rights can be found in the PATENTS file in the same directory. *) -open Utils open CFrontend_utils open Objc_models diff --git a/infer/src/clang/cTrans_utils.ml b/infer/src/clang/cTrans_utils.ml index 12b58ce93..870e5c662 100644 --- a/infer/src/clang/cTrans_utils.ml +++ b/infer/src/clang/cTrans_utils.ml @@ -9,7 +9,6 @@ (** Utility methods to support the translation of clang ast constructs into sil instructions. *) -open Utils open CFrontend_utils module L = Logging diff --git a/infer/src/clang/cTypes.ml b/infer/src/clang/cTypes.ml index 45176e45e..dd7e815e5 100644 --- a/infer/src/clang/cTypes.ml +++ b/infer/src/clang/cTypes.ml @@ -9,7 +9,6 @@ (** Utility module for retrieving types *) -open Utils open CFrontend_utils module L = Logging diff --git a/infer/src/clang/cTypes_decl.ml b/infer/src/clang/cTypes_decl.ml index 06ea39389..e122ca1a1 100644 --- a/infer/src/clang/cTypes_decl.ml +++ b/infer/src/clang/cTypes_decl.ml @@ -9,7 +9,6 @@ (** Processes types and record declarations by adding them to the tenv *) -open Utils open CFrontend_utils module L = Logging diff --git a/infer/src/clang/cVar_decl.ml b/infer/src/clang/cVar_decl.ml index db0a0f74d..dc64d926a 100644 --- a/infer/src/clang/cVar_decl.ml +++ b/infer/src/clang/cVar_decl.ml @@ -10,7 +10,6 @@ (** Process variable declarations by saving them as local or global variables. *) (** Computes the local variables of a function or method to be added to the procdesc *) -open Utils open CFrontend_utils module L = Logging diff --git a/infer/src/clang/objcCategory_decl.ml b/infer/src/clang/objcCategory_decl.ml index cfbba6695..0001fb4dd 100644 --- a/infer/src/clang/objcCategory_decl.ml +++ b/infer/src/clang/objcCategory_decl.ml @@ -7,7 +7,6 @@ * of patent rights can be found in the PATENTS file in the same directory. *) -open Utils open CFrontend_utils module L = Logging diff --git a/infer/src/clang/objcInterface_decl.ml b/infer/src/clang/objcInterface_decl.ml index 552e0161d..43f5d2099 100644 --- a/infer/src/clang/objcInterface_decl.ml +++ b/infer/src/clang/objcInterface_decl.ml @@ -14,7 +14,6 @@ (* ObjectiveC doesn't have a notion of static or class fields. *) (* So, in this module we translate a class into a sil srtuct with an empty list of static fields.*) -open Utils open CFrontend_utils module L = Logging diff --git a/infer/src/clang/objcProperty_decl.ml b/infer/src/clang/objcProperty_decl.ml index 409b9b4d3..43042ecf0 100644 --- a/infer/src/clang/objcProperty_decl.ml +++ b/infer/src/clang/objcProperty_decl.ml @@ -15,7 +15,6 @@ (* - Second, in the class implementation, if synthetize is available, create the getters and setters, *) (* unless some of these methods has already been created before. *) -open Utils open CFrontend_utils let is_strong_property obj_c_property_decl_info = diff --git a/infer/src/clang/objcProtocol_decl.ml b/infer/src/clang/objcProtocol_decl.ml index 40b1cba3b..80853ae44 100644 --- a/infer/src/clang/objcProtocol_decl.ml +++ b/infer/src/clang/objcProtocol_decl.ml @@ -7,7 +7,6 @@ * of patent rights can be found in the PATENTS file in the same directory. *) -open Utils open CFrontend_utils module L = Logging diff --git a/infer/src/eradicate/eradicate.ml b/infer/src/eradicate/eradicate.ml index e98516389..ffc555306 100644 --- a/infer/src/eradicate/eradicate.ml +++ b/infer/src/eradicate/eradicate.ml @@ -11,7 +11,6 @@ module L = Logging module F = Format -open Utils open Dataflow (* ERADICATE CHECKER. TODOS:*) diff --git a/infer/src/eradicate/eradicateChecks.ml b/infer/src/eradicate/eradicateChecks.ml index c8ac9bb14..04c5592ad 100644 --- a/infer/src/eradicate/eradicateChecks.ml +++ b/infer/src/eradicate/eradicateChecks.ml @@ -7,7 +7,6 @@ * of patent rights can be found in the PATENTS file in the same directory. *) -open Utils module L = Logging (** Module for the checks called by Eradicate. *) diff --git a/infer/src/eradicate/modelTables.ml b/infer/src/eradicate/modelTables.ml index f4dbb304c..ed2170b97 100644 --- a/infer/src/eradicate/modelTables.ml +++ b/infer/src/eradicate/modelTables.ml @@ -12,8 +12,6 @@ * @nolint *) -open Utils - (* in strict mode cannot insert null in containers *) let strict_containers = false diff --git a/infer/src/eradicate/modelTables.mli b/infer/src/eradicate/modelTables.mli index 3a0e7a9cb..77cab0698 100644 --- a/infer/src/eradicate/modelTables.mli +++ b/infer/src/eradicate/modelTables.mli @@ -7,8 +7,6 @@ * of patent rights can be found in the PATENTS file in the same directory. *) -open Utils - type model_table_t = (string, bool * bool list) Hashtbl.t (** Name of this file. *) diff --git a/infer/src/eradicate/models.ml b/infer/src/eradicate/models.ml index dc4d5ade7..22fa40e2e 100644 --- a/infer/src/eradicate/models.ml +++ b/infer/src/eradicate/models.ml @@ -8,7 +8,6 @@ *) open ModelTables -open Utils module L = Logging (** Module for standard library models. *) diff --git a/infer/src/eradicate/typeAnnotation.ml b/infer/src/eradicate/typeAnnotation.ml index c79752c67..8707e3538 100644 --- a/infer/src/eradicate/typeAnnotation.ml +++ b/infer/src/eradicate/typeAnnotation.ml @@ -10,7 +10,6 @@ module L = Logging module F = Format module P = Printf -open Utils (** Module to represent annotations on types. *) diff --git a/infer/src/eradicate/typeCheck.ml b/infer/src/eradicate/typeCheck.ml index 9463966e4..fd5262af3 100644 --- a/infer/src/eradicate/typeCheck.ml +++ b/infer/src/eradicate/typeCheck.ml @@ -7,7 +7,6 @@ * of patent rights can be found in the PATENTS file in the same directory. *) -open Utils module L = Logging module F = Format diff --git a/infer/src/eradicate/typeErr.ml b/infer/src/eradicate/typeErr.ml index 531871fd4..1180b4a60 100644 --- a/infer/src/eradicate/typeErr.ml +++ b/infer/src/eradicate/typeErr.ml @@ -9,7 +9,6 @@ module L = Logging module P = Printf -open Utils (** Module for Type Error messages. *) diff --git a/infer/src/eradicate/typeOrigin.ml b/infer/src/eradicate/typeOrigin.ml index 3da59fcef..4832f7cc0 100644 --- a/infer/src/eradicate/typeOrigin.ml +++ b/infer/src/eradicate/typeOrigin.ml @@ -9,7 +9,6 @@ module L = Logging module P = Printf -open Utils (** Describe the origin of values propagated by the checker. *) diff --git a/infer/src/eradicate/typeState.ml b/infer/src/eradicate/typeState.ml index 648f33355..da22e58c3 100644 --- a/infer/src/eradicate/typeState.ml +++ b/infer/src/eradicate/typeState.ml @@ -10,7 +10,6 @@ module L = Logging module F = Format module P = Printf -open Utils (** Module for typestates: maps from expressions to annotated types, with extensions. *) diff --git a/infer/src/harness/androidFramework.ml b/infer/src/harness/androidFramework.ml index 6ed8d92e6..c5b8e4847 100644 --- a/infer/src/harness/androidFramework.ml +++ b/infer/src/harness/androidFramework.ml @@ -11,8 +11,6 @@ module L = Logging module F = Format module TypSet = Sil.TypSet -open Utils - (** Android lifecycle types and their lifecycle methods that are called by the framework *) (** work-in-progress list of known callback-registering method names *) diff --git a/infer/src/harness/androidFramework.mli b/infer/src/harness/androidFramework.mli index 1ed77a9cc..0efeef0d4 100644 --- a/infer/src/harness/androidFramework.mli +++ b/infer/src/harness/androidFramework.mli @@ -9,8 +9,6 @@ (** Android lifecycle types and their lifecycle methods that are called by the framework *) -open Utils - (** return the complete list of (package, lifecycle_classname, lifecycle_methods) trios *) val get_lifecycles : (string * string * string list) list diff --git a/infer/src/harness/harness.ml b/infer/src/harness/harness.ml index 98ae9da40..0913f55e8 100644 --- a/infer/src/harness/harness.ml +++ b/infer/src/harness/harness.ml @@ -10,8 +10,6 @@ module L = Logging module F = Format -open Utils - (** Automatically create a harness method to exercise code under test *) (** given a list [lst] = fst @ (e :: rest), a test predicate [test], and a list [to_insert], returns diff --git a/infer/src/harness/inhabit.ml b/infer/src/harness/inhabit.ml index 7e9228988..caa6f93ba 100644 --- a/infer/src/harness/inhabit.ml +++ b/infer/src/harness/inhabit.ml @@ -16,7 +16,6 @@ module P = Printf module IdSet = Ident.IdentSet module TypSet = Sil.TypSet module TypMap = Sil.TypMap -open Utils type lifecycle_trace = (Procname.t * Sil.typ option) list type callback_trace = (Sil.exp * Sil.typ) list diff --git a/infer/src/harness/inhabit.mli b/infer/src/harness/inhabit.mli index b985b275f..cc002b8fb 100644 --- a/infer/src/harness/inhabit.mli +++ b/infer/src/harness/inhabit.mli @@ -7,8 +7,6 @@ * of patent rights can be found in the PATENTS file in the same directory. *) -open Utils - (** Generate a procedure that calls a given sequence of methods. Useful for harness/test generation. *) type lifecycle_trace = (Procname.t * Sil.typ option) list diff --git a/infer/src/harness/stacktrace.ml b/infer/src/harness/stacktrace.ml index 1219b0b09..08911cfc6 100644 --- a/infer/src/harness/stacktrace.ml +++ b/infer/src/harness/stacktrace.ml @@ -11,7 +11,6 @@ module L = Logging module F = Format -open Utils type str_frame = { class_str : string; diff --git a/infer/src/harness/stacktrace.mli b/infer/src/harness/stacktrace.mli index d3c4c6431..6c663cc89 100644 --- a/infer/src/harness/stacktrace.mli +++ b/infer/src/harness/stacktrace.mli @@ -9,8 +9,6 @@ (** Module for parsing stack traces and using them to guide Infer analysis *) -open Utils - type stack_trace (** create an Infer-readable representation of a stack trace given its raw text *) diff --git a/infer/src/java/jAnnotation.ml b/infer/src/java/jAnnotation.ml index 5565bdc8e..d7e0f0fa0 100644 --- a/infer/src/java/jAnnotation.ml +++ b/infer/src/java/jAnnotation.ml @@ -9,7 +9,6 @@ *) open Javalib_pack -open Utils (** Translate an annotation. *) let translate a : Sil.annotation = diff --git a/infer/src/java/jClasspath.ml b/infer/src/java/jClasspath.ml index 145c56f6a..221bdf195 100644 --- a/infer/src/java/jClasspath.ml +++ b/infer/src/java/jClasspath.ml @@ -10,7 +10,6 @@ open Javalib_pack open Sawja_pack -open Utils module L = Logging diff --git a/infer/src/java/jFrontend.ml b/infer/src/java/jFrontend.ml index a94037d5b..ce26d2cd3 100644 --- a/infer/src/java/jFrontend.ml +++ b/infer/src/java/jFrontend.ml @@ -11,9 +11,6 @@ open Javalib_pack open Sawja_pack -open Utils - - module L = Logging diff --git a/infer/src/java/jMain.ml b/infer/src/java/jMain.ml index 3adf8e0f2..19b42195e 100644 --- a/infer/src/java/jMain.ml +++ b/infer/src/java/jMain.ml @@ -11,7 +11,6 @@ open Javalib_pack module L = Logging -open Utils let arg_desc = let options_to_keep = ["-results_dir"; "-project_root"] in diff --git a/infer/src/java/jTrans.ml b/infer/src/java/jTrans.ml index cb733f967..619c392f2 100644 --- a/infer/src/java/jTrans.ml +++ b/infer/src/java/jTrans.ml @@ -11,8 +11,6 @@ open Javalib_pack open Sawja_pack - -open Utils module L = Logging type invoke_kind = diff --git a/infer/src/java/jTransExn.ml b/infer/src/java/jTransExn.ml index ea69ed8b6..39e271433 100644 --- a/infer/src/java/jTransExn.ml +++ b/infer/src/java/jTransExn.ml @@ -8,7 +8,6 @@ * of patent rights can be found in the PATENTS file in the same directory. *) -open Utils open Javalib_pack open Sawja_pack diff --git a/infer/src/java/jTransStaticField.ml b/infer/src/java/jTransStaticField.ml index ede94bdcb..432094e26 100644 --- a/infer/src/java/jTransStaticField.ml +++ b/infer/src/java/jTransStaticField.ml @@ -8,7 +8,6 @@ * of patent rights can be found in the PATENTS file in the same directory. *) -open Utils open Javalib_pack open Sawja_pack diff --git a/infer/src/java/jTransType.ml b/infer/src/java/jTransType.ml index 4bd793cfc..9a0231ddf 100644 --- a/infer/src/java/jTransType.ml +++ b/infer/src/java/jTransType.ml @@ -11,9 +11,6 @@ open Javalib_pack open Sawja_pack - -open Utils - (** Type transformations between Javalib datatypes and sil datatypes *) exception Type_tranlsation_error of string diff --git a/infer/src/llvm/lMain.ml b/infer/src/llvm/lMain.ml index fb092c54e..8af646bf8 100644 --- a/infer/src/llvm/lMain.ml +++ b/infer/src/llvm/lMain.ml @@ -7,8 +7,6 @@ * of patent rights can be found in the PATENTS file in the same directory. *) -open Utils - let arg_desc = let options_to_keep = ["-results_dir"; "-project_root"] in let desc = diff --git a/infer/src/llvm/lParser.mly b/infer/src/llvm/lParser.mly index 528328966..5c9bee1d4 100644 --- a/infer/src/llvm/lParser.mly +++ b/infer/src/llvm/lParser.mly @@ -8,7 +8,6 @@ *) %{ - open Utils open LAst %} diff --git a/infer/src/llvm/lTrans.ml b/infer/src/llvm/lTrans.ml index 36bbfc192..da28ab529 100644 --- a/infer/src/llvm/lTrans.ml +++ b/infer/src/llvm/lTrans.ml @@ -7,7 +7,6 @@ * of patent rights can be found in the PATENTS file in the same directory. *) -open Utils open LAst exception ImproperTypeError of string diff --git a/infer/src/opensource/taint.ml b/infer/src/opensource/taint.ml index a5d476839..2f85b58ac 100644 --- a/infer/src/opensource/taint.ml +++ b/infer/src/opensource/taint.ml @@ -9,8 +9,6 @@ module L = Logging -open Utils - (** returns true if [callee_pname] returns a tainted value *) let returns_secret callee_pname = false diff --git a/infer/src/scripts/checkCopyright.ml b/infer/src/scripts/checkCopyright.ml index ad4b39938..d3b22cb84 100644 --- a/infer/src/scripts/checkCopyright.ml +++ b/infer/src/scripts/checkCopyright.ml @@ -9,7 +9,6 @@ module L = Logging module F = Format -open Utils let copyright_modified_exit_code = 1 let copyright_malformed_exit_code = 2