From b594cbdc5a81e1df8a574adaebf78c13f2306276 Mon Sep 17 00:00:00 2001 From: Jeremy Dubreil Date: Thu, 2 Nov 2017 07:52:16 -0700 Subject: [PATCH] [infer][nullable] no longer fail hard when the nullable suggestion checker cannot compute the post of a procedure Reviewed By: mbouaziz Differential Revision: D6218804 fbshipit-source-id: 49efcba --- infer/src/checkers/NullabilitySuggest.ml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/infer/src/checkers/NullabilitySuggest.ml b/infer/src/checkers/NullabilitySuggest.ml index d08bb70ea..0a4721d97 100644 --- a/infer/src/checkers/NullabilitySuggest.ml +++ b/infer/src/checkers/NullabilitySuggest.ml @@ -185,8 +185,10 @@ let checker {Callbacks.summary; proc_desc; tenv} = (* Assume all fields are not null in the beginning *) let initial = Domain.empty in let proc_data = ProcData.make_default proc_desc tenv in - match Analyzer.compute_post proc_data ~initial with + ( match Analyzer.compute_post proc_data ~initial with | Some post -> - report post proc_data ; summary + report post proc_data | None -> - L.(die InternalError) "Analyzer failed to compute post for %a" Typ.Procname.pp proc_name + L.internal_error "Analyzer failed to compute post for %a@." Typ.Procname.pp proc_name ) ; + summary +