From bbd09d39dd4925c0b714be6c1fca903ff27c67a5 Mon Sep 17 00:00:00 2001 From: Dulma Rodriguez Date: Tue, 5 Apr 2016 06:57:18 -0700 Subject: [PATCH] Remove modelling of setObject:forKeyedSubscript: of NSMutableDictionary to mean a crash when object is nil Reviewed By: akotulski Differential Revision: D3138627 fb-gh-sync-id: 087f815 fbshipit-source-id: 087f815 --- infer/models/objc/src/NSMutableDictionary.m | 2 -- infer/tests/endtoend/objc/UpdateDictNPETest.java | 1 - 2 files changed, 3 deletions(-) diff --git a/infer/models/objc/src/NSMutableDictionary.m b/infer/models/objc/src/NSMutableDictionary.m index 7bcccd98c..ac08b1e1d 100644 --- a/infer/models/objc/src/NSMutableDictionary.m +++ b/infer/models/objc/src/NSMutableDictionary.m @@ -16,8 +16,6 @@ @implementation NSMutableDictionary - (void)setObject:(id)object forKeyedSubscript:(id)aKey { - NSObject* obj = (NSObject*)object; - id isa = obj->isa; NSObject* key = (NSObject*)aKey; id isa2 = key->isa; } diff --git a/infer/tests/endtoend/objc/UpdateDictNPETest.java b/infer/tests/endtoend/objc/UpdateDictNPETest.java index 9ad7cd3d8..436c3837b 100644 --- a/infer/tests/endtoend/objc/UpdateDictNPETest.java +++ b/infer/tests/endtoend/objc/UpdateDictNPETest.java @@ -52,7 +52,6 @@ public class UpdateDictNPETest { public void nullDereferenceTest() throws InterruptedException, IOException, InferException { InferResults inferResults = InferRunner.runInferC(inferCmdNPD); String[] procedures = { - "update_dict_with_null", "update_dict_with_key_null", "update_array_with_null", "add_nil_to_array",