From bf0d1d88613025037d66212ec300d3797b759d21 Mon Sep 17 00:00:00 2001 From: Jules Villard Date: Wed, 4 Dec 2019 11:17:29 -0800 Subject: [PATCH] [uninit] do not spam spurious error Summary: This can happen for a number of reasons that are not errors (mostly the exit node being unreachable) so isn't actionable, and definitely not worth showing the user. It could be a debug message but I don't think that's even worth it. Other checkers don't warn in similar circumstances. With OCaml 4.08 we started actually seeing these error messages (differences in flushing behaviour?) so their annoying nature was revealed. Reviewed By: ngorogiannis Differential Revision: D18808460 fbshipit-source-id: a47a1dcb4 --- infer/src/checkers/uninit.ml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/infer/src/checkers/uninit.ml b/infer/src/checkers/uninit.ml index 2f3c947a1..7bd49420e 100644 --- a/infer/src/checkers/uninit.ml +++ b/infer/src/checkers/uninit.ml @@ -357,7 +357,4 @@ let checker {Callbacks.exe_env; summary} : Summary.t = | Some {RecordDomain.prepost} -> Payload.update_summary prepost summary | None -> - if Procdesc.Node.get_succs (Procdesc.get_start_node proc_desc) <> [] then ( - L.internal_error "Uninit analyzer failed to compute post for %a" Typ.Procname.pp proc_name ; - summary ) - else summary + summary