[config] Default to --allow-specs-cleanup

Reviewed By: akotulski

Differential Revision: D4110719

fbshipit-source-id: c6cfcb2

infer/lib/python/inferlib/analyze.py

@@ -233,10 +233,6 @@ class AnalyzerWrapper(object):
         ]
         infer_options = []
 
-        # remove specs if possible so that old issues are less likely
-        # to be reported
-        infer_options += ['-allow_specs_cleanup']
-
         infer_options += ['-inferconfig_home', utils.decode(os.getcwd())]
 
         if self.args.analyzer == config.ANALYZER_ERADICATE:

infer/src/base/Config.ml

@@ -505,7 +505,7 @@ and allow_leak =
     "Forget leaked memory during abstraction"
 
 and allow_specs_cleanup =
-  CLOpt.mk_bool ~deprecated:["allow_specs_cleanup"] ~long:"allow-specs-cleanup"
+  CLOpt.mk_bool ~deprecated:["allow_specs_cleanup"] ~long:"allow-specs-cleanup" ~default:true
     "Allow to remove existing specs before running analysis when it's not incremental"
 
 and (