Make Eradicate use on-demand analysis by default

Summary:
public
Use on-demand analysis for Eradicate

Reviewed By: cristianoc

Differential Revision: D2858806

fb-gh-sync-id: b577359

infer/lib/python/inferlib/analyze.py

@@ -445,9 +445,8 @@ class Infer:
             self.timing['makefile_generation'] = 0
 
         else:
-            if self.args.analyzer == config.ANALYZER_ERADICATE:
-                infer_analyze.append('-intraprocedural')
-            if self.args.analyzer == config.ANALYZER_CHECKERS:
+            if self.args.analyzer in [config.ANALYZER_CHECKERS,
+                                      config.ANALYZER_ERADICATE]:
                 os.environ['INFER_ONDEMAND'] = 'Y'
 
             os.environ['INFER_OPTIONS'] = ' '.join(infer_options)