to avoid redundancy, no longer print the name of the class when printing the name of a constructor

Summary:
public
The function `Procname.to_simplified_string ~withclass:true` used to print `MyClass.MyClass()` when printing the name of a Java constructor. It now prints `MyClass()`.

I made a separate diff for this changes as it affects the bug hash, especially for resource leaks.

Reviewed By: sblackshear

Differential Revision: D2748661

fb-gh-sync-id: 9f51871

infer/src/backend/procname.ml

@@ -303,9 +303,11 @@ let java_to_string ?(withclass = false) j verbosity =
         | [] -> ""
         | _ -> "..." in
       let method_name =
-        if j.method_name = "<init>" then java_get_simple_class (Java_method j)
-        else j.method_name in
-      cls_prefix ^ method_name ^ "(" ^ params ^ ")"
+        if j.method_name = "<init>" then
+          java_get_simple_class (Java_method j)
+        else
+          cls_prefix ^ j.method_name in
+      method_name ^ "(" ^ params ^ ")"
 
 (** Check if the class name is for an anonymous inner class. *)
 let is_anonymous_inner_class_name class_name =