From d4e4ed55bc60c877b86f56161827f9c6d5d39a43 Mon Sep 17 00:00:00 2001 From: Jules Villard Date: Tue, 28 May 2019 07:10:40 -0700 Subject: [PATCH] [objc] make quandary test run Summary: That test wasn't hooked up to `make test` and so regressed at some unknown time in the past. Just recording the new state of things for now. Reviewed By: ngorogiannis Differential Revision: D15495234 fbshipit-source-id: 14fb112de --- Makefile | 36 ++++++++++--------- .../codetoanalyze/objc/quandary/basics.m | 2 +- .../codetoanalyze/objc/quandary/issues.exp | 1 - 3 files changed, 20 insertions(+), 19 deletions(-) diff --git a/Makefile b/Makefile index 845c91ce7..da68ee555 100644 --- a/Makefile +++ b/Makefile @@ -87,23 +87,25 @@ endif ifeq ($(HAS_OBJC),yes) BUILD_SYSTEMS_TESTS += objc_getters_setters objc_missing_fld objc_retain_cycles objc_retain_cycles_weak DIRECT_TESTS += \ - objc_errors \ - objc_frontend \ - objc_ioslints \ - objc_linters \ - objc_linters-def-folder \ - objc_linters-for-test-only \ - objc_liveness \ - objc_nullable \ - objc_performance objc_uninit \ - objcpp_errors \ - objcpp_frontend \ - objcpp_linters \ - objcpp_linters-for-test-only \ - objcpp_liveness \ - objcpp_nullable \ - objcpp_racerd \ - objcpp_retain-cycles \ + objc_errors \ + objc_frontend \ + objc_ioslints \ + objc_linters \ + objc_linters-def-folder \ + objc_linters-for-test-only \ + objc_liveness \ + objc_nullable \ + objc_performance \ + objc_quandary \ + objc_uninit \ + objcpp_errors \ + objcpp_frontend \ + objcpp_linters \ + objcpp_linters-for-test-only \ + objcpp_liveness \ + objcpp_nullable \ + objcpp_racerd \ + objcpp_retain-cycles \ ifneq ($(XCODE_SELECT),no) BUILD_SYSTEMS_TESTS += xcodebuild_no_xcpretty diff --git a/infer/tests/codetoanalyze/objc/quandary/basics.m b/infer/tests/codetoanalyze/objc/quandary/basics.m index 219e7018e..225842165 100644 --- a/infer/tests/codetoanalyze/objc/quandary/basics.m +++ b/infer/tests/codetoanalyze/objc/quandary/basics.m @@ -15,7 +15,7 @@ + (void)notASink:(NSObject*)param; @end -void callSinkDirectBad() { +void FN_callSinkDirectBad() { NSObject* source = [InferTaint source]; [InferTaint sink:source]; } diff --git a/infer/tests/codetoanalyze/objc/quandary/issues.exp b/infer/tests/codetoanalyze/objc/quandary/issues.exp index e76e090d7..e69de29bb 100644 --- a/infer/tests/codetoanalyze/objc/quandary/issues.exp +++ b/infer/tests/codetoanalyze/objc/quandary/issues.exp @@ -1 +0,0 @@ -codetoanalyze/objc/quandary/basics.m, callSinkDirectBad, 2, QUANDARY_TAINT_ERROR, [return from InferTaint_source,call to InferTaint_sink:]