From d84a6b854f4f8d002c77c8c1d179f2e9a2f8b6b5 Mon Sep 17 00:00:00 2001 From: Sam Blackshear Date: Mon, 30 Jan 2017 16:01:03 -0800 Subject: [PATCH] [quandary] log instead of failing hard when specified source has no return value Reviewed By: jeremydubreil Differential Revision: D4483898 fbshipit-source-id: 0e8ea5a --- infer/src/quandary/TaintAnalysis.ml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/infer/src/quandary/TaintAnalysis.ml b/infer/src/quandary/TaintAnalysis.ml index bb6e182dd..7cdcb763c 100644 --- a/infer/src/quandary/TaintAnalysis.ml +++ b/infer/src/quandary/TaintAnalysis.ml @@ -431,8 +431,10 @@ module Make (TaintSpecification : TaintSpec.S) = struct let access_tree = add_source source ret_id ret_typ astate_with_sink.access_tree in { astate_with_sink with access_tree; } | Some _, None -> - failwithf - "%a is marked as a source, but has no return value" Procname.pp callee_pname + L.err + "Warning: %a is marked as a source, but has no return value" + Procname.pp callee_pname; + astate_with_sink | None, _ -> astate_with_sink in