From d8f50c748b2305d984b369d2eebd8ebba53ea09d Mon Sep 17 00:00:00 2001 From: Josh Berdine Date: Thu, 19 May 2016 15:35:26 -0700 Subject: [PATCH] Revise the units of measure for perf stats Summary: Report perf stats in terms of kb, mb, and gb instead of words. Reviewed By: jvillard Differential Revision: D3321108 fbshipit-source-id: 3ba18be --- infer/src/backend/PerfStats.ml | 34 +++++++++++++++++++++++++--------- 1 file changed, 25 insertions(+), 9 deletions(-) diff --git a/infer/src/backend/PerfStats.ml b/infer/src/backend/PerfStats.ml index 2ef91d32a..9d77dadc6 100644 --- a/infer/src/backend/PerfStats.ml +++ b/infer/src/backend/PerfStats.ml @@ -11,10 +11,17 @@ open! Utils +let words_to_kb n = n *. float_of_int (Sys.word_size / 8) /. 1024. +let words_to_mb n = words_to_kb n /. 1024. +let words_to_gb n = words_to_mb n /. 1024. + let register_report_at_exit file = Pervasives.at_exit (fun () -> try let gc_stats = Gc.quick_stat () in + let allocated_words = + gc_stats.minor_words +. gc_stats.major_words -. gc_stats.promoted_words in + let gc_ctrl = Gc.get () in let exit_timeofday = Unix.gettimeofday () in let exit_times = Unix.times () in let stats = @@ -24,17 +31,26 @@ let register_report_at_exit file = ("stime", `Float (exit_times.tms_stime -. initial_times.tms_stime)) ; ("cutime", `Float (exit_times.tms_cutime -. initial_times.tms_cutime)) ; ("cstime", `Float (exit_times.tms_cstime -. initial_times.tms_cstime)) ; - ("minor_words", `Float gc_stats.minor_words) ; - ("promoted_words", `Float gc_stats.promoted_words) ; - ("major_words", `Float gc_stats.major_words) ; + ("minor_gb", `Float (words_to_gb gc_stats.minor_words)) ; + ("promoted_gb", `Float (words_to_gb gc_stats.promoted_words)) ; + ("major_gb", `Float (words_to_gb gc_stats.major_words)) ; + ("allocated_gb", `Float (words_to_gb allocated_words)) ; ("minor_collections", `Int gc_stats.minor_collections) ; ("major_collections", `Int gc_stats.major_collections) ; ("compactions", `Int gc_stats.compactions) ; - ("top_heap_words", `Int gc_stats.top_heap_words) ; + ("top_heap_gb", `Float (words_to_gb (float_of_int gc_stats.top_heap_words))) ; + ("stack_kb", `Float (words_to_kb (float_of_int gc_stats.stack_size))) ; + ("minor_heap_kb", `Float (words_to_kb (float_of_int gc_ctrl.minor_heap_size))) ; ] in - let stats_oc = open_out file in - Yojson.Basic.pretty_to_channel stats_oc stats ; - close_out stats_oc - with _ -> - Format.fprintf Format.std_formatter "Info: failed to write stats to %s@." file + try + let stats_oc = open_out file in + Yojson.pretty_to_channel stats_oc stats ; + close_out stats_oc + with exc -> + Format.eprintf "Info: failed to write stats to %s@\n%s@\n%s@\n%s@." + file (Printexc.to_string exc) (Yojson.pretty_to_string stats) + (Printexc.get_backtrace ()) + with exc -> + Format.eprintf "Info: failed to compute stats for %s@\n%s@\n%s@." + file (Printexc.to_string exc) (Printexc.get_backtrace ()) )