revive the @PerforamanceCritical checker when using Buck

Summary:
public
The PerformanceCritical Checker was not running on Buck project due to a conflict between the incremental mode and the ondemand mode.

Reviewed By: cristianoc

Differential Revision: D2891649

fb-gh-sync-id: 0a503d8

infer/lib/python/infer

@@ -112,8 +112,11 @@ def main():
 
     args = global_argparser.parse_args(to_parse)
 
-    if (imported_module and not args.incremental and
-            capture_module_name != 'analyze'):
+    remove_infer_out = (imported_module
+                        and not args.incremental
+                        and capture_module_name != 'analyze'
+                        and not args.buck)
+    if remove_infer_out:
         analyze.remove_infer_out(args.infer_out)
 
     if imported_module:

infer/lib/python/inferlib/analyze.py

@@ -430,8 +430,7 @@ class Infer:
         elif self.args.project_root:
             infer_options += ['-project_root', self.args.project_root]
 
-        if self.args.analyzer in [config.ANALYZER_CHECKERS,
-                                  config.ANALYZER_ERADICATE]:
+        if self.args.analyzer in [config.ANALYZER_CHECKERS]:
             os.environ['INFER_ONDEMAND'] = 'Y'
 
         os.environ['INFER_OPTIONS'] = ' '.join(infer_options)

infer/lib/python/inferlib/bucklib.py

@@ -66,7 +66,6 @@ def prepare_build(args):
 
     infer_options = [
         '--buck',
-        '--incremental',
         '--analyzer', args.analyzer,
     ]