From e83c6170e5b5665bf81205bbd965c7b48d8423a7 Mon Sep 17 00:00:00 2001 From: Josh Berdine Date: Mon, 23 Mar 2020 06:18:55 -0700 Subject: [PATCH] [sledge] Improve tracing in unit tests Summary: It is more convenient, and harder to misunderstand, if the verbose tracing setting comes commented-out after the default non-verbose setting. Reviewed By: jvillard Differential Revision: D20583755 fbshipit-source-id: 06ecb0e9a --- sledge/lib/equality_test.ml | 4 +++- sledge/lib/exp_test.ml | 3 ++- sledge/lib/sh_test.ml | 5 ++++- sledge/lib/solver_test.ml | 2 ++ sledge/lib/term_test.ml | 5 ++++- 5 files changed, 15 insertions(+), 4 deletions(-) diff --git a/sledge/lib/equality_test.ml b/sledge/lib/equality_test.ml index da90bd149..4d0c22654 100644 --- a/sledge/lib/equality_test.ml +++ b/sledge/lib/equality_test.ml @@ -5,11 +5,13 @@ * LICENSE file in the root directory of this source tree. *) +(* [@@@warning "-32"] *) + let%test_module _ = ( module struct open Equality - let () = Trace.init ~margin:68 ~config:Trace.none () + let () = Trace.init ~margin:68 () (* let () = * Trace.init ~margin:160 diff --git a/sledge/lib/exp_test.ml b/sledge/lib/exp_test.ml index cebaece49..5b9c40ad3 100644 --- a/sledge/lib/exp_test.ml +++ b/sledge/lib/exp_test.ml @@ -7,9 +7,10 @@ let%test_module _ = ( module struct - (* let () = Trace.init ~margin:68 ~config:Trace.all () *) let () = Trace.init ~margin:68 () + (* let () = Trace.init ~margin:68 ~config:Trace.all () *) + open Exp let pp e = Format.printf "@\n{desc= %a; term= %a}@." pp e Term.pp e.term diff --git a/sledge/lib/sh_test.ml b/sledge/lib/sh_test.ml index 527af711f..fbfc00f5b 100644 --- a/sledge/lib/sh_test.ml +++ b/sledge/lib/sh_test.ml @@ -5,14 +5,17 @@ * LICENSE file in the root directory of this source tree. *) +(* [@@@warning "-32"] *) + let%test_module _ = ( module struct open Sh + let () = Trace.init ~margin:68 () + (* let () = * Trace.init ~margin:160 ~config:(Result.ok_exn (Trace.parse "+Sh")) () *) - let () = Trace.init ~margin:68 ~config:Trace.none () let pp = Format.printf "@\n%a@." pp let pp_raw = Format.printf "@\n%a@." pp_raw let pp_djn = Format.printf "@\n%a@." pp_djn diff --git a/sledge/lib/solver_test.ml b/sledge/lib/solver_test.ml index b4e85b70f..8828f715f 100644 --- a/sledge/lib/solver_test.ml +++ b/sledge/lib/solver_test.ml @@ -5,6 +5,8 @@ * LICENSE file in the root directory of this source tree. *) +(* [@@@warning "-32"] *) + let%test_module _ = ( module struct let () = diff --git a/sledge/lib/term_test.ml b/sledge/lib/term_test.ml index f9bace39a..16918b33e 100644 --- a/sledge/lib/term_test.ml +++ b/sledge/lib/term_test.ml @@ -5,11 +5,14 @@ * LICENSE file in the root directory of this source tree. *) +(* [@@@warning "-32"] *) + let%test_module _ = ( module struct - (* let () = Trace.init ~margin:68 ~config:Trace.all () *) let () = Trace.init ~margin:68 () + (* let () = Trace.init ~margin:68 ~config:Trace.all () *) + open Term let pp = Format.printf "@\n%a@." pp