From f4cdc235436b0ab8322d84d5d6150d36e48c515a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ezgi=20=C3=87i=C3=A7ek?= Date: Wed, 17 Apr 2019 05:59:51 -0700 Subject: [PATCH] [hoisting] Turn on hoisting of expensive functions by default Reviewed By: mbouaziz Differential Revision: D14971084 fbshipit-source-id: ccbf6055e --- infer/man/man1/infer-full.txt | 6 +++--- infer/man/man1/infer-report.txt | 6 +++--- infer/man/man1/infer.txt | 6 +++--- infer/src/base/Config.ml | 2 +- infer/tests/codetoanalyze/java/hoisting/Makefile | 2 +- infer/tests/codetoanalyze/java/hoistingExpensive/Makefile | 2 +- 6 files changed, 12 insertions(+), 12 deletions(-) diff --git a/infer/man/man1/infer-full.txt b/infer/man/man1/infer-full.txt index d514a3fe7..be7972fba 100644 --- a/infer/man/man1/infer-full.txt +++ b/infer/man/man1/infer-full.txt @@ -440,10 +440,10 @@ OPTIONS infer-diff(1), infer-events(1), infer-explore(1), infer-report(1), infer-reportdiff(1), and infer-run(1). - --hoisting-report-only-expensive - Activates: [Hoisting] Report loop-invariant calls only when the + --no-hoisting-report-only-expensive + Deactivates: [Hoisting] Report loop-invariant calls only when the function is expensive, i.e. at least linear (Conversely: - --no-hoisting-report-only-expensive) See also infer-report(1). + --hoisting-report-only-expensive) See also infer-report(1). --html Activates: Generate html report. (Conversely: --no-html) diff --git a/infer/man/man1/infer-report.txt b/infer/man/man1/infer-report.txt index b8cf2792b..e74cac96f 100644 --- a/infer/man/man1/infer-report.txt +++ b/infer/man/man1/infer-report.txt @@ -165,10 +165,10 @@ OPTIONS compiled or not (Conversely: --no-skip-analysis-in-path-skips-compilation) HOISTING OPTIONS - --hoisting-report-only-expensive - Activates: [Hoisting] Report loop-invariant calls only when the + --no-hoisting-report-only-expensive + Deactivates: [Hoisting] Report loop-invariant calls only when the function is expensive, i.e. at least linear (Conversely: - --no-hoisting-report-only-expensive) + --hoisting-report-only-expensive) ENVIRONMENT diff --git a/infer/man/man1/infer.txt b/infer/man/man1/infer.txt index 8f620ff0a..f1580a670 100644 --- a/infer/man/man1/infer.txt +++ b/infer/man/man1/infer.txt @@ -440,10 +440,10 @@ OPTIONS infer-diff(1), infer-events(1), infer-explore(1), infer-report(1), infer-reportdiff(1), and infer-run(1). - --hoisting-report-only-expensive - Activates: [Hoisting] Report loop-invariant calls only when the + --no-hoisting-report-only-expensive + Deactivates: [Hoisting] Report loop-invariant calls only when the function is expensive, i.e. at least linear (Conversely: - --no-hoisting-report-only-expensive) See also infer-report(1). + --hoisting-report-only-expensive) See also infer-report(1). --html Activates: Generate html report. (Conversely: --no-html) diff --git a/infer/src/base/Config.ml b/infer/src/base/Config.ml index 860751ee2..1d7944e42 100644 --- a/infer/src/base/Config.ml +++ b/infer/src/base/Config.ml @@ -1432,7 +1432,7 @@ and html = and hoisting_report_only_expensive = - CLOpt.mk_bool ~long:"hoisting-report-only-expensive" ~default:false + CLOpt.mk_bool ~long:"hoisting-report-only-expensive" ~default:true ~in_help:InferCommand.[(Report, manual_hoisting)] "[Hoisting] Report loop-invariant calls only when the function is expensive, i.e. at least \ linear" diff --git a/infer/tests/codetoanalyze/java/hoisting/Makefile b/infer/tests/codetoanalyze/java/hoisting/Makefile index 4c01c4304..c9587ed21 100644 --- a/infer/tests/codetoanalyze/java/hoisting/Makefile +++ b/infer/tests/codetoanalyze/java/hoisting/Makefile @@ -5,7 +5,7 @@ TESTS_DIR = ../../.. -INFER_OPTIONS = --loop-hoisting-only --purity --debug-exceptions +INFER_OPTIONS = --loop-hoisting-only --purity --no-hoisting-report-only-expensive --debug-exceptions INFERPRINT_OPTIONS = --issues-tests SOURCES = $(wildcard *.java) diff --git a/infer/tests/codetoanalyze/java/hoistingExpensive/Makefile b/infer/tests/codetoanalyze/java/hoistingExpensive/Makefile index c6275de05..086876816 100644 --- a/infer/tests/codetoanalyze/java/hoistingExpensive/Makefile +++ b/infer/tests/codetoanalyze/java/hoistingExpensive/Makefile @@ -5,7 +5,7 @@ TESTS_DIR = ../../.. -INFER_OPTIONS = --loop-hoisting-only --purity --hoisting-report-only-expensive --debug-exceptions +INFER_OPTIONS = --loop-hoisting-only --purity --debug-exceptions INFERPRINT_OPTIONS = --issues-tests SOURCES = $(wildcard *.java)