[infer][backend] the sserialization should not swallow the Sys_error when unmarshalling data from strings

Summary:
It feels risky to me to swallow the `Sys_error` here since this could hide deeper issues with the deserialization of summaries.

This is only used with the Buck Integration for Java when extracting the summaries from the jar files.

Reviewed By: sblackshear

Differential Revision: D7490123

fbshipit-source-id: 68cd556
master
Jeremy Dubreil 7 years ago committed by Facebook Github Bot
parent 007f057f3a
commit f63a9c0836

@ -60,7 +60,7 @@ let create_serializer (key: Key.t) : 'a serializer =
else Some value
in
let read_from_string (str: string) : 'a option =
try read_data (Marshal.from_string str 0) "string" with Sys_error _ -> None
read_data (Marshal.from_string str 0) "string"
in
(* The reads happen without synchronization.
The writes are synchronized with a .lock file. *)

Loading…
Cancel
Save