From fd434aacb8ab06f2aa6b7a3224f3e9bb87e148d4 Mon Sep 17 00:00:00 2001
From: Josh Berdine <jjb@fb.com>
Date: Tue, 15 Sep 2020 01:48:21 -0700
Subject: [PATCH] [ppx_trace] Refactor: Implement expansion of [%debug] using
 Ppxlib.Extension

Summary:
The expansion of the `[%debug]` extension point is simple and fits
into the pattern supported by `Ppxlib.Extension`. This diff simplifies
the mapper implementing the rest of the trace expansion by moving the
expansion of debug into a separate
`Ppxlib.Context_free.Rule.extension` rule.

Reviewed By: jvillard

Differential Revision: D23636201

fbshipit-source-id: 847c258fd
---
 sledge/ppx_trace/ppx_trace.ml | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/sledge/ppx_trace/ppx_trace.ml b/sledge/ppx_trace/ppx_trace.ml
index 26868aaee..d8c731419 100644
--- a/sledge/ppx_trace/ppx_trace.ml
+++ b/sledge/ppx_trace/ppx_trace.ml
@@ -50,6 +50,20 @@ Driver.Cookies.add_simple_handler "ppx_trace_enabled" Ast_pattern.__
       debug := true
   | _ -> () )
 
+let expand_debug ~ctxt =
+  let loc = Expansion_context.Extension.extension_point_loc ctxt in
+  ebool ~loc !debug
+
+let debug_extension =
+  Extension.V3.declare "debug" Extension.Context.expression
+    (Ast_pattern.pstr Ast_pattern.nil)
+    expand_debug
+
+let debug_rule = Context_free.Rule.extension debug_extension
+
+;;
+Driver.register_transformation ~rules:[debug_rule] "debug"
+
 let rec get_fun_name pat =
   match pat.ppat_desc with
   | Ppat_var {txt; _} -> txt
@@ -89,7 +103,6 @@ let mapper =
         (Nolabel, mod_name) :: (Nolabel, fun_name) :: args
       in
       match exp.pexp_desc with
-      | Pexp_extension ({txt= "debug"; loc}, PStr []) -> ebool ~loc !debug
       | Pexp_extension
           ( { txt=
                 ( "Trace.info" | "Trace.infok" | "Trace.printf"