From ffde64c0c9ecd3d2bef83e7ce55311d4a6221c06 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ezgi=20=C3=87i=C3=A7ek?= Date: Fri, 1 May 2020 03:52:33 -0700 Subject: [PATCH] [litho] Don't suppress reports on private methods Summary: We missed a legit issue due to this outdated heuristic Reviewed By: skcho Differential Revision: D21327809 fbshipit-source-id: 0c69702ad --- infer/src/checkers/RequiredProps.ml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/infer/src/checkers/RequiredProps.ml b/infer/src/checkers/RequiredProps.ml index 8c7f1018b..a8a9a7b42 100644 --- a/infer/src/checkers/RequiredProps.ml +++ b/infer/src/checkers/RequiredProps.ml @@ -181,9 +181,7 @@ let satisfies_heuristic ~callee_pname ~callee_summary_opt tenv = let should_report proc_desc tenv = let pname = Procdesc.get_proc_name proc_desc in - (not (is_litho_function pname)) - && (not (is_component_build_method pname tenv)) - && not (PredSymb.equal_access (Procdesc.get_access proc_desc) Private) + (not (is_litho_function pname)) && not (is_component_build_method pname tenv) let report astate tenv summary =