77b22ded03
Warn on unused identifiers
...
Summary:public
I have seen enough comments in this space by people during code review to switch on the analyses the compiler can already do. This diff is an automated renaming of unused identifiers to _, with a few additional changes made when reading the diff of the results for things that stood out as particularly strange. This base-lines all of the existing warnings. I'm not sure this is a good idea, since it might be better for those familiar with each part of the code to look at these warnings and use them as pointers to suspicious code.
Reviewed By: jeremydubreil
Differential Revision: D2938376
fb-gh-sync-id: 6e67817
shipit-source-id: 6e67817
9 years ago
02056079cf
Warn of unused values
...
Summary: public
Reviewed By: jvillard
Differential Revision: D2938326
fb-gh-sync-id: 3b93829
shipit-source-id: 3b93829
9 years ago
b155168083
Open Utils implicitly
...
Summary: public
Reviewed By: jvillard
Differential Revision: D2938316
fb-gh-sync-id: c6aa6c9
shipit-source-id: c6aa6c9
9 years ago
89338c86e9
Warn of unused constructors
...
Summary: public
Reviewed By: jvillard
Differential Revision: D2938283
fb-gh-sync-id: e2db32a
shipit-source-id: e2db32a
9 years ago
bd8284443c
Warn of unused extension (exception) constructors
...
Summary: public
Reviewed By: jvillard
Differential Revision: D2938275
fb-gh-sync-id: b784531
shipit-source-id: b784531
9 years ago
2a926d8294
Remove uses of assert false to get original ml location.
...
Reviewed By: jvillard, jberdine
Differential Revision: D2922516
fb-gh-sync-id: 153a2dd
shipit-source-id: 153a2dd
9 years ago
047eec5a6f
Refactor callbacks for Eradicate and Checkers.
...
Reviewed By: sblackshear
Differential Revision: D2911784
fb-gh-sync-id: cc01b4a
shipit-source-id: cc01b4a
9 years ago
7673d94600
Distinguish between class kinds: CPP, Java, Objc
...
Reviewed By: dulmarod
Differential Revision: D2866278
fb-gh-sync-id: 7b3cc33
9 years ago
162dc42b5b
Use a record for struct types instead of a 7-tuple.
...
Reviewed By: jeremydubreil, sblackshear
Differential Revision: D2863956
fb-gh-sync-id: 166647e
9 years ago
453709c3c8
Only propagate nullable to return value when environment variable is set.
...
Reviewed By: jeremydubreil
Differential Revision: D2852820
fb-gh-sync-id: f9d52ce
9 years ago
a8ee0e6361
Move Eradicate files to a separate directory.
...
Reviewed By: jberdine
Differential Revision: D2795316
fb-gh-sync-id: 1c60004
9 years ago
Josh Berdine
Cristiano Calcagno