9 Commits (5710a3e887ece514922623cabada125c1851b41b)

Author	SHA1	Message	Date
Sam Blackshear	15aaa39fea	allowing class-level Expensive and PerformanceCritical annotations ... Reviewed By: cristianoc Differential Revision: D3158000 fb-gh-sync-id: 88c78a3 fbshipit-source-id: 88c78a3	9 years ago
jrm	14d4f862eb	@Performance critical checker: compute the expensive call stack lazily when reporting errors ... Summary:public Before this diff, the checker was collecting in a bottom-up fashion all possible call trees from `PerforamanceCritical`-annotated methods to `Expensive`-annotated ones. With this diff, we just collect the names of the direct transitively expensive callees and compute the expensive call stacks when reporting errors only. Reviewed By: sblackshear Differential Revision: D2938635 fb-gh-sync-id: dcdd13c shipit-source-id: dcdd13c	9 years ago
jrm	4af130bf8d	remove subtyping rule for the @PerformanceCritical annotation ... Summary:public Is seems that automatically inheriting annotations like `PerformanceCritical` or `NoAllocation` is the right thing to do in general. Otherwise, we need to enforce sub-typing rules which in the best case just adds a little bit of documentation, but could miss important issues when the code is not fully annotated. I am simplifying this part to avoid adding boilerplate code for the `NoAllocation` case. Reviewed By: sblackshear Differential Revision: D2938627 fb-gh-sync-id: ddb668b shipit-source-id: ddb668b	9 years ago
Josh Berdine	63b57790f9	Fix indentation of multiline copyright comment ... Summary: public Lines other than the first of multi-line comments in non-ocaml files were flush right instead of aligned. Reviewed By: jvillard Differential Revision: D2739752 fb-gh-sync-id: c85f56e	9 years ago
jrm	a49b0965ef	Model `android.view.View.findViewById` as an expensive method ... Summary: public The method `android.view.View.findViewById` and should not be run performance critical parts of the code like scrolling. Reviewed By: sblackshear Differential Revision: D2698196 fb-gh-sync-id: 2716ad7	9 years ago
jrm	d712635feb	Automatically infer the @PerformanceCritical annotations from the overriden methods ... Summary: public This allows to run the checker and get feedback about potential expensive call stacks without having to annotate first all the methods that are overriding PerofrmanceCritical-annotated methods Reviewed By: cristianoc Differential Revision: D2693556 fb-gh-sync-id: cb60278	9 years ago
jrm	0cd533f892	Enforcing subtyping rules for @Expensive and @PerformanceCritical ... Summary: public This adds the following subtyping rules: - methods that are not annotated with Expensive cannot be overwritten by a method annotated with Expensive - methods annotated with PerformanceCritical must be overwitten by method annotated with PerformanceCritical Reviewed By: cristianoc Differential Revision: D2636076 fb-gh-sync-id: eb616c9	9 years ago
jrm	6b6b4d1949	Detecting if methods annotated with @PerformanceCritical transitively call methods annotated with @Expensive ... Summary: public Just works by running the analysis bottom-up and promoting any method as virtually annotated with `Expensive` whenever one of its callee is annotated with `Expensive` Reviewed By: cristianoc Differential Revision: D2635242 fb-gh-sync-id: 4401be6	9 years ago
jrm	f5ddb983fe	Initial version of the @Expensive checker ... Summary: public This is an initial version of the Expensive checker which only report violations on direct calls. The main objective is to setup all the files for this new checker. The next steps are: 1) run the checker in interprocedural mode 2) Save in the summary of a method foo() the annotation attribute Expensive if a direct callee of foo is annotated with Expensive 3) Check that Expensive is enforced by subtyping, i.e. check that non-expensive method cannot be overwritten by a method annotated with Expensive Reviewed By: cristianoc Differential Revision: D2629947 fb-gh-sync-id: 0e06f85	9 years ago