2 Commits (6a8a811e6917476424af06c671db2706678b19bd)

Author	SHA1	Message	Date
Jules Villard	a42e15147b	[pulse] fix test for by-ref automatic initialisation ... Summary: Pointers are hard... The previous test had no chance of doing initialisation of the pointer by reference and was in fact a false negative (and still is, fix incoming). Renamed functions to stress the false negative and added a test that is really (potentially) doing pointer initialisation by reference. Reviewed By: skcho Differential Revision: D18888008 fbshipit-source-id: 1e72408c7	5 years ago
Jules Villard	df49f318f6	[pulse] havoc formals passed by reference to unknown procedures ... Summary: This gets rid of false positives when something invalid (eg null) is passed by reference to an initialisation function. Havoc'ing what the contents of the pointer to results in being optimistic about said contents in the future. Also surprisingly gets rid of some FNs (which means it can also introduce FPs) in the `std::atomic` tests because a path condition becomes feasible with havoc'ing. There's a slight refinement possible where we don't havoc pointers to const but that's more involved and left as future work. Reviewed By: skcho Differential Revision: D18726203 fbshipit-source-id: 264b5daeb	5 years ago