infer_clone

Author	SHA1	Message	Date
Dulma Churchill	892b16b8c0	[closures preanalysis] [1/n] Adding first step of preanalysis to specialize methods with concrete closures they are called with Summary: This preanalysis in general aims to create specialized clones of methods that have blocks as arguments and that are called with concrete closures, and then call these clone methods instead of the original ones. One complication is what happens with the captured variables in the closure. What we do is we add them to the formals of the cloned method and passed them through to the concrete blocks. We do this transformation in two steps: 1. Go through all the callers of methods with blocks as parameters, and create the clone methods. In this preanalysis we only create the attributes for the new method, not the code. We also update the call instructions in the callers to represent a call to the cloned method with updated arguments: we don't need to pass closures arguments anymore, we instead pass the captured variables as new arguments. 2. We add the corresponding code to the newly created clones: this means swapping the call to the block variable with a call to the corresponding block. Moreover, we add some of the new formals (that correspond to the captured variables) to the arguments of the call. This diff implements step 1 of the analysis. The next diff D23216021 implements step 2. Reviewed By: ngorogiannis Differential Revision: D23109204 fbshipit-source-id: 91a5eb16b	4 years ago
Dulma Churchill	fc7437abb0	[biabduction] Delete Core Foundation models for Memory Leaks Summary: These models for Memory Leaks have been ported to Pulse, so we can remove the models in biabduction and corresponding tests. Reviewed By: skcho Differential Revision: D22206287 fbshipit-source-id: e17499ad3	5 years ago
Jules Villard	b1e35a728d	[biabd] rename test directories from {biabduction,errors,infer} to {biabduction} Summary: The directory names had some interesting variety due to historical reasons. - {c,cpp,objc,objcpp}/errors/ date from the time when infer was only biabduction - java/infer/ dates from the time when we had an "--analyzer" option and "infer" was one of them (sic), and eg another was "eradicate". - c/biabduction/ dates from the time when the biabduction analysis was being migrated to the "checkers" (AI) framework. For some reasons the tests there are not a subset of c/infer/ but seem to be entirely new tests. The convention now dictates that we should name all of these */biabduction/. This diff moves the existing tests from c/biabduction/ into c/biabduction/misc/. Reviewed By: mityal Differential Revision: D21300147 fbshipit-source-id: 516d1cb15	5 years ago

Author

SHA1

Message

Date

Dulma Churchill

[closures preanalysis] [1/n] Adding first step of preanalysis to specialize methods with concrete closures they are called with

Summary:
This preanalysis in general aims to create specialized clones of methods that have blocks as arguments and that are called with concrete closures, and then call these clone methods instead of the original ones.

One complication is what happens with the captured variables in the closure. What we do is we add them to the formals of the cloned method and passed them through to the concrete blocks.

We do this transformation in two steps:
1. Go through all the callers of methods with blocks as parameters, and create the clone methods. In this preanalysis we only create the attributes for the new method, not the code. We also update the call instructions in the callers to represent a call to the cloned method with updated arguments: we don't need to pass closures arguments anymore, we instead pass the captured variables as new arguments.
2. We add the corresponding code to the newly created clones: this means swapping the call to the block variable with a call to the corresponding block.  Moreover, we add some of the new formals (that correspond to the captured variables) to the arguments of the call.

This diff implements step 1 of the analysis.  The next diff D23216021 implements step 2.

Reviewed By: ngorogiannis

Differential Revision: D23109204

fbshipit-source-id: 91a5eb16b

Dulma Churchill

fc7437abb0

[biabduction] Delete Core Foundation models for Memory Leaks

Summary: These models for Memory Leaks have been ported to Pulse, so we can remove the models in biabduction and corresponding tests.

Reviewed By: skcho

Differential Revision: D22206287

fbshipit-source-id: e17499ad3

Jules Villard

b1e35a728d

[biabd] rename test directories from {biabduction,errors,infer} to {biabduction}

Summary:
The directory names had some interesting variety due to historical
reasons.
- {c,cpp,objc,objcpp}/errors/ date from the time when infer was only
  biabduction
- java/infer/ dates from the time when we had an "--analyzer" option and
  "infer" was one of them (sic), and eg another was "eradicate".
- c/biabduction/ dates from the time when the biabduction analysis was
  being migrated to the "checkers" (AI) framework. For some reasons the
  tests there are not a subset of c/infer/ but seem to be entirely new
  tests.

The convention now dictates that we should name all of these
*/biabduction/. This diff moves the existing tests from c/biabduction/
into c/biabduction/misc/.

Reviewed By: mityal

Differential Revision: D21300147

fbshipit-source-id: 516d1cb15

3 Commits (745f04f77dcf145b95ab05b116f7187710968b3d)