3cdb9f322e
[IR] Fix the function hashable_name for ObjC methods
...
Summary:
This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse.
The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`.
Reviewed By: ngorogiannis, jvillard
Differential Revision: D21570880
fbshipit-source-id: 13ed62cf8
5 years ago
d00d8b3597
[AL] Allow to match typedefs and pointers.
...
Differential Revision: D18779850
fbshipit-source-id: 9a0b09446
5 years ago
c9c4adebc2
[AL] Improve the predicate for checking visibility attribute and example rule for checking macro for category implementation
...
Reviewed By: skcho
Differential Revision: D18744625
fbshipit-source-id: 10b0c77b5
5 years ago
48da570aa0
[AL] Introduce a way of binding the two witnesses of an AND formula
...
Summary:
New syntax f1 AND-WITH-WITNESSES f2 : predicate_on_both_witnesses()
This is needed for a linter to check that a macro is present, see the test.
Reviewed By: skcho
Differential Revision: D18735988
fbshipit-source-id: a3be75c5e
5 years ago
766fc2c072
[AL] Adding a new transition to siblings
...
Reviewed By: skcho
Differential Revision: D18689255
fbshipit-source-id: f2b095382
5 years ago
e411db6f82
[AL] Make the transition Parameters work with function calls
...
Summary: The transition HOLDS-NEXT WITH-TRANSITION Parameters was only implemented for ObjC methods, now it also works on function calls.
Reviewed By: jvillard
Differential Revision: D18572760
fbshipit-source-id: 06e615cbe
5 years ago
86140581d5
[AL] Adding predicate for AL rule to check that a variable of a specific type is being captured in a block
...
Reviewed By: ddino
Differential Revision: D17261362
fbshipit-source-id: 81f2e4bdb
5 years ago
ab683af1f1
[objc frontend] Keep the counter for block names local to each procedure
...
Reviewed By: skcho
Differential Revision: D17282572
fbshipit-source-id: 116857a7e
5 years ago
24728dc093
New ObjC checker for calls to @optional methods
...
Summary:
It is unsafe to call protocol methods defined optional. Before calling them we should check it
the implementation exists by calling
`if ([object respondsToSelector:selector(...)]) ...`
Without the above check we get run time crashes.
Reviewed By: jvillard
Differential Revision: D15554951
fbshipit-source-id: f0560971b
6 years ago
2f3b376996
Added is_optional_objc_method predicate
...
Reviewed By: martintrojer
Differential Revision: D15468063
fbshipit-source-id: d3525082a
6 years ago
10ca0c3269
Fix detection of return type for instancetype when using NS_ASSUME_NONNUL
...
Reviewed By: jvillard
Differential Revision: D15317686
fbshipit-source-id: a13520499
6 years ago
4f982e9f63
Add predicate for Unavailable attr
...
Reviewed By: d16r
Differential Revision: D15198762
fbshipit-source-id: 88e8603d1
6 years ago
df438016f2
Adding SourceExp transition to AL
...
Reviewed By: martintrojer
Differential Revision: D15181376
fbshipit-source-id: f235a1375
6 years ago
5d4a27ea54
RFC: stop using _ to separate ObjC/C++ class name from method in Typ.Procname.to_string
...
Reviewed By: jvillard
Differential Revision: D14736442
fbshipit-source-id: 500df354b
6 years ago
274570f499
[objc] Fix test results for linters
...
Reviewed By: ngorogiannis
Differential Revision: D14279721
fbshipit-source-id: 95838158d
6 years ago
aae5192b79
fix vardecl const
...
Summary:
the predicate to check that a decl is const was not working for VarDecl.
This diff fixes this
Reviewed By: jvillard
Differential Revision: D14106798
fbshipit-source-id: 1f6c24113
6 years ago
30c470eb48
[tests] record error bucket in expected output
...
Summary:
It's useful to test that the bucket a given error is classified as doesn't
change over time without notice.
This records the bucket for *all* the tests, even though some never produce a
bucket. This is to be on the safe size instead of risking to forget adding the
bucket information when the test changes, or when copy/pasting from a test that
doesn't have buckets to one that does.
The implementation is pretty crude: it greps the beginning of the qualifier
string for a `[bucket]`.
Reviewed By: mbouaziz
Differential Revision: D8236393
fbshipit-source-id: b3b1eb9
7 years ago
8b882ac1df
Change license to MIT
...
Summary:
Change the license of the source code from BSD + PATENTS to MIT.
Change `checkCopyright` to reflect the new license and learn some new file
types.
Generated with:
```
git grep BSD | xargs -n 1 ./scripts/checkCopyright -i
```
Reviewed By: jeremydubreil, mbouaziz, jberdine
Differential Revision: D8071249
fbshipit-source-id: 97ca23a
7 years ago
eab7fd1242
Add predicates to check the receiver class type
...
Reviewed By: dulmarod
Differential Revision: D7888339
fbshipit-source-id: ecedc82
7 years ago
cb66e4212b
Add predicates for instance and class methods
...
Reviewed By: dulmarod
Differential Revision: D7875528
fbshipit-source-id: dce8360
7 years ago
275f4c3a8c
Add predicates to check for protocols
...
Reviewed By: dulmarod
Differential Revision: D7867975
fbshipit-source-id: 20d599d
7 years ago
439839a9fa
Add is_in_(interface/implementation) predicates
...
Reviewed By: dulmarod
Differential Revision: D7863886
fbshipit-source-id: d8268d9
7 years ago
7d4bd403df
Add is_objc_method_exposed predicate
...
Reviewed By: dulmarod
Differential Revision: D7862233
fbshipit-source-id: da2ee1b
7 years ago
01ee635902
Add is_objc_method_overriding predicate
...
Reviewed By: dulmarod
Differential Revision: D7859827
fbshipit-source-id: 14c58d2
7 years ago
d7cf002461
Add new ObjC predicates, mostly related to categories
...
Reviewed By: dulmarod
Differential Revision: D7809653
fbshipit-source-id: c21f721
7 years ago
d74f189dfe
[infer] add the report kind to the list of expected output
...
Reviewed By: dulmarod
Differential Revision: D7209545
fbshipit-source-id: aab32f3
7 years ago
a1010fb9fc
[linters] Ading predicate is_in_objc_class_named and make a verbose rule more targeted
...
Reviewed By: ddino
Differential Revision: D6323539
fbshipit-source-id: 5681c95
7 years ago
d8be5e0874
Added 'is_method_called_by_superclass'. A new predicate that checks if the caller name is super class in a 'method call'.
...
Reviewed By: dulmarod
Differential Revision: D6311990
fbshipit-source-id: 5c9919c
7 years ago
18782be7c9
[linters] Adding a new predicate for in an ObjC class that is subclass of some class
...
Reviewed By: ddino
Differential Revision: D6284441
fbshipit-source-id: bcdd389
7 years ago
2f8b749045
[objc] Better names for the block translation and using temp variables
...
Reviewed By: sblackshear
Differential Revision: D6125704
fbshipit-source-id: 7b6aefc
7 years ago
652af47da7
[linters] Add transition to parameters by position in the parameters list
...
Reviewed By: ddino
Differential Revision: D5911586
fbshipit-source-id: 263b7dc
7 years ago
f3b158a158
Fix use of SEL in AL
...
Reviewed By: jberdine
Differential Revision: D5847272
fbshipit-source-id: 08591aa
7 years ago
d8765d1d44
[linters] Include only base name of ObjC methods in the linters bug hash
...
Reviewed By: ddino
Differential Revision: D5815441
fbshipit-source-id: 059ff8d
7 years ago
7e3298711c
[AL] Compute a witness child node when computing formulas to be used for more precise bug hashing
...
Reviewed By: ddino
Differential Revision: D5767064
fbshipit-source-id: bff07cf
7 years ago
76bc7d686c
Add predicate for enum constants of a particular enum
...
Reviewed By: dulmarod
Differential Revision: D5637214
fbshipit-source-id: dccc65e
7 years ago
a6f8850617
[linters] Provide predicate for checking the current method in the context
...
Reviewed By: ddino
Differential Revision: D5658198
fbshipit-source-id: ed9ce7f
7 years ago
cdc54563d4
[Infer] Write a has_visibility_attribute predicate for AL
...
Reviewed By: dulmarod
Differential Revision: D5575154
fbshipit-source-id: 677a7af
7 years ago
ff30afac8b
[infer][al] fix the linters test output
...
Reviewed By: sblackshear
Differential Revision: D5493869
fbshipit-source-id: cc48374
7 years ago
a386ef5e83
Adding predicate for identify a selector with a particular name
...
Reviewed By: jvillard
Differential Revision: D5489581
fbshipit-source-id: edcb82e
7 years ago
416478d453
[linters] Predicate for checking enum constants
...
Reviewed By: akotulski
Differential Revision: D5423574
fbshipit-source-id: c1deb13
8 years ago
4a5d0e0b55
Adding ability to express properties on the hierachy of protocols
...
Reviewed By: dulmarod
Differential Revision: D5227505
fbshipit-source-id: f4f9774
8 years ago
dfca0cdcf7
[linters] Introduce whitelist and blacklist path, also multiple paths
...
Reviewed By: ddino
Differential Revision: D5209648
fbshipit-source-id: dbb77c2
8 years ago
55da0055c9
Predicate for `using namespace`
...
Reviewed By: dulmarod
Differential Revision: D5172430
fbshipit-source-id: 0cd9251
8 years ago
0809279b3b
Extending type parser to deal with typedefs
...
Reviewed By: dulmarod
Differential Revision: D5155322
fbshipit-source-id: 9af8d8b
8 years ago
46a539df82
[linters] Specify path in linters
...
Reviewed By: jvillard
Differential Revision: D5146904
fbshipit-source-id: 62b9d78
8 years ago
4e7c7f30c1
Extended transitions to universal quantified operators
...
Reviewed By: dulmarod
Differential Revision: D5094722
fbshipit-source-id: a20e96b
8 years ago
e77ca182a5
Added a lint for namespace
...
Reviewed By: dulmarod
Differential Revision: D5103566
fbshipit-source-id: 4092e73
8 years ago
bdd2395be6
Adding ability to get type of paramters.
...
Reviewed By: dulmarod
Differential Revision: D5069844
fbshipit-source-id: c591f76
8 years ago
cfd0a9b038
Extending type parser to parse ObjC classes.
...
Reviewed By: dulmarod
Differential Revision: D5052238
fbshipit-source-id: b678c32
8 years ago
99552edd7b
Extending type parser to parse pointer types.
...
Reviewed By: dulmarod
Differential Revision: D5036673
fbshipit-source-id: c16e311
8 years ago
Dulma Churchill
Dino Distefano
David Lively
Ezgi Çiçek
Jules Villard
Brandon Kieft
Jeremy Dubreil
Vivek Dhiman
Roy Li
Meng Zhang