e3132152cb
Check for the presence of removeObserver into class hierarchy
...
Reviewed By: jberdine
Differential Revision: D3669624
fbshipit-source-id: 559c66e
9 years ago
d23c99a4ea
Add blame_range to crashcontext analysis.
...
Reviewed By: jberdine
Differential Revision: D3674674
fbshipit-source-id: 8d2cc25
9 years ago
8ff9f2afab
making get_reachable_hpreds understand inductive predicates
...
Reviewed By: jvillard
Differential Revision: D3671401
fbshipit-source-id: 29e0f7e
9 years ago
dba179845b
Minor typo fix
...
Summary:
Typo in checkers.ml
Closes https://github.com/facebook/infer/pull/424
Reviewed By: martinoluca
Differential Revision: D3669416
Pulled By: jvillard
fbshipit-source-id: 1ef0fed
9 years ago
06cbdfa651
Cosmetic changes to improve Reason conversion
...
Summary: Changes for comment syntax and attachment.
Reviewed By: cristianoc
Differential Revision: D3647042
fbshipit-source-id: a540c0d
9 years ago
fe780cb6ff
Move comments to improve attachment
...
Summary:
Cosmetic changes to comments to improve the results of the Reason
comment attachment logic.
These were found using `git grep -nH -e 'in[ ]*(\*'` although the
attachment logic seems ok if the associated `let` is on the same line.
Some others were found with `git grep -nH -e ')[ ]*(\*'` although the
attachment logic seems ok if the associated `(` is on the same line.
Reviewed By: jvillard
Differential Revision: D3654027
fbshipit-source-id: 122aa3b
9 years ago
32146523ca
Enable warning: Unexpected documentation comment
...
Summary:
Enable warning 50 (Unexpected documentation comment) and fix all current
reports.
Reviewed By: jvillard
Differential Revision: D3653660
fbshipit-source-id: bfd36b9
9 years ago
d2a4028881
Call decl checkers on DeclStmt statements
...
Reviewed By: jvillard
Differential Revision: D3649322
fbshipit-source-id: 60b1b92
9 years ago
7c3110b76f
Extract stacktrace.ml regexp constructors to module level.
...
Reviewed By: jberdine
Differential Revision: D3654849
fbshipit-source-id: baf0487
9 years ago
751d027f8d
Remove 'open Jsonbug_t' scope clutter.
...
Reviewed By: jberdine
Differential Revision: D3654886
fbshipit-source-id: a567268
9 years ago
85add041d4
CI Tests for crashcontext handling of native methods
...
Reviewed By: sblackshear
Differential Revision: D3644266
fbshipit-source-id: 74e623c
9 years ago
5296688c1f
Match classname for stackframes in crashcontext checker.
...
Reviewed By: sblackshear
Differential Revision: D3643135
fbshipit-source-id: bb38b1b
9 years ago
0a8b95a856
Crashcontext ocaml method summary merging
...
Reviewed By: sblackshear
Differential Revision: D3643101
fbshipit-source-id: eaea332
9 years ago
d5848d8c94
Add parsing of native methods on the stacktrace.
...
Reviewed By: sblackshear
Differential Revision: D3642937
fbshipit-source-id: 43f5ed3
9 years ago
58d008a026
Add Stacktree ATD type for serializing/decerializing crashcontext results.
...
Reviewed By: jvillard
Differential Revision: D3642891
fbshipit-source-id: 6bdab73
9 years ago
ed85a129f5
Add DB.paths_matching utility method to recursively search files under a directory matching a function f.
...
Reviewed By: sblackshear
Differential Revision: D3642877
fbshipit-source-id: 6a9fc4b
9 years ago
3064caacdb
Remove stale Autounit module
...
Reviewed By: sblackshear
Differential Revision: D3648331
fbshipit-source-id: 3c06b38
9 years ago
bed9b31c62
Add general context to linters framework to implement smarter checks
...
Summary:
Make checks context-aware, to increase flexibility.
As an example application of this change, whenever an atomic property is accessed from within a synchronized block, skip reporting a `DIRECT_ATOMIC_PROPERTY_ACCESS` warning.
Reviewed By: jvillard
Differential Revision: D3648831
fbshipit-source-id: c033f45
9 years ago
aee1eeba3d
restore --pmd-xml functionality
...
Summary:
This was lost in the move to OCaml toplevel.
closes #396
Reviewed By: martinoluca
Differential Revision: D3620527
fbshipit-source-id: 4fd4629
9 years ago
f64be4596b
Implement containsOnlyLines matcher for tests
...
Reviewed By: jvillard
Differential Revision: D3648820
fbshipit-source-id: c4332f1
9 years ago
aed5e6bee8
Support butter knife 8's BindView annotation
...
Summary:
Butter Knife 8 switched from `Bind` to `BindView`
Closes https://github.com/facebook/infer/pull/407
Reviewed By: jberdine
Differential Revision: D3646737
Pulled By: cristianoc
fbshipit-source-id: 167da7b
9 years ago
0a747b8eb2
fixing some of the issues with passing classpath in a file
...
Reviewed By: jvillard
Differential Revision: D3604046
fbshipit-source-id: d6d97f6
9 years ago
3233666b11
extract callsite to its own module
...
Reviewed By: jberdine
Differential Revision: D3636918
fbshipit-source-id: eaaac66
9 years ago
ed9495a893
delete unused class-to-source mapper processor
...
Reviewed By: jberdine
Differential Revision: D3635470
fbshipit-source-id: 1e50d6e
9 years ago
8d279748fa
Adding a key to the lint issues
...
Reviewed By: jberdine
Differential Revision: D3620357
fbshipit-source-id: 49ae7d2
9 years ago
da2717ff2a
Migrate BAD_POINTER_COMPARISON check from backend to linters infra
...
Reviewed By: dulmarod
Differential Revision: D3614726
fbshipit-source-id: bdc7651
9 years ago
adb0ef8a78
Alphabetize CIssue
...
Reviewed By: dulmarod
Differential Revision: D3614384
fbshipit-source-id: 30a498b
9 years ago
ff597a6c03
Model init method in NSData and understand the field bytes
...
Reviewed By: sblackshear
Differential Revision: D3627970
fbshipit-source-id: f70d913
9 years ago
4490d9b033
fix recognition of inner class this guarded-by strings
...
Reviewed By: peterogithub
Differential Revision: D3620955
fbshipit-source-id: 374d078
9 years ago
fa8ae3e5e9
In the new framework where we go through every declaration we don't need a special case for properties anymore
...
Reviewed By: jberdine
Differential Revision: D3620115
fbshipit-source-id: bebbf10
9 years ago
ac9cabe677
Fixing Memory leak false positives in C++/ObjC
...
Summary: Follow up D3579581. We forget about memory acquired in resources with assumption that developers use raii and free memory in destructors.
Reviewed By: jvillard
Differential Revision: D3614056
fbshipit-source-id: 08fa112
9 years ago
9a79e74380
Crashbot results stitching and end-to-end testing.
...
Reviewed By: sblackshear
Differential Revision: D3619339
fbshipit-source-id: 46f3cc1
9 years ago
33b417c280
generalizing `add_trace` to `add_node`
...
Reviewed By: mbouaziz
Differential Revision: D3616281
fbshipit-source-id: 14fff92
9 years ago
706acdfd9e
generalizing get_trace to get_node
...
Reviewed By: mbouaziz
Differential Revision: D3614509
fbshipit-source-id: b1dc5dd
9 years ago
b500a5c4b5
don't warn in cases where GuardedBy string is clearly unrecognizable
...
Reviewed By: peterogithub
Differential Revision: D3615388
fbshipit-source-id: 8deb7af
9 years ago
e9aecd0afe
widen for access trees
...
Reviewed By: jberdine
Differential Revision: D3605415
fbshipit-source-id: 26f1eec
9 years ago
01ffc387bb
resolve symlinks recursively until the real infer executable is found
...
Summary:
This is needed on osx, where one of {`Sys.executable_name`, `Unix.readlink`}
does not behave the same as Linux.
Reviewed By: jberdine
Differential Revision: D3614254
fbshipit-source-id: a376636
9 years ago
76764c148a
Output the callee sumaries of -a crashcontext to per-method files.
...
Reviewed By: sblackshear
Differential Revision: D3612488
fbshipit-source-id: a068803
9 years ago
cbd1b9c7ba
Refactor common code on multiple methods of InferRestults
...
Reviewed By: sblackshear
Differential Revision: D3611216
fbshipit-source-id: 28ebd23
9 years ago
6a1a0d68da
create access paths from expressions
...
Reviewed By: jvillard
Differential Revision: D3605422
fbshipit-source-id: 1ccd9f8
9 years ago
10f10a90c6
diverge on `throw`
...
Summary:
Previously, we would translate `throw` with `return`. However, `throw` in
ObjC/C++ is often used to mean "abort". We now translate `throw` the same as
`exit` to prune these paths.
Reviewed By: akotulski
Differential Revision: D3594156
fbshipit-source-id: 81083bb
9 years ago
fb7aed07c6
typo and whitespace cleanup in cFrontend_config
...
Summary:
Minor stuff:
- GCCAst -> GCCAsm
- separate constants and mutable global state in cFrontend_config
- alphabetical ordering in cFrontend_config
Reviewed By: akotulski
Differential Revision: D3593858
fbshipit-source-id: 6f4d9c3
9 years ago
6469a6c37b
Implement '-a crashcontext' and '-st trace' options to invoke BoundedCallTree.ml from the command line.
...
Reviewed By: sblackshear
Differential Revision: D3606446
fbshipit-source-id: 9ac92fa
9 years ago
7fd1149f85
Add NPE check for weak variables captured in blocks
...
Reviewed By: sblackshear
Differential Revision: D3593746
fbshipit-source-id: bc5dea0
9 years ago
0aa5101a05
Replace space with _ in type names
...
Reviewed By: dulmarod
Differential Revision: D3605346
fbshipit-source-id: f4dce83
9 years ago
5ed50f5a97
Keep more precise information in constructor's var_exp_typ
...
Summary:
No longer allow pointer types to be passed inside var_exp_typ. We used to accept both forms,
but it won't be possible any longer once shared_ptr becomes pointer type.
Reviewed By: dulmarod
Differential Revision: D3593003
fbshipit-source-id: a830914
9 years ago
102f61e2a7
Move a few missing tests to the new location
...
Reviewed By: jvillard
Differential Revision: D3598867
fbshipit-source-id: 199f477
9 years ago
ed3470c30e
unify handling of many special cases in callExpr_trans
...
Summary:
1. Attempt to simplify callExpr_trans by merging multiple if-else branches into one in `CTrans_utils.builtin_trans`. Not every special case works that way, so some of them are still there.
2. On top of that, make type of parameters in `CTrans_models` functions `Procname.t` instead `Procname.t option`. This triggered some more changes to `callExpr_trans`.
3. Semi-randomly reorder instructions in `callExpr_trans`
This is mainly an attempt to clean up the code so any suggestions how to make it better are welcome.
Reviewed By: jvillard
Differential Revision: D3586419
fbshipit-source-id: aef8580
9 years ago
fb607ef388
Use the block captured variables as mangled
...
Reviewed By: sblackshear
Differential Revision: D3593332
fbshipit-source-id: 130e922
9 years ago
4078a2b276
pass down --reactive and --continue to python
...
Summary:
Python needs to know about these because it does different things depending on
whether these flags are passed or not.
Reviewed By: cristianoc
Differential Revision: D3593381
fbshipit-source-id: fe3194d
9 years ago
Martino Luca
Lázaro Clapp Jiménez Labora
Sam Blackshear
Vaibhav Tulsyan
Josh Berdine
Ryan Rhee
Jules Villard
Zac Sweers
Dulma Churchill
Daiva Naudziuniene
Andrzej Kotulski