Jules Villard 766a16cd90 [clang] enforce that `instruction` always returns one SIL expression ... Summary: Previously, the type of `trans_result` contained a list of SIL expressions. However, most of the time we expect to get exactly one, and getting a different number is a soft(!) error, usually returning `-1`. This splits `trans_result` into `control`, which contains the information needed for temporary computation (hence when we don't necessarily know the return value yet), and a new version of `trans_result` that includes `control`, the previous `exps` list but replaced by a single `return` expression instead, and a couple other values that made sense to move out of `control`. This allows some flexibility in the frontend compared to enforcing exactly one return expression always: if they are not known yet we stick to `control` instead (see eg `compute_controls_to_parent`). This creates more garbage temporary identifiers, however they do not show up in the final cfg. Instead, we see that temporary IDs are now often not consecutive... The most painful complication is in the treatment of `DeclRefExpr`, which was actually returning *two* expressions: the method name and the `this` object. Now the method name is a separate (optional) field in `trans_result`. Reviewed By: mbouaziz Differential Revision: D7881088 fbshipit-source-id: 41ad3b5		7 years ago
..
method_call.cpp	[tests] Clean up test files shared between frontend and endtoend tests	9 years ago
method_call.cpp.dot	[clang] enforce that `instruction` always returns one SIL expression	7 years ago