You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
67 lines
2.1 KiB
67 lines
2.1 KiB
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
import java.io.ByteArrayOutputStream;
|
|
import java.io.DataOutputStream;
|
|
import java.io.IOException;
|
|
import java.io.ObjectOutputStream;
|
|
import java.util.zip.GZIPOutputStream;
|
|
|
|
class BaosTest {
|
|
static void aBad() throws IOException {
|
|
ByteArrayOutputStream x = new ByteArrayOutputStream();
|
|
ObjectOutputStream y = new ObjectOutputStream(x);
|
|
y.writeObject(1337);
|
|
byte[] bytes = x.toByteArray(); // This may return partial results.
|
|
}
|
|
|
|
/** Bugfix for aBad. */
|
|
static void a1Ok() throws IOException {
|
|
ByteArrayOutputStream x = new ByteArrayOutputStream();
|
|
ObjectOutputStream y = new ObjectOutputStream(x);
|
|
y.writeObject(1337);
|
|
y.close();
|
|
byte[] bytes = x.toByteArray();
|
|
}
|
|
|
|
/** Another bugfix for aBad. */
|
|
static void a2Ok() throws IOException {
|
|
ByteArrayOutputStream x = new ByteArrayOutputStream();
|
|
ObjectOutputStream y = new ObjectOutputStream(x);
|
|
y.writeObject(1337);
|
|
y.flush();
|
|
byte[] bytes = x.toByteArray();
|
|
}
|
|
|
|
static void bBad() throws IOException {
|
|
ByteArrayOutputStream x = new ByteArrayOutputStream();
|
|
ObjectOutputStream y = new ObjectOutputStream(x);
|
|
y.writeObject(1337);
|
|
byte[] bytes = x.toByteArray();
|
|
y.close();
|
|
}
|
|
|
|
static void cBad() throws IOException {
|
|
ByteArrayOutputStream x = new ByteArrayOutputStream();
|
|
DataOutputStream y = new DataOutputStream(x);
|
|
y.writeLong(1337);
|
|
byte[] bytes = x.toByteArray();
|
|
}
|
|
|
|
/**
|
|
* This false positive is caused by the property being imprecise. However, it is also an example
|
|
* where, arguably, GZIPOutputStream breaks the behavioral contract on OutputStream: it may be
|
|
* surprising that finish() sends data to the underlying stream but flush() may not.
|
|
*/
|
|
static byte[] FP_dOk(final byte[] src) throws IOException {
|
|
ByteArrayOutputStream x = new ByteArrayOutputStream(src.length);
|
|
GZIPOutputStream y = new GZIPOutputStream(x);
|
|
y.write(src);
|
|
y.finish();
|
|
return x.toByteArray();
|
|
}
|
|
}
|