You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Josh Berdine cd9b64bd41 [sledge][llvm] Fix a possible crash in llvm_struct_name ... Summary: The implementation of `llvm_struct_name` before this diff calls `caml_copy_string`, which allocates, while the `result` local variable points to a block allocated by `caml_alloc_small` that has not yet been initialized. If the allocation in `caml_copy_string` triggers a garbage collection, then the GC root `result` contains a pointer to uninitialized data, which may crash the GC or lead to a memory corruption. This diff fixes this by allocating and initializing the string first and then allocating and initializing the option, thereby leaving no dangling pointers when allocations are made. The conversion from a C string to an OCaml string option is refactored into a function, `cstr_to_string_option`. This function is also used to simplify the definitions of `llvm_get_mdstring` and `llvm_string_of_const`. Upstream Differential Revision: https://reviews.llvm.org/D99393 Reviewed By: ngorogiannis Differential Revision: D27360848 fbshipit-source-id: f2daa7561		5 years ago
..
bin	[sledge] Add convenience links to executables	5 years ago
cli	[sledge] Add nonsupport for preallocated operand bundles	5 years ago
model	[sledge] Update build of sledge models to use vendored cxxabi	5 years ago
nonstdlib	[sledge] Add checking formatting to CI job	5 years ago
ppx_trace	[sledge] Update build to use vendored package for LLVM 11	5 years ago
report	[sledge] Change test report to use speedup ratio instead of percentage change	5 years ago
semantics	[sledge sem] Add a README	6 years ago
src	[sledge] Add support for BFloat type	5 years ago
test	[sledge] Update build to use vendored package for LLVM 11	5 years ago
tools	[sledge] Fix generation of sledge-help.txt	5 years ago
vendor	[sledge][llvm] Fix a possible crash in llvm_struct_name	5 years ago
.clang-format	Add initial version of LLAIR and LLVM to LLAIR translation	8 years ago
.gitignore	[sledge] Update build to use vendored package for LLVM 11	5 years ago
.ocamlformat	[sledge] Style: set ocamlformat config break-struct = force	5 years ago
.ocp-indent	Add initial version of LLAIR and LLVM to LLAIR translation	8 years ago
HACKING.adoc	[sledge] Rename contexts/profiles to be more conventional	6 years ago
Makefile	[sledge] Add checking formatting to CI job	5 years ago
ROADMAP.org	[sledge] Update roadmap	7 years ago
TODO.org	[sledge] Refactor: Replace Sh.with_pure with ~ignore_pure arg to Sh.fv	5 years ago
dune	[sledge] Add memtrace support	5 years ago
dune-project	[sledge] Build: Promote `import` subdirectory to a toplevel `nonstdlib` library	5 years ago
dune-workspace	[sledge] Style: Autoformat dune-project and dune-workspace files	5 years ago
sledge-help.txt	[sledge] Remove functionality depending on Llvm_linker.link_in	5 years ago
sledge.opam	[sledge] Add memtrace support	5 years ago