You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

112 lines
2.4 KiB

/*
* Copyright (c) Facebook, Inc. and its affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/
import android.app.Activity;
import android.os.Binder;
import android.os.Bundle;
import android.os.RemoteException;
import java.util.concurrent.Executor;
class MyActivity extends Activity {
Binder b;
private void bad() {
try {
b.transact(0, null, null, 0);
} catch (RemoteException r) {
}
}
// overrides so no Bad suffixes
@Override
protected void onCreate(Bundle savedInstanceState) {
bad();
}
@Override
public void onStart() {
bad();
}
@Override
public void onRestart() {
bad();
}
Object monitorA;
@ForNonUiThread private final Executor mNonUiThreadExecutor = null;
// method is a UI thread callback, and schedules a transaction in the background
// but it synchronises on the lock protecting the transaction, thus stalling the main thread
@Override
public void onStop() {
synchronized (monitorA) {
}
mNonUiThreadExecutor.execute(
new Runnable() {
@Override
public void run() {
synchronized (monitorA) {
bad();
}
}
});
}
Object monitorB, monitorC;
// method is a UI thread callback and deadlocks with work scheduled in
// another callback (onPause) but which schedules work to a background thread
@Override
public void onDestroy() {
synchronized (monitorC) {
synchronized (monitorB) {
}
}
}
@Override
public void onPause() {
mNonUiThreadExecutor.execute(
new Runnable() {
@Override
public void run() {
synchronized (monitorB) {
synchronized (monitorC) {
}
}
}
});
}
Object FP_monitorD, FP_monitorE;
// False positive: by the time the work is scheduled, no lock is held, so no deadlock
// Locks are named FP_* so that the report is clearly an FP (we can't change the name of the
// override).
@Override
public void onResume() {
synchronized (FP_monitorD) {
synchronized (FP_monitorE) {
}
}
mNonUiThreadExecutor.execute(
new Runnable() {
@Override
public void run() {
synchronized (FP_monitorE) {
synchronized (FP_monitorD) {
}
}
}
});
}
}