You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Jules Villard 3332dc1a42 [AI] improve disjunctive domain ... Summary: Replace horrible hack with ok hack. The main difficulty in implementing the disjunctive domain is to avoid the quadratic time complexity of executing the same disjuncts over and over again when going around loops: First time around a loop, assuming for example a single disjunct `d`: ``` [d] loop body [d1' \/ d2'] ``` Second time around the same loop: the new pre will be the join of the posts of predecessor nodes, so `old_pre \/ post(loop,old_pre)`, i.e. `d \/ d1' \/ d2'`. Now we need to execute `loop body` again *without running the symbolic execution of `d` again* (and the time after that we'll want to not execute `d`, `d1'`, or `d2'`). Horrible hack (before): Disjuncts have a boolean "visited" attached that does its best to keep track of whether a given disjunct is old or new. When executing a single *instruction* look at the flag and skip the state if it's old. Of course we have no way to know for sure so it turns out it was often wrongly re-executing old disjuncts. This was also producing the wrong results over even simple loops: only the last iteration would make it outside the loop for some reason. Overall, the semantics were pretty untractable and shady at best. New hack (this diff): only run instructions of a given *node* on disjuncts that are not physically equal to the "pre" ones already in the invariant map for the current node. This gives the correct result over simple loops and a nice performance improvement in general (probably the old heuristic was hitting the quadratic bad case more often). Reviewed By: skcho Differential Revision: D21154063 fbshipit-source-id: 5ee38c68c		5 years ago
..
GlobalTest.java	[impurity] Add initial Java support and don't run pulse twice	5 years ago
Localities.java	[pulse][purity] Add more naive models for Java	5 years ago
Makefile	[impurity] Add initial Java support and don't run pulse twice	5 years ago
PurityModeled.java	[impurity] Consider functions with empty pulse summary as impure	5 years ago
Test.java	[impurity] Consider exited functions as impure	5 years ago
TrickyExamples.java	[pulse] Fix printing order in contradiction for CItv and add tests	5 years ago
issues.exp	[AI] improve disjunctive domain	5 years ago