1、根据代码评审修改代码。2、修正部分页面标题。

app/controllers/application_controller.rb

@@ -256,16 +256,19 @@ class ApplicationController < ActionController::Base
   end
 
   def authorize_attachment_download(ctrl = params[:controller], action = params[:action], global = false)
-    if @attachment.container_type == "Memo"
+    case @attachment.container_type
-      allowed = User.current.allowed_to?(:memos_attachments_download,nil,:global => true)
+      when "Memo"
-    elsif  @attachment.container_type == "Message" && !@project.nil?
+        allowed = User.current.allowed_to?(:memos_attachments_download,nil,:global => true)
-      allowed = User.current.allowed_to?(:projects_attachments_download,@project,:global => false)
+      when "Message"
-    elsif @attachment.container_type == "Message" && !@course.nil?
+        if @project
-      allowed = User.current.allowed_to?(:course_attachments_download, @course, :global => false)
+          allowed = User.current.allowed_to?(:projects_attachments_download,@project,:global => false)
-    elsif @attachment.container_type == "contest"
+        elsif @course
-      return true
+          allowed = User.current.allowed_to?(:course_attachments_download, @course, :global => false)
-    else
+        end
-      return true
+      when "contest"
+        return true
+      else
+        return true
     end
 
     if allowed

app/controllers/attachments_controller.rb

@@ -61,7 +61,7 @@ class AttachmentsController < ApplicationController
   def download
     # modify by nwb
     # 下载添加权限设置
-    candown = false
+     candown = false
     if (@attachment.container.has_attribute?(:project) || @attachment.container.has_attribute?(:project_id)) && @attachment.container.project
       project = @attachment.container.project
       candown= User.current.member_of?(project) || (project.is_public && @attachment.is_public == 1)

app/models/attachment.rb

@@ -402,13 +402,8 @@ class Attachment < ActiveRecord::Base
 
   # Finds an attachment that matches the given token and that has no container
   def self.find_by_token(token)
-    if token.to_s =~ /^(\d+)\.([0-9a-f]+)$/
+    attachment = find_by_token_only(token)
-      attachment_id, attachment_digest = $1, $2
+    attachment if attachment.container.nil?
-      attachment = Attachment.where(:id => attachment_id, :digest => attachment_digest).first
-      if attachment && attachment.container.nil?
-        attachment
-      end
-    end
   end
 
   # Finds an attachment that matches the given token
@@ -416,9 +411,6 @@ class Attachment < ActiveRecord::Base
     if token.to_s =~ /^(\d+)\.([0-9a-f]+)$/
       attachment_id, attachment_digest = $1, $2
       attachment = Attachment.where(:id => attachment_id, :digest => attachment_digest).first
-      if attachment
-        attachment
-      end
     end
   end
 

app/views/courses/new.html.erb

@@ -11,3 +11,4 @@
     <%= javascript_tag "$('#course_name').focus();" %>
     </div>
 <% end %>
+<% html_title(l(:label_course_new)) -%>

app/views/school/index.html.erb

@@ -98,4 +98,4 @@
 
 	</ul>
 </div>
-
+<% html_title(l(:label_school_all)) -%>

app/views/stores/index.html.erb

@@ -69,3 +69,4 @@
         }
 	});
 </script>
+<% html_title(l(:label_stores_index)) -%>